-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MatterYamlTests] Properly translate descriptionString to description… #29251
[MatterYamlTests] Properly translate descriptionString to description… #29251
Conversation
PR #29251: Size comparison from 52caffd to 1a33888 Decreases (1 build for efr32)
Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure whether it makes sense to factor things out so we just use different classes for chip-tool and darwin-framework-tool, but this seems OK enough, given the encodings don't overlap much in practice.
examples/chip-tool/py_matter_chip_tool_adapter/matter_chip_tool_adapter/decoder.py
Outdated
Show resolved
Hide resolved
examples/chip-tool/py_matter_chip_tool_adapter/matter_chip_tool_adapter/decoder.py
Outdated
Show resolved
Hide resolved
examples/chip-tool/py_matter_chip_tool_adapter/matter_chip_tool_adapter/decoder.py
Outdated
Show resolved
Hide resolved
examples/chip-tool/py_matter_chip_tool_adapter/matter_chip_tool_adapter/decoder.py
Outdated
Show resolved
Hide resolved
… for YAML tests running with darwin-framework-tool [MatterYamlTests] Convert fabricIndex field properly when darwin-framework-tool is used and convert names that starts with an acronym properly as well
1a33888
to
b62ba03
Compare
PR #29251: Size comparison from aa688c4 to b62ba03 Decreases (1 build for efr32)
Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Fast-tracking test infrastructure change. |
… for YAML tests running with darwin-framework-tool (project-chip#29251) [MatterYamlTests] Convert fabricIndex field properly when darwin-framework-tool is used and convert names that starts with an acronym properly as well
… for YAML tests running with darwin-framework-tool
[MatterYamlTests] Convert fabricIndex field properly when darwin-framework-tool is used and convert names that starts with an acronym properly as well
Problem
When
Darwin-framework-tool
is used as a backend for running YAML tests, some of the struct fields are not translated properly. This PR update the adaptor to translate them as expected.