-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MatterYamlTests][darwin-framework-tool] Ensure that WaitForCommissio… #29252
Merged
mergify
merged 1 commit into
project-chip:master
from
vivien-apple:MatterYamlTests_DarwinFrameworkToolWaitForCommissioneeFix
Oct 19, 2023
Merged
[MatterYamlTests][darwin-framework-tool] Ensure that WaitForCommissio… #29252
mergify
merged 1 commit into
project-chip:master
from
vivien-apple:MatterYamlTests_DarwinFrameworkToolWaitForCommissioneeFix
Oct 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs and
jmartinez-silabs
September 14, 2023 12:08
pullapprove
bot
requested review from
yunhanw-google,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
woody-apple and
younghak-hwang
September 14, 2023 12:09
PR #29252: Size comparison from 52caffd to 67a0399 Decreases (1 build for efr32)
Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
examples/darwin-framework-tool/commands/delay/WaitForCommissioneeCommand.mm
Outdated
Show resolved
Hide resolved
vivien-apple
force-pushed
the
MatterYamlTests_DarwinFrameworkToolWaitForCommissioneeFix
branch
from
September 15, 2023 09:42
67a0399
to
dbb03ab
Compare
PR #29252: Size comparison from d104699 to dbb03ab Decreases (1 build for efr32)
Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
examples/darwin-framework-tool/commands/delay/WaitForCommissioneeCommand.mm
Outdated
Show resolved
Hide resolved
…nee works after a reboot
vivien-apple
force-pushed
the
MatterYamlTests_DarwinFrameworkToolWaitForCommissioneeFix
branch
from
September 26, 2023 12:48
dbb03ab
to
a10b501
Compare
PR #29252: Size comparison from 6bb0b71 to a10b501 Decreases (1 build for telink)
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
approved these changes
Oct 19, 2023
woody-apple
approved these changes
Oct 19, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…nee works after a reboot (project-chip#29252)
shripad621git
pushed a commit
to shripad621git/connectedhomeip
that referenced
this pull request
Oct 31, 2023
…nee works after a reboot (project-chip#29252)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nee works after a reboot
Problem
When using
darwin-framework-tool
as a backend to run YAML tests, 'WaitForCommissionee' does not works as expected after an accessory reboot.