-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use LwIP defines if CHIP_SYSTEM_CONFIG_USE_LWIP is not set. #29408
Merged
mergify
merged 2 commits into
project-chip:master
from
bzbarsky-apple:fix-lwip-defines-mrp
Sep 22, 2023
Merged
Don't use LwIP defines if CHIP_SYSTEM_CONFIG_USE_LWIP is not set. #29408
mergify
merged 2 commits into
project-chip:master
from
bzbarsky-apple:fix-lwip-defines-mrp
Sep 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mhazley
September 22, 2023 05:25
pullapprove
bot
requested review from
p0fi,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
September 22, 2023 05:25
PR #29408: Size comparison from 05bcbec to 00d0ed5 Increases (5 builds for cc32xx, psoc6)
Full report (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
rojer
reviewed
Sep 22, 2023
PR #29408: Size comparison from 05bcbec to 8abb92c Increases above 0.2%:
Increases (18 builds for bl602, bl702, bl702l, cc32xx, esp32, nrfconnect, psoc6, telink)
Decreases (5 builds for bl702, bl702l)
Full report (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
saurabhst
approved these changes
Sep 22, 2023
andy31415
approved these changes
Sep 22, 2023
jmartinez-silabs
approved these changes
Sep 22, 2023
pidarped
approved these changes
Sep 22, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…oject-chip#29408) * Don't use LwIP defines if CHIP_SYSTEM_CONFIG_USE_LWIP is not set. Fixes project-chip#29211 * Address review comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29211