-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove include_yamltests arg, and always install the whl for python tests #29456
Merged
mergify
merged 3 commits into
project-chip:master
from
tehampson:remove-include-yamltests-flag-0926
Sep 29, 2023
Merged
Remove include_yamltests arg, and always install the whl for python tests #29456
mergify
merged 3 commits into
project-chip:master
from
tehampson:remove-include-yamltests-flag-0926
Sep 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #29456: Size comparison from 8ace42e to e0141a9 Increases (1 build for telink)
Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #29456: Size comparison from 8ace42e to 26f231f Full report (17 builds for cc13x4_26x4, cc32xx, k32w, linux, mbed, nrfconnect, qpg)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
September 26, 2023 19:01
pullapprove
bot
requested review from
mhazley,
mkardous-silabs,
mlepage-google,
mrjerryjohns,
mspang,
nivi-apple,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
vivien-apple,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
September 26, 2023 19:02
PR #29456: Size comparison from 8ace42e to 365314d Increases (1 build for telink)
Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
cecille
approved these changes
Sep 28, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…ests (project-chip#29456) * Remove include_yamltests arg, and install always for python tests * CI fixes * CI fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to #27437, some build scripts were installing the python packages into the build environment located at
.environment/pigweed-venv/
. This cause all sort of at the time, and the issues were reduced by installing the yamltest python whl only if there was a need. Now that we always have a separate python environment, we shouldn't run into the same issues we previously were, and we can removeinclude_yamltests
.This somewhat reduces number of arguments that developers need to keep track, at the cost of less then 4 seconds for the additional
pip install
command to run. (Less then 4 seconds is based on runningtime time pip install --upgrade out/python_lib/<path_to_yamltest_whl>
in my local environment). Note that the yamltest wheel was already being compiled it is just that we are now always installing it into the provided--install_virtual_env
Test: CI pass