-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove usage of __has_include
and usage of USE_ZAP_CONFIG
#29492
Merged
mergify
merged 3 commits into
project-chip:master
from
andy31415:remove_include_check_pragma
Oct 2, 2023
Merged
Remove usage of __has_include
and usage of USE_ZAP_CONFIG
#29492
mergify
merged 3 commits into
project-chip:master
from
andy31415:remove_include_check_pragma
Oct 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy31415
commented
Sep 28, 2023
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no and
kpschoedel
September 28, 2023 16:28
pullapprove
bot
requested review from
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
September 28, 2023 16:28
andy31415
changed the title
Remove usage of
Remove usage of Sep 28, 2023
has_include
and usage of USE_ZAP_CONFIG
__has_include
and usage of USE_ZAP_CONFIG
PR #29492: Size comparison from 3c2a5ed to fd03ac4 Full report (41 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #29492: Size comparison from 3c2a5ed to bea7faf Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
s07641069
approved these changes
Sep 29, 2023
arkq
approved these changes
Oct 2, 2023
tcarmelveilleux
approved these changes
Oct 2, 2023
jmartinez-silabs
approved these changes
Oct 2, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…t-chip#29492) * Start removing split defines and setups for InitDataModelHandler * Restyle * Add EmptyDataModelHandler to Matter.framework. --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This conditional include seems dangerous and fails on imports of source code in alternate build systems - instead of getting compile errors, code would compile (due to weak linkage) and just crash at runtime.
Moved EmptyDataModelHandler into separate source set. The sourceset itself is NOT used but darwin framework includes this file directly (and needs it).