Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove top-level struct and enum support from IDL processing #29511

Merged
merged 7 commits into from
Sep 29, 2023
Merged

Remove top-level struct and enum support from IDL processing #29511

merged 7 commits into from
Sep 29, 2023

Conversation

andy31415
Copy link
Contributor

No code generator uses them and these make the code more complex. In particular:

  • these are inconsistent (why enum and structs, but not bitmaps ... this was likely because of what existed in the idl)
  • data was already duplicated (both top level and within clusters)
  • IDL zapt were actually not even showing enums, just structs

Changes:

  • remove these from types and lark grammar
  • updated backwards compatibility and zapxml parsers
  • re-generated matter files
  • fixed up unit tests and updated unit test matter files to move global structs to individual clusters

@github-actions
Copy link

github-actions bot commented Sep 29, 2023 •
edited
Loading

PR #29511: Size comparison from 4a9dab1 to 32b7864

Full report (10 builds for cc32xx, k32w, mbed, nrfconnect, qpg)
platform target config section 4a9dab1 32b7864 change % change
cc32xx lock CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 619594 619594 0 0.0
(read/write) 206900 206900 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 200344 200344 0 0.0
.comment 206 206 0 0.0
.data 1436 1436 0 0.0
.debug_abbrev 933165 933165 0 0.0
.debug_aranges 107520 107520 0 0.0
.debug_frame 363440 363440 0 0.0
.debug_info 20869490 20869490 0 0.0
.debug_line 2772754 2772754 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1573884 1573884 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 101446 101446 0 0.0
.debug_str 3387225 3387225 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 106290 106290 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 511191 511191 0 0.0
.symtab 296976 296976 0 0.0
.text 511184 511184 0 0.0
k32w contact k32w0+release (read only) 590684 590684 0 0.0
(read/write) 87508 87508 0 0.0
.bss 70760 70760 0 0.0
.data 2124 2124 0 0.0
.text 590148 590148 0 0.0
light k32w0+release (read only) 590476 590476 0 0.0
(read/write) 87184 87184 0 0.0
.bss 70448 70448 0 0.0
.data 2112 2112 0 0.0
.text 589940 589940 0 0.0
lock k32w0+release (read only) 561748 561748 0 0.0
(read/write) 85016 85016 0 0.0
.bss 68336 68336 0 0.0
.data 2056 2056 0 0.0
.text 561212 561212 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2523792 2523792 0 0.0
.bss 219064 219064 0 0.0
.data 5128 5128 0 0.0
.text 1486476 1486476 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1234128 1234128 0 0.0
bss 155134 155134 0 0.0
rodata 142740 142740 0 0.0
text 857312 857312 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1352884 1352884 0 0.0
bss 140544 140544 0 0.0
rodata 136848 136848 0 0.0
text 784816 784816 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1165364 1165364 0 0.0
bss 154564 154564 0 0.0
rodata 113768 113768 0 0.0
text 818076 818076 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1178568 1178568 0 0.0
.bss 100616 100616 0 0.0
.data 740 740 0 0.0
.text 625408 625408 0 0.0
lock-app qpg6105+debug (read/write) 1134792 1134792 0 0.0
.bss 95320 95320 0 0.0
.data 744 744 0 0.0
.text 581636 581636 0 0.0

@andy31415 andy31415 added the skip-protocol-compatibility Marker that protocol backwards compatibility checks are to be skipped label Sep 29, 2023
@andy31415
Copy link
Contributor Author

Skipt compatibility checks: matter IDL loading will not be compatible due to top level structs.

@github-actions
Copy link

github-actions bot commented Sep 29, 2023 •
edited
Loading

PR #29511: Size comparison from 4a9dab1 to ba11c93

Decreases (1 build for telink)
platform target config section 4a9dab1 ba11c93 change % change
telink lock-app tlsr9528a text 653220 653218 -2 -0.0
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 4a9dab1 ba11c93 change % change
bl602 lighting-app bl602 (read/write) 1391130 1391130 0 0.0
.bss 88176 88176 0 0.0
.data 9368 9368 0 0.0
.text 1067336 1067336 0 0.0
bl602+mfd (read/write) 1405026 1405026 0 0.0
.bss 88344 88344 0 0.0
.data 9344 9344 0 0.0
.text 1082122 1082122 0 0.0
bl602+rpc (read/write) 1438302 1438302 0 0.0
.bss 96200 96200 0 0.0
.data 9728 9728 0 0.0
.text 1099072 1099072 0 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1194679 1194679 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 30893 30893 0 0.0
.bss_psram 65744 65744 0 0.0
.comment 48 48 0 0.0
.data 3568 3568 0 0.0
.debug_abbrev 1544826 1544826 0 0.0
.debug_aranges 138416 138416 0 0.0
.debug_frame 508192 508192 0 0.0
.debug_info 41913458 41913458 0 0.0
.debug_line 5427412 5427412 0 0.0
.debug_loc 3524849 3524849 0 0.0
.debug_ranges 377128 377128 0 0.0
.debug_str 3966229 3966229 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.ocram_bss 8416 8416 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106804 106804 0 0.0
.rsvd 4 4 0 0.0
.shstrtab 297 297 0 0.0
.stack 2048 2048 0 0.0
.strtab 596916 596916 0 0.0
.symtab 177280 177280 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
961620 961620 0 0.0
bl702+mfd (read only) 3358 3358 0 0.0
(read/write) 1205239 1205239 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 31069 31069 0 0.0
.bss_psram 65744 65744 0 0.0
.comment 48 48 0 0.0
.data 3544 3544 0 0.0
.debug_abbrev 1546899 1546899 0 0.0
.debug_aranges 139584 139584 0 0.0
.debug_frame 513264 513264 0 0.0
.debug_info 41954076 41954076 0 0.0
.debug_line 5466799 5466799 0 0.0
.debug_loc 3563280 3563280 0 0.0
.debug_ranges 379128 379128 0 0.0
.debug_str 3971760 3971760 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.ocram_bss 8416 8416 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 105744 105744 0 0.0
.rsvd 4 4 0 0.0
.shstrtab 297 297 0 0.0
.stack 2048 2048 0 0.0
.strtab 600676 600676 0 0.0
.symtab 179040 179040 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
973118 973118 0 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1293231 1293231 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 39357 39357 0 0.0
.bss_psram 65728 65728 0 0.0
.comment 48 48 0 0.0
.data 4088 4088 0 0.0
.debug_abbrev 1725720 1725720 0 0.0
.debug_aranges 147136 147136 0 0.0
.debug_frame 537536 537536 0 0.0
.debug_info 47063730 47063730 0 0.0
.debug_line 5845496 5845496 0 0.0
.debug_loc 3731834 3731834 0 0.0
.debug_ranges 404680 404680 0 0.0
.debug_str 4394298 4394298 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.ocram_bss 8416 8416 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121868 121868 0 0.0
.rsvd 4 4 0 0.0
.shstrtab 297 297 0 0.0
.stack 2048 2048 0 0.0
.strtab 661657 661657 0 0.0
.symtab 196608 196608 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1035610 1035610 0 0.0
bl706-eth (read/write) 1043759 1043759 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 30006 30006 0 0.0
.bss_psram 97687 97687 0 0.0
.comment 48 48 0 0.0
.data 3248 3248 0 0.0
.debug_abbrev 1080991 1080991 0 0.0
.debug_aranges 115424 115424 0 0.0
.debug_frame 427592 427592 0 0.0
.debug_info 22668064 22668064 0 0.0
.debug_line 4360231 4360231 0 0.0
.debug_loc 3033778 3033778 0 0.0
.debug_ranges 312936 312936 0 0.0
.debug_str 3545448 3545448 0 0.0
.hbn 184 184 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 152 152 0 0.0
.ocram_bss 8416 8416 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 96504 96504 0 0.0
.rsvd 4 4 0 0.0
.shstrtab 297 297 0 0.0
.stack 2048 2048 0 0.0
.strtab 465211 465211 0 0.0
.symtab 139968 139968 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3338 3338 0 0.0
.text 0 0 0 0.0
787626 787626 0 0.0
bl706-wifi (read only) 3870 3870 0 0.0
(read/write) 1207406 1207406 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 14597 14597 0 0.0
.bss_psram 98455 98455 0 0.0
.comment 48 48 0 0.0
.data 3560 3560 0 0.0
.debug_abbrev 1173667 1173667 0 0.0
.debug_aranges 119600 119600 0 0.0
.debug_frame 620168 620168 0 0.0
.debug_info 23835741 23835741 0 0.0
.debug_line 4603997 4603997 0 0.0
.debug_loc 3133649 3133649 0 0.0
.debug_ranges 322752 322752 0 0.0
.debug_str 3617739 3617739 0 0.0
.hbn 468 468 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.ocram_bss 8416 8416 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 109632 109632 0 0.0
.rsvd 4 4 0 0.0
.shstrtab 297 297 0 0.0
.stack 2048 2048 0 0.0
.strtab 505938 505938 0 0.0
.symtab 152832 152832 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3870 3870 0 0.0
.text 0 0 0 0.0
954678 954678 0 0.0
bl702l lighting-app bl702l (read only) 278 278 0 0.0
(read/write) 1157824 1157824 0 0.0
.boot2 292 292 0 0.0
.bss 20368 20368 0 0.0
.bss_psram 77184 77184 0 0.0
.comment 48 48 0 0.0
.data 4512 4512 0 0.0
.debug_abbrev 1539114 1539114 0 0.0
.debug_aranges 133280 133280 0 0.0
.debug_frame 488832 488832 0 0.0
.debug_info 41371455 41371455 0 0.0
.debug_line 5330536 5330536 0 0.0
.debug_loc 3469106 3469106 0 0.0
.debug_ranges 383664 383664 0 0.0
.debug_str 3990824 3990824 0 0.0
.hbn 3244 3244 0 0.0
.hbn_noinit 308 308 0 0.0
.init 408 408 0 0.0
.init_array 144 144 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 100784 100784 0 0.0
.romdata 3224 3224 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 286 286 0 0.0
.stack 2048 2048 0 0.0
.strtab 598542 598542 0 0.0
.symtab 176720 176720 0 0.0
.tcm_data 692 692 0 0.0
.tcmcode 278 278 0 0.0
.text 0 0 0 0.0
944434 944434 0 0.0
bl702l+mfd (read only) 278 278 0 0.0
(read/write) 1168680 1168680 0 0.0
.boot2 292 292 0 0.0
.bss 20544 20544 0 0.0
.bss_psram 77184 77184 0 0.0
.comment 48 48 0 0.0
.data 4488 4488 0 0.0
.debug_abbrev 1541202 1541202 0 0.0
.debug_aranges 134448 134448 0 0.0
.debug_frame 493900 493900 0 0.0
.debug_info 41414116 41414116 0 0.0
.debug_line 5369800 5369800 0 0.0
.debug_loc 3507537 3507537 0 0.0
.debug_ranges 385664 385664 0 0.0
.debug_str 3996345 3996345 0 0.0
.hbn 3244 3244 0 0.0
.hbn_noinit 308 308 0 0.0
.init 408 408 0 0.0
.init_array 144 144 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 99724 99724 0 0.0
.romdata 3224 3224 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 286 286 0 0.0
.stack 2048 2048 0 0.0
.strtab 602370 602370 0 0.0
.symtab 178512 178512 0 0.0
.tcm_data 692 692 0 0.0
.tcmcode 278 278 0 0.0
.text 0 0 0 0.0
956198 956198 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 738219 738219 0 0.0
(read/write) 166444 166444 0 0.0
.bss 88860 88860 0 0.0
.data 3420 3420 0 0.0
.rodata 84383 84383 0 0.0
.text 653444 653444 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 758507 758507 0 0.0
(read/write) 176700 176700 0 0.0
.bss 99084 99084 0 0.0
.data 3436 3436 0 0.0
.rodata 80087 80087 0 0.0
.text 678032 678032 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 746003 746003 0 0.0
(read/write) 171172 171172 0 0.0
.bss 93556 93556 0 0.0
.data 3436 3436 0 0.0
.rodata 106111 106111 0 0.0
.text 639504 639504 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 696403 696403 0 0.0
(read/write) 165536 165536 0 0.0
.bss 87728 87728 0 0.0
.data 3408 3408 0 0.0
.rodata 80271 80271 0 0.0
.text 615740 615740 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 681995 681995 0 0.0
(read/write) 165676 165676 0 0.0
.bss 87872 87872 0 0.0
.data 3404 3404 0 0.0
.rodata 76111 76111 0 0.0
.text 605492 605492 0 0.0
cc32xx lock CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 619594 619594 0 0.0
(read/write) 206900 206900 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 200344 200344 0 0.0
.comment 206 206 0 0.0
.data 1436 1436 0 0.0
.debug_abbrev 933165 933165 0 0.0
.debug_aranges 107520 107520 0 0.0
.debug_frame 363440 363440 0 0.0
.debug_info 20869490 20869490 0 0.0
.debug_line 2772754 2772754 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1573884 1573884 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 101446 101446 0 0.0
.debug_str 3387225 3387225 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 106290 106290 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 511191 511191 0 0.0
.symtab 296976 296976 0 0.0
.text 511184 511184 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 555423 555423 0 0.0
.app_xip_area 446625 446625 0 0.0
.bss 63768 63768 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 540311 540311 0 0.0
.app_xip_area 426721 426721 0 0.0
.bss 68536 68536 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 575463 575463 0 0.0
.app_xip_area 467993 467993 0 0.0
.bss 62512 62512 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 552103 552103 0 0.0
.app_xip_area 441537 441537 0 0.0
.bss 65512 65512 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1008972 1008972 0 0.0
.bss 170804 170804 0 0.0
.data 2668 2668 0 0.0
.text 835476 835476 0 0.0
BRD4187C (read/write) 1090820 1090820 0 0.0
.bss 194912 194912 0 0.0
.data 3256 3256 0 0.0
.text 892632 892632 0 0.0
lock-app BRD4161A+wf200 (read/write) 1104224 1104224 0 0.0
.bss 185492 185492 0 0.0
.data 2680 2680 0 0.0
.text 916032 916032 0 0.0
window-app BRD4187C (read/write) 1124656 1124656 0 0.0
.bss 167352 167352 0 0.0
.data 3128 3128 0 0.0
.text 954156 954156 0 0.0
esp32 all-clusters-app c3devkit (read only) 1167494 1167494 0 0.0
(read/write) 1701860 1701860 0 0.0
.dram0.bss 77640 77640 0 0.0
.dram0.data 13060 13060 0 0.0
.flash.rodata 268432 268432 0 0.0
.flash.text 1167494 1167494 0 0.0
.iram0.text 75244 75244 0 0.0
m5stack (read only) 1209279 1209279 0 0.0
(read/write) 551794 551794 0 0.0
.dram0.bss 84288 84288 0 0.0
.dram0.data 34020 34020 0 0.0
.flash.rodata 299868 299868 0 0.0
.flash.text 1203895 1203895 0 0.0
.iram0.text 123287 123287 0 0.0
k32w contact k32w0+release (read only) 590684 590684 0 0.0
(read/write) 87508 87508 0 0.0
.bss 70760 70760 0 0.0
.data 2124 2124 0 0.0
.text 590148 590148 0 0.0
light k32w0+release (read only) 590476 590476 0 0.0
(read/write) 87184 87184 0 0.0
.bss 70448 70448 0 0.0
.data 2112 2112 0 0.0
.text 589940 589940 0 0.0
lock k32w0+release (read only) 561748 561748 0 0.0
(read/write) 85016 85016 0 0.0
.bss 68336 68336 0 0.0
.data 2056 2056 0 0.0
.text 561212 561212 0 0.0
linux all-clusters-app debug (read only) 5577033 5577033 0 0.0
(read/write) 420584 420584 0 0.0
.bss 130480 130480 0 0.0
.data 3856 3856 0 0.0
.data.rel.ro 278880 278880 0 0.0
.dynamic 624 624 0 0.0
.got 5384 5384 0 0.0
.init 27 27 0 0.0
.init_array 1328 1328 0 0.0
.rodata 336108 336108 0 0.0
.text 4860083 4860083 0 0.0
all-clusters-minimal-app debug (read only) 4929289 4929289 0 0.0
(read/write) 232688 232688 0 0.0
.bss 126512 126512 0 0.0
.data 3760 3760 0 0.0
.data.rel.ro 95280 95280 0 0.0
.dynamic 624 624 0 0.0
.got 5344 5344 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 270653 270653 0 0.0
.text 4427523 4427523 0 0.0
bridge-app debug (read only) 2773001 2773001 0 0.0
(read/write) 133168 133168 0 0.0
.bss 51736 51736 0 0.0
.data 3680 3680 0 0.0
.data.rel.ro 71648 71648 0 0.0
.dynamic 624 624 0 0.0
.got 4640 4640 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 213312 213312 0 0.0
.text 2381923 2381923 0 0.0
chip-tool debug (read only) 10353649 10353649 0 0.0
(read/write) 443064 443064 0 0.0
.bss 93688 93688 0 0.0
.data 4994 4994 0 0.0
.data.rel.ro 337136 337136 0 0.0
.dynamic 624 624 0 0.0
.got 5808 5808 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 387209 387209 0 0.0
.text 9369395 9369395 0 0.0
chip-tool-ipv6only arm64 (read only) 10217548 10217548 0 0.0
(read/write) 505512 505512 0 0.0
.bss 103032 103032 0 0.0
.data 4288 4288 0 0.0
.data.rel.ro 374376 374376 0 0.0
.dynamic 512 512 0 0.0
.got 18368 18368 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 316040 316040 0 0.0
.text 9135256 9135256 0 0.0
lighting-app debug+rpc+ui (read only) 5255217 5255217 0 0.0
(read/write) 222792 222792 0 0.0
.bss 118160 118160 0 0.0
.data 4416 4416 0 0.0
.data.rel.ro 92640 92640 0 0.0
.dynamic 672 672 0 0.0
.got 5928 5928 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 336436 336436 0 0.0
.text 4675987 4675987 0 0.0
lock-app debug (read only) 4479025 4479025 0 0.0
(read/write) 203128 203128 0 0.0
.bss 113424 113424 0 0.0
.data 3648 3648 0 0.0
.data.rel.ro 79288 79288 0 0.0
.dynamic 624 624 0 0.0
.got 5264 5264 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 246941 246941 0 0.0
.text 4022467 4022467 0 0.0
ota-provider-app debug (read only) 4130945 4130945 0 0.0
(read/write) 192064 192064 0 0.0
.bss 113568 113568 0 0.0
.data 3920 3920 0 0.0
.data.rel.ro 68656 68656 0 0.0
.dynamic 624 624 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 200093 200093 0 0.0
.text 3740291 3740291 0 0.0
ota-requestor-app debug (read only) 4224105 4224105 0 0.0
(read/write) 196280 196280 0 0.0
.bss 114592 114592 0 0.0
.data 4160 4160 0 0.0
.data.rel.ro 71632 71632 0 0.0
.dynamic 624 624 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 203357 203357 0 0.0
.text 3825859 3825859 0 0.0
shell debug (read only) 2973377 2973377 0 0.0
(read/write) 153248 153248 0 0.0
.bss 61000 61000 0 0.0
.data 784 784 0 0.0
.data.rel.ro 85544 85544 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 211808 211808 0 0.0
.text 2588130 2588130 0 0.0
thermostat-no-ble arm64 (read only) 4366908 4366908 0 0.0
(read/write) 241992 241992 0 0.0
.bss 122168 122168 0 0.0
.data 2792 2792 0 0.0
.data.rel.ro 100672 100672 0 0.0
.dynamic 512 512 0 0.0
.got 11896 11896 0 0.0
.init 24 24 0 0.0
.init_array 424 424 0 0.0
.rodata 161052 161052 0 0.0
.text 3871080 3871080 0 0.0
tv-app debug (read only) 5322449 5322449 0 0.0
(read/write) 350696 350696 0 0.0
.bss 241888 241888 0 0.0
.data 5024 5024 0 0.0
.data.rel.ro 96384 96384 0 0.0
.dynamic 624 624 0 0.0
.got 5608 5608 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 271245 271245 0 0.0
.text 4807123 4807123 0 0.0
tv-casting-app debug (read only) 8300481 8300481 0 0.0
(read/write) 211720 211720 0 0.0
.bss 54752 54752 0 0.0
.data 2464 2464 0 0.0
.data.rel.ro 147696 147696 0 0.0
.dynamic 624 624 0 0.0
.got 5080 5080 0 0.0
.init 27 27 0 0.0
.init_array 1088 1088 0 0.0
.rodata 337240 337240 0 0.0
.text 7561747 7561747 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2523792 2523792 0 0.0
.bss 219064 219064 0 0.0
.data 5128 5128 0 0.0
.text 1486476 1486476 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1234128 1234128 0 0.0
bss 155134 155134 0 0.0
rodata 142740 142740 0 0.0
text 857312 857312 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1352884 1352884 0 0.0
bss 140544 140544 0 0.0
rodata 136848 136848 0 0.0
text 784816 784816 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1165364 1165364 0 0.0
bss 154564 154564 0 0.0
rodata 113768 113768 0 0.0
text 818076 818076 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 837512 837512 0 0.0
(read/write) 1785804 1785804 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 193300 193300 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2528 2528 0 0.0
.debug_abbrev 1376188 1376188 0 0.0
.debug_aranges 144224 144224 0 0.0
.debug_frame 479224 479224 0 0.0
.debug_info 32451243 32451243 0 0.0
.debug_line 4153900 4153900 0 0.0
.debug_line_str 957 957 0 0.0
.debug_loclists 2256613 2256613 0 0.0
.debug_rnglists 145346 145346 0 0.0
.debug_str 4141046 4141046 0 0.0
.heap 837512 837512 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 837053 837053 0 0.0
.symtab 511888 511888 0 0.0
.text 1581588 1581588 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 840168 840168 0 0.0
(read/write) 1685692 1685692 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 190708 190708 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1257183 1257183 0 0.0
.debug_aranges 136024 136024 0 0.0
.debug_frame 457652 457652 0 0.0
.debug_info 28791678 28791678 0 0.0
.debug_line 3912986 3912986 0 0.0
.debug_line_str 981 981 0 0.0
.debug_loclists 2129998 2129998 0 0.0
.debug_rnglists 136913 136913 0 0.0
.debug_str 3942678 3942678 0 0.0
.heap 840168 840168 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 734809 734809 0 0.0
.symtab 472736 472736 0 0.0
.text 1484132 1484132 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 846496 846496 0 0.0
(read/write) 1611332 1611332 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184492 184492 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2352 2352 0 0.0
.debug_abbrev 1098155 1098155 0 0.0
.debug_aranges 126088 126088 0 0.0
.debug_frame 420584 420584 0 0.0
.debug_info 23913004 23913004 0 0.0
.debug_line 3487864 3487864 0 0.0
.debug_line_str 942 942 0 0.0
.debug_loclists 1966722 1966722 0 0.0
.debug_rnglists 126465 126465 0 0.0
.debug_str 3749772 3749772 0 0.0
.heap 846496 846496 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 650001 650001 0 0.0
.symtab 434976 434976 0 0.0
.text 1416100 1416100 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 819232 819232 0 0.0
(read/write) 1642724 1642724 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 211740 211740 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2368 2368 0 0.0
.debug_abbrev 1090346 1090346 0 0.0
.debug_aranges 124720 124720 0 0.0
.debug_frame 415608 415608 0 0.0
.debug_info 23716351 23716351 0 0.0
.debug_line 3438514 3438514 0 0.0
.debug_line_str 933 933 0 0.0
.debug_loclists 1942287 1942287 0 0.0
.debug_rnglists 124406 124406 0 0.0
.debug_str 3711766 3711766 0 0.0
.heap 819232 819232 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 622931 622931 0 0.0
.symtab 426144 426144 0 0.0
.text 1420228 1420228 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1178568 1178568 0 0.0
.bss 100616 100616 0 0.0
.data 740 740 0 0.0
.text 625408 625408 0 0.0
lock-app qpg6105+debug (read/write) 1134792 1134792 0 0.0
.bss 95320 95320 0 0.0
.data 744 744 0 0.0
.text 581636 581636 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1146724 1146724 0 0.0
bss 113244 113244 0 0.0
text 804322 804322 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1089344 1089344 0 0.0
bss 122264 122264 0 0.0
text 762452 762452 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 943012 943012 0 0.0
bss 106908 106908 0 0.0
text 656082 656082 0 0.0
contact-sensor-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 871336 871336 0 0.0
bss 78144 78144 0 0.0
text 623690 623690 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 861020 861020 0 0.0
bss 67056 67056 0 0.0
text 629790 629790 0 0.0
lighting-app-rpc-shell-factory-data tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 995872 995872 0 0.0
bss 109168 109168 0 0.0
text 705244 705244 0 0.0
tlsr9528a (read only) 4 4 0 0.0
(read/write) 1040300 1040300 0 0.0
bss 120916 120916 0 0.0
text 729756 729756 0 0.0
lock-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 927652 927652 0 0.0
bss 78836 78836 0 0.0
text 653220 653218 -2 -0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 956636 956636 0 0.0
bss 105008 105008 0 0.0
text 672146 672146 0 0.0
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 875060 875060 0 0.0
bss 78248 78248 0 0.0
text 627732 627732 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 817076 817076 0 0.0
bss 66260 66260 0 0.0
text 593550 593550 0 0.0
resource-monitoring-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 833024 833024 0 0.0
bss 66676 66676 0 0.0
text 604402 604402 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 737688 737688 0 0.0
bss 95176 95176 0 0.0
text 483358 483358 0 0.0
smoke_co_alarm-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 873312 873312 0 0.0
bss 78228 78228 0 0.0
text 626598 626598 0 0.0
temperature-measurement-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 858412 858412 0 0.0
bss 77948 77948 0 0.0
text 613856 613856 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 838596 838596 0 0.0
bss 66560 66560 0 0.0
text 609330 609330 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 835736 835736 0 0.0
bss 66912 66912 0 0.0
text 606056 606056 0 0.0

@mergify mergify bot merged commit 8cb1bda into project-chip:master Sep 29, 2023
53 checks passed
HunsupJung pushed a commit to HunsupJung/connectedhomeip that referenced this pull request Oct 23, 2023
@andy31415 @andreilitvin @HunsupJung
Remove top-level struct and enum support from IDL processing (project…
a250bfd 
…-chip#29511)

* Start removing enums and structs from top level definitions in the parser

* Remove top level structs from matter idl auto-generation

* Fix generator type logic

* Update test inputs to move global structs

* Fix unit tests

* Restyle

* Remove unused import

---------

Co-authored-by: Andrei Litvin <andreilitvin@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app controller examples review - approved scripts skip-protocol-compatibility Marker that protocol backwards compatibility checks are to be skipped
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andy31415 @yunhanw-google @bzbarsky-apple @Damian-Nordic @andreilitvin