-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the tracing macros using a backend for esp32. #29543
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shripad621git
commented
Oct 3, 2023
PR #29543: Size comparison from 1ec98c8 to 6504b3f Decreases (1 build for bl702l)
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Oct 3, 2023
andy31415
reviewed
Oct 3, 2023
andy31415
reviewed
Oct 3, 2023
src/tracing/esp32_trace/include/matter/tracing/esp32_tracing.cpp
Outdated
Show resolved
Hide resolved
PR #29543: Size comparison from 1ec98c8 to df54cf1 Full report (17 builds for cc13x4_26x4, cc32xx, k32w, linux, mbed, nrfconnect, qpg)
|
PR #29543: Size comparison from 1ec98c8 to b21c9c7 Increases (2 builds for k32w)
Decreases (2 builds for k32w)
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #29543: Size comparison from 1ec98c8 to d7fe031 Increases (2 builds for k32w)
Decreases (3 builds for k32w, telink)
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #29543: Size comparison from 1ec98c8 to 590213d Increases (27 builds for bl702, bl702l, cc32xx, k32w, linux, psoc6)
Decreases (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
- This PR is aimed at addressing the review comments on PR project-chip#29318. - This is a draft implementation of the backend.
…d examples, carry over configurations
…for authkey since that should not be checked in
shripad621git
force-pushed
the
tracing/backend
branch
from
October 5, 2023 05:14
590213d
to
0de6e48
Compare
PR #29543: Size comparison from 883f03e to 0de6e48 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq and
bzbarsky-apple
October 5, 2023 08:38
pullapprove
bot
requested review from
LuDuda,
mhazley,
mkardous-silabs,
mlepage-google,
mspang,
nivi-apple,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
October 5, 2023 08:38
andy31415
approved these changes
Oct 5, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…#29543) * Implement the tracing macros using a backend for esp32. - This PR is aimed at addressing the review comments on PR project-chip#29318. - This is a draft implementation of the backend. * Move esp32 tracing configs around: better location, integrate in build examples, carry over configurations * More options removals * Remove fixme text * Restrict tracing to light app, fix include paths in main, add ignore for authkey since that should not be checked in * Move dependencies around even more - esp32 now seems to compile with tracing enabled * Ensure tracing is actually enabled when insights is on * Restyle * Made esp32_trace backend in sync with existing version * Made the common include on the tracing config for all esp32 examples * Fixed the CI failure --------- Co-authored-by: Andrei Litvin <andy314@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview