[ICD-server] Replace the event/queue based logic with a notifier #29546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
examples
platform
app
tests
icd
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel and
ksperling-apple
andy31415
reviewed
Oct 5, 2023
andy31415
reviewed
Oct 5, 2023
andy31415
reviewed
Oct 5, 2023
andy31415
reviewed
Oct 5, 2023
|
PR #29546: Size comparison from f03e9ef to 405e757 Increases (12 builds for psoc6, telink)
Decreases (37 builds for bl602, bl702, bl702l, cc32xx, efr32, linux, psoc6, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Oct 5, 2023
andy31415
reviewed
Oct 5, 2023
andy31415
reviewed
Oct 5, 2023
andy31415
reviewed
Oct 5, 2023
|
PR #29546: Size comparison from f03e9ef to bf67b01 Increases above 0.2%:
Increases (3 builds for cc32xx, qpg)
Decreases (1 build for cc32xx)
Full report (4 builds for cc32xx, mbed, qpg)
|
jmartinez-silabs
force-pushed
the
improve_icd_events
branch
from
bf67b01 to
a83360c
Compare
|
PR #29546: Size comparison from 43981ac to 0f212f7 Increases above 0.2%:
Increases (51 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, psoc6, qpg, telink)
Decreases (36 builds for bl702, bl702l, cc32xx, efr32, linux, psoc6, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Oct 9, 2023
…(Subject/observer pattern). Tweak some ICDManager logic to accound for SIT with active interval and active threshold of 0 ms
…g the chip stack lock. We will assert if we don't have it (caller responsability). Add briefs and comments. move ICDNotifier implementation to a cpp file
jmartinez-silabs
force-pushed
the
improve_icd_events
branch
from
36743b3 to
aa1dffb
Compare
|
PR #29546: Size comparison from b846dbe to aa1dffb Increases above 0.2%:
Increases (48 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, psoc6, qpg)
Decreases (25 builds for bl702, bl702l, cc32xx, efr32, linux, psoc6)
Full report (54 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…ject-chip#29546) * Replace ICDEventManager and its event queue logic by the ICDNotifier (Subject/observer pattern). Tweak some ICDManager logic to accound for SIT with active interval and active threshold of 0 ms * Use a pointer array instead of vector for the notifier subscribers * Restyled by clang-format * Restyled by gn * Gate the check for chiplock with CHIP_STACK_LOCK_TRACKING_ENABLED * Rename a class,functions of the ICDNotifier for clarity. Remove taking the chip stack lock. We will assert if we don't have it (caller responsability). Add briefs and comments. move ICDNotifier implementation to a cpp file * Restyled by whitespace * Fix returned error for ICDNotifier subscribe * Rename ICDSubscriber class to ICDListener, Update comment with Boris's suggestion --------- Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #29450