-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increment used TCPEndPoint count during incoming connection. #29553
Merged
mergify
merged 2 commits into
project-chip:master
from
pidarped:bug/EchoResponderMultipleConn
Oct 5, 2023
Merged
Increment used TCPEndPoint count during incoming connection. #29553
mergify
merged 2 commits into
project-chip:master
from
pidarped:bug/EchoResponderMultipleConn
Oct 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
October 3, 2023 21:57
pullapprove
bot
requested review from
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
October 3, 2023 21:57
PR #29553: Size comparison from a5ea091 to 752918f Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yufengwangca
approved these changes
Oct 3, 2023
Due to this issue, subsequent incoming connections were failing to connect as the value was getting decremented from zero resulting in a check failing. Also, remove duplicate code for freeing an active connection and move it into a separate function.
pidarped
force-pushed
the
bug/EchoResponderMultipleConn
branch
from
October 4, 2023 17:35
752918f
to
b88ddd0
Compare
PR #29553: Size comparison from 73c327e to b88ddd0 Increases (1 build for telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Oct 5, 2023
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
PR #29553: Size comparison from 73c327e to 51aed44 Increases above 0.2%:
Increases (17 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, linux, nrfconnect, psoc6)
Decreases (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…-chip#29553) * Increment used endpoint count during incoming connection. Due to this issue, subsequent incoming connections were failing to connect as the value was getting decremented from zero resulting in a check failing. Also, remove duplicate code for freeing an active connection and move it into a separate function. * Update src/transport/raw/TCP.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> --------- Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to this issue, subsequent incoming connections were failing to connect as the value was getting decremented from zero resulting in a check failing.
Also, remove duplicate code for freeing an active connection and move it into a separate function.