-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move kotlin lib onboardingpayload to package matter #29623
Merged
mergify
merged 2 commits into
project-chip:master
from
yufengwangca:pr/kotlin/onboardingpayload
Oct 16, 2023
Merged
Move kotlin lib onboardingpayload to package matter #29623
mergify
merged 2 commits into
project-chip:master
from
yufengwangca:pr/kotlin/onboardingpayload
Oct 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
October 6, 2023 14:44
pullapprove
bot
requested review from
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
October 6, 2023 14:44
PR #29623: Size comparison from cff70e1 to c08b39e Full report (14 builds for cc32xx, k32w, linux, mbed, nrfconnect, qpg)
|
PR #29623: Size comparison from cff70e1 to b444a39 Full report (12 builds for cc13x4_26x4, cc32xx, mbed, nrfconnect, qpg)
|
PR #29623: Size comparison from c73199d to 5c0b33b Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Holding land this PR after all affected companies are fully aware of this change. |
swan-amazon
approved these changes
Oct 13, 2023
joonhaengHeo
approved these changes
Oct 15, 2023
chulspro
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* Move kotlin lib onboardingpayload to package matter * Restyled by google-java-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plan is to consolidate all kotlin libraries into package matter to integrate seamlessly with existing Kotlin libraries to create a complete suite of Kotlin APIs.
This is a mechanical package name adjustment with no changes to the underlying logic.