Break dependency cycle between CHIPMem and logging. #29685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHIPMem used things from CodeUtils.h which used logging, but logging might need to allocate memory via Memory::Alloc to actually work. This breaks the cycle (both conceptual and real: we could try to Memory::Alloc to log the fact that Memory::Init had not been called!), by making CHIPMem not use any macros that involve logging, at the cost of not having nice error messages when CHIPMem invariants are violated.
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mhazley
pullapprove
bot
requested review from
nivi-apple,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
andy31415
approved these changes
Oct 10, 2023
|
PR #29685: Size comparison from 3751574 to f0117d5 Increases above 0.2%:
Increases (13 builds for bl702, bl702l, cc32xx, efr32, esp32, k32w, linux, mbed)
Decreases (62 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
CHIPMem used things from CodeUtils.h which used logging, but logging might need to allocate memory via Memory::Alloc to actually work. This breaks the cycle (both conceptual and real: we could try to Memory::Alloc to log the fact that Memory::Init had not been called!), by making CHIPMem not use any macros that involve logging, at the cost of not having nice error messages when CHIPMem invariants are violated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHIPMem used things from CodeUtils.h which used logging, but logging might need to allocate memory via Memory::Alloc to actually work.
This breaks the cycle (both conceptual and real: we could try to Memory::Alloc to log the fact that Memory::Init had not been called!), by making CHIPMem not use any macros that involve logging, at the cost of not having nice error messages when CHIPMem invariants are violated.