-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ICD] Remove PSA Crypto exclusion from Unit test #29753
Merged
mergify
merged 6 commits into
project-chip:master
from
jepenven-silabs:icd_fix_monitoring_table_unit_test
Oct 21, 2023
Merged
[ICD] Remove PSA Crypto exclusion from Unit test #29753
mergify
merged 6 commits into
project-chip:master
from
jepenven-silabs:icd_fix_monitoring_table_unit_test
Oct 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
October 13, 2023 14:25
PR #29753: Size comparison from cdcbd8c to b0bd539 Increases (5 builds for cc32xx, nrfconnect, psoc6)
Decreases (7 builds for cc13x4_26x4, cc32xx, cyw30739, mbed, psoc6)
Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
bzbarsky-apple
requested changes
Oct 17, 2023
PR #29753: Size comparison from cdcbd8c to d62ea00 Increases (10 builds for cc32xx, esp32, linux, nrfconnect, psoc6)
Decreases (7 builds for cc13x4_26x4, cc32xx, cyw30739, mbed, psoc6)
Full report (39 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #29753: Size comparison from cdcbd8c to 44208e3 Increases (22 builds for cc32xx, esp32, linux, nrfconnect, psoc6, telink)
Decreases (13 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, linux, mbed, psoc6, telink)
Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #29753: Size comparison from cdcbd8c to cd486b0 Increases (26 builds for bl702, cc32xx, esp32, linux, nrfconnect, psoc6, telink)
Decreases (21 builds for bl702, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, mbed, psoc6, telink)
Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jepenven-silabs
force-pushed
the
icd_fix_monitoring_table_unit_test
branch
from
October 18, 2023 12:36
cd486b0
to
c4a3ce1
Compare
PR #29753: Size comparison from 6b64a80 to c4a3ce1 Increases (1 build for cc32xx)
Decreases (2 builds for cc32xx, mbed)
Full report (4 builds for cc32xx, mbed, qpg)
|
jepenven-silabs
force-pushed
the
icd_fix_monitoring_table_unit_test
branch
from
October 18, 2023 13:10
c4a3ce1
to
3144943
Compare
PR #29753: Size comparison from 6b64a80 to 3144943 Increases (11 builds for cc32xx, esp32, linux, nrfconnect, psoc6, telink)
Decreases (12 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, linux, mbed, psoc6, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Oct 21, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* Remove PSA Crypto exclusion * fix PSA test failure * Add more comments * Fix comments * Add isKeySet flag * address comments
shripad621git
pushed a commit
to shripad621git/connectedhomeip
that referenced
this pull request
Oct 31, 2023
* Remove PSA Crypto exclusion * fix PSA test failure * Add more comments * Fix comments * Add isKeySet flag * address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR to remove the
#if !CHIP_CRYPTO_PSA
and use the standard API instead.