-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove media clusters from all-clusters-app #29801
Merged
mergify
merged 2 commits into
project-chip:master
from
cecille:remove_media_clusters_in_all_clusters
Oct 17, 2023
Merged
Remove media clusters from all-clusters-app #29801
mergify
merged 2 commits into
project-chip:master
from
cecille:remove_media_clusters_in_all_clusters
Oct 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both QA and the CI are using the TV app for all testing of the media clusters. The all-clusters versions are not well tested and have conformance issues. Removing these in all-clusters in favour of the TV app.
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
October 16, 2023 21:09
pullapprove
bot
requested review from
woody-apple,
robszewczyk,
younghak-hwang,
saurabhst,
yufengwangca,
selissia,
yunhanw-google,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
vivien-apple and
wiba-nordic
October 16, 2023 21:09
PR #29801: Size comparison from f0069d2 to 6c37831 Decreases (2 builds for nrfconnect)
Full report (14 builds for cc32xx, k32w, linux, mbed, nrfconnect, qpg)
|
p0fi
approved these changes
Oct 16, 2023
PR #29801: Size comparison from f0069d2 to e53d46d Increases (17 builds for bl702, bl702l, cc13x4_26x4, cyw30739, k32w, psoc6, qpg)
Decreases (27 builds for bl702, bl702l, cc13x4_26x4, cyw30739, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Oct 17, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* Remove media clusters from all-clusters-app Both QA and the CI are using the TV app for all testing of the media clusters. The all-clusters versions are not well tested and have conformance issues. Removing these in all-clusters in favour of the TV app. * Remove media servers from esp32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both QA and the CI are using the TV app for all testing of the media clusters. The all-clusters versions are not well tested and have conformance issues. Removing these in all-clusters in favour of the TV app.
Fixes: #29771