-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs] Modified cluster-revsion default value #29807
Merged
mergify
merged 1 commit into
project-chip:master
from
kiran0284:bugfix/cluster_revision_value_fix
Oct 17, 2023
Merged
[Silabs] Modified cluster-revsion default value #29807
mergify
merged 1 commit into
project-chip:master
from
kiran0284:bugfix/cluster_revision_value_fix
Oct 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
October 17, 2023 04:12
pullapprove
bot
requested review from
younghak-hwang,
pidarped,
yufengwangca,
plauric,
yunhanw-google,
rcasallas-silabs,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic and
woody-apple
October 17, 2023 04:12
PR #29807: Size comparison from 73b400d to 0de4bbd Decreases (2 builds for esp32, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Oct 17, 2023
This is not a Silabs specific PR. I suggest removing the |
bzbarsky-apple
approved these changes
Oct 17, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defaultvalue is 1 in thermostat.zap file for cluster-revision attribute in THERMOSTAT_USER_INTERFACE_CONFIGURATION_CLUSTER, In the Test Case(TSUIC_1.1) test plan expected cluster revision value should be 2. So , by modifying the defaultValue in THERMOSTAT_USER_INTERFACE_CONFIGURATION_CLUSTER for server side it is giving 2 as cluster-revision value.