-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix streamer_esp32.cpp for current esp-idf master branch #29814
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marciogranzotto
changed the title
Fix streamer_esp32.cpp for current esp-idf main branch
Fix streamer_esp32.cpp for current esp-idf master branch
Oct 17, 2023
PR #29814: Size comparison from b361a6b to a49402c Increases (2 builds for bl702, esp32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
@marciogranzotto Thanks for the contribution! Can you please sign the CLI, and check restyled here: https://restyled.io/gh/project-chip/repos/connectedhomeip/jobs/3668821 |
marciogranzotto
force-pushed
the
esp32/fix-uart-port
branch
from
October 19, 2023 17:33
a49402c
to
6a1e818
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs and
jmeg-sfy
October 19, 2023 17:34
pullapprove
bot
requested review from
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
October 19, 2023 17:34
@woody-apple done! |
PR #29814: Size comparison from b9d525e to 6a1e818 Increases (1 build for esp32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Oct 19, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…p#29814) * Fix streamer_esp32.cpp for current esp-idf main branch * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
shripad621git
pushed a commit
to shripad621git/connectedhomeip
that referenced
this pull request
Oct 31, 2023
…p#29814) * Fix streamer_esp32.cpp for current esp-idf main branch * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
Jerry-ESP
pushed a commit
to Jerry-ESP/connectedhomeip
that referenced
this pull request
Apr 11, 2024
…p#29814) * Fix streamer_esp32.cpp for current esp-idf main branch * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
andy31415
pushed a commit
that referenced
this pull request
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
Change overview
Add type casting for
usart_port_t
on esp-idf calls.Testing
How was this tested? (at least one bullet point required)
It was not compiling before. After this change, it compiles fine for ESP32-C6