-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs][WiFi] Added fix for commissioning failing with ecosystems #29825
Merged
mergify
merged 4 commits into
project-chip:master
from
shgutte:bugfix/echo_system_hardfault_917_ncp
Oct 17, 2023
Merged
[Silabs][WiFi] Added fix for commissioning failing with ecosystems #29825
mergify
merged 4 commits into
project-chip:master
from
shgutte:bugfix/echo_system_hardfault_917_ncp
Oct 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #29825: Size comparison from d140d5c to 9e9b2f2 Full report (3 builds for cc32xx, qpg)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
October 17, 2023 17:06
pullapprove
bot
requested review from
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
October 17, 2023 17:06
andy31415
approved these changes
Oct 17, 2023
PR #29825: Size comparison from d140d5c to 3477f85 Increases (1 build for bl602)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Oct 17, 2023
yufengwangca
approved these changes
Oct 17, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…roject-chip#29825) * Added fix for echo system * Added fic for echo system * Added restyle changes * Added changes for the restyle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem/Feature:
Commissioning is failing for all ecosystems ( Apple, Amazon (Alexa), Samsung ( Aeotec & Charging hub) ) except Google, due to hard fault
Description of Fix/Solution:
Background Wi-Fi scan getting called by apple and Amazon Echo so, it should not get called before connecting to AP.
Testing Done:
917 NCP