Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Media::ApplicationBasic cluster to match spec #29959

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Change Media::ApplicationBasic cluster to match spec #29959

merged 3 commits into from
Oct 25, 2023

Conversation

andy31415
Copy link
Contributor

Changes:

  • increase applicationName size (spec says The maximum length of the ApplicationName attribute is 256 bytes of UTF-8 characters.) ... which is actually somewhat we may not be able to fully enforce as I believe we allocate bytes not utf8-chars. But this is better than 32.
  • mark allowed vendor list to be accessible by admin only.

@andy31415 andy31415 added the skip-protocol-compatibility Marker that protocol backwards compatibility checks are to be skipped label Oct 24, 2023
@github-actions
Copy link

github-actions bot commented Oct 24, 2023 •
edited
Loading

PR #29959: Size comparison from 7879111 to d73f3e2

Increases (17 builds for bl702, bl702l, cc32xx, linux, nrfconnect, psoc6, telink)
platform target config section 7879111 d73f3e2 change % change
bl702 lighting-app bl702 .debug_info 41470738 41470744 6 0.0
.debug_line 5438971 5438994 23 0.0
.debug_loc 3654206 3654207 1 0.0
bl702+mfd .debug_info 41511737 41511743 6 0.0
.debug_line 5479326 5479349 23 0.0
.debug_loc 3692368 3692369 1 0.0
bl702+rpc .debug_info 46615051 46615057 6 0.0
.debug_line 5869379 5869402 23 0.0
.debug_loc 3861845 3861846 1 0.0
bl706-eth .debug_info 22393156 22393162 6 0.0
.debug_line 4130454 4130477 23 0.0
.debug_loc 3071805 3071806 1 0.0
bl706-wifi .debug_info 23776476 23776482 6 0.0
.debug_line 4555048 4555071 23 0.0
.debug_loc 3259006 3259007 1 0.0
bl702l lighting-app bl702l .debug_info 41288265 41288271 6 0.0
.debug_line 5367027 5367050 23 0.0
.debug_loc 3604759 3604760 1 0.0
bl702l+mfd .debug_info 41331307 41331313 6 0.0
.debug_line 5407259 5407282 23 0.0
.debug_loc 3642921 3642922 1 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL .debug_frame 351088 351096 8 0.0
.debug_info 19381898 19381937 39 0.0
.debug_loclists 1577831 1577841 10 0.0
lock CC3235SF_LAUNCHXL .debug_frame 366400 366408 8 0.0
.debug_info 20556258 20556297 39 0.0
.debug_loclists 1633661 1633671 10 0.0
linux all-clusters-minimal-app debug (read only) 4879649 4879681 32 0.0
(read/write) 232664 232888 224 0.1
.bss 126480 126704 224 0.2
.rodata 270141 270173 32 0.0
tv-app debug (read only) 5284689 5284721 32 0.0
(read/write) 351664 351888 224 0.1
.bss 242880 243104 224 0.1
.rodata 271021 271053 32 0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1160412 1160552 140 0.0
bss 153994 154219 225 0.1
rodata 113712 113724 12 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_frame 466984 466992 8 0.0
.debug_info 30188740 30188779 39 0.0
.debug_loclists 2244326 2244336 10 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1680932 1681164 232 0.0
.bss 190708 190932 224 0.1
.debug_frame 460372 460380 8 0.0
.debug_info 28465238 28465286 48 0.0
.debug_loclists 2188807 2188817 10 0.0
.text 1479364 1479372 8 0.0
light cy8ckit_062s2_43012 .debug_frame 423264 423272 8 0.0
.debug_info 23591973 23592012 39 0.0
.debug_loclists 2025154 2025164 10 0.0
lock cy8ckit_062s2_43012 .debug_frame 418532 418540 8 0.0
.debug_info 23402966 23403005 39 0.0
.debug_loclists 2002041 2002051 10 0.0
telink all-clusters-minimal-app tlsr9528a (read/write) 1076128 1076364 236 0.0
bss 122236 122460 224 0.2
Decreases (6 builds for cc32xx, psoc6)
platform target config section 7879111 d73f3e2 change % change
cc32xx air-purifier CC3235SF_LAUNCHXL .debug_line 2584885 2584883 -2 -0.0
.debug_rnglists 107563 107562 -1 -0.0
lock CC3235SF_LAUNCHXL .debug_line 2655212 2655210 -2 -0.0
.debug_rnglists 112112 112111 -1 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_line 3888455 3888453 -2 -0.0
.debug_rnglists 151676 151675 -1 -0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 840160 839936 -224 -0.0
.debug_line 3793955 3793953 -2 -0.0
.debug_rnglists 147491 147490 -1 -0.0
.heap 840160 839936 -224 -0.0
light cy8ckit_062s2_43012 .debug_line 3369083 3369081 -2 -0.0
.debug_rnglists 137025 137024 -1 -0.0
lock cy8ckit_062s2_43012 .debug_line 3321806 3321804 -2 -0.0
.debug_rnglists 135060 135059 -1 -0.0
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 7879111 d73f3e2 change % change
bl602 lighting-app bl602 (read/write) 1408590 1408590 0 0.0
.bss 88488 88488 0 0.0
.data 9360 9360 0 0.0
.text 1073778 1073778 0 0.0
bl602+mfd (read/write) 1423006 1423006 0 0.0
.bss 88656 88656 0 0.0
.data 9336 9336 0 0.0
.text 1089094 1089094 0 0.0
bl602+rpc (read/write) 1455858 1455858 0 0.0
.bss 96520 96520 0 0.0
.data 9736 9736 0 0.0
.text 1105518 1105518 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1206519 1206519 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 400 400 0 0.0
.bss 32597 32597 0 0.0
.bss_psram 66128 66128 0 0.0
.comment 48 48 0 0.0
.data 3568 3568 0 0.0
.debug_abbrev 1540054 1540054 0 0.0
.debug_aranges 138832 138832 0 0.0
.debug_frame 508612 508612 0 0.0
.debug_info 41470738 41470744 6 0.0
.debug_line 5438971 5438994 23 0.0
.debug_loc 3654206 3654207 1 0.0
.debug_ranges 444464 444464 0 0.0
.debug_str 4075514 4075514 0 0.0
.hbn 584 584 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 148 148 0 0.0
.ocram_bss 8416 8416 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106492 106492 0 0.0
.rsvd 4 4 0 0.0
.shstrtab 297 297 0 0.0
.stack 2048 2048 0 0.0
.strtab 598007 598007 0 0.0
.symtab 178608 178608 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3478 3478 0 0.0
.text 0 0 0 0.0
971376 971376 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1217631 1217631 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 400 400 0 0.0
.bss 32773 32773 0 0.0
.bss_psram 66128 66128 0 0.0
.comment 48 48 0 0.0
.data 3552 3552 0 0.0
.debug_abbrev 1542130 1542130 0 0.0
.debug_aranges 140000 140000 0 0.0
.debug_frame 514044 514044 0 0.0
.debug_info 41511737 41511743 6 0.0
.debug_line 5479326 5479349 23 0.0
.debug_loc 3692368 3692369 1 0.0
.debug_ranges 446704 446704 0 0.0
.debug_str 4081045 4081045 0 0.0
.hbn 584 584 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 148 148 0 0.0
.ocram_bss 8416 8416 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 105432 105432 0 0.0
.rsvd 4 4 0 0.0
.shstrtab 297 297 0 0.0
.stack 2048 2048 0 0.0
.strtab 601767 601767 0 0.0
.symtab 180368 180368 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3478 3478 0 0.0
.text 0 0 0 0.0
983404 983404 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1306787 1306787 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 400 400 0 0.0
.bss 41061 41061 0 0.0
.bss_psram 66112 66112 0 0.0
.comment 48 48 0 0.0
.data 4120 4120 0 0.0
.debug_abbrev 1721011 1721011 0 0.0
.debug_aranges 147448 147448 0 0.0
.debug_frame 537656 537656 0 0.0
.debug_info 46615051 46615057 6 0.0
.debug_line 5869379 5869402 23 0.0
.debug_loc 3861845 3861846 1 0.0
.debug_ranges 472032 472032 0 0.0
.debug_str 4503394 4503394 0 0.0
.hbn 584 584 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 164 164 0 0.0
.ocram_bss 8416 8416 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121392 121392 0 0.0
.rsvd 4 4 0 0.0
.shstrtab 297 297 0 0.0
.stack 2048 2048 0 0.0
.strtab 661964 661964 0 0.0
.symtab 197728 197728 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3478 3478 0 0.0
.text 0 0 0 0.0
1047184 1047184 0 0.0
bl706-eth (read/write) 993833 993833 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 400 400 0 0.0
.bss 27752 27752 0 0.0
.bss_psram 97975 97975 0 0.0
.comment 48 48 0 0.0
.data 3120 3120 0 0.0
.debug_abbrev 1059526 1059526 0 0.0
.debug_aranges 111664 111664 0 0.0
.debug_frame 412544 412544 0 0.0
.debug_info 22393156 22393162 6 0.0
.debug_line 4130454 4130477 23 0.0
.debug_loc 3071805 3071806 1 0.0
.debug_ranges 362880 362880 0 0.0
.debug_str 3618554 3618554 0 0.0
.hbn 184 184 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.ocram_bss 8416 8416 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 99120 99120 0 0.0
.rsvd 4 4 0 0.0
.shstrtab 297 297 0 0.0
.stack 2048 2048 0 0.0
.strtab 456455 456455 0 0.0
.symtab 133248 133248 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3458 3458 0 0.0
.text 0 0 0 0.0
736920 736920 0 0.0
bl706-wifi (read/write) 1228750 1228750 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 400 400 0 0.0
.bss 14637 14637 0 0.0
.bss_psram 98727 98727 0 0.0
.comment 48 48 0 0.0
.data 3552 3552 0 0.0
.debug_abbrev 1174300 1174300 0 0.0
.debug_aranges 119328 119328 0 0.0
.debug_frame 618112 618112 0 0.0
.debug_info 23776476 23776482 6 0.0
.debug_line 4555048 4555071 23 0.0
.debug_loc 3259006 3259007 1 0.0
.debug_ranges 390736 390736 0 0.0
.debug_str 3720086 3720086 0 0.0
.hbn 468 468 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.ocram_bss 8416 8416 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 119992 119992 0 0.0
.rsvd 4 4 0 0.0
.shstrtab 297 297 0 0.0
.stack 2048 2048 0 0.0
.strtab 505560 505560 0 0.0
.symtab 152544 152544 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3994 3994 0 0.0
.text 0 0 0 0.0
961094 961094 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1177320 1177320 0 0.0
.boot2 400 400 0 0.0
.bss 20576 20576 0 0.0
.bss_psram 79248 79248 0 0.0
.comment 48 48 0 0.0
.data 4936 4936 0 0.0
.debug_abbrev 1540396 1540396 0 0.0
.debug_aranges 134040 134040 0 0.0
.debug_frame 490568 490568 0 0.0
.debug_info 41288265 41288271 6 0.0
.debug_line 5367027 5367050 23 0.0
.debug_loc 3604759 3604760 1 0.0
.debug_ranges 452624 452624 0 0.0
.debug_str 4105288 4105288 0 0.0
.hbn 3220 3220 0 0.0
.hbn_noinit 308 308 0 0.0
.init 408 408 0 0.0
.init_array 148 148 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 100648 100648 0 0.0
.romdata 3224 3224 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 601537 601537 0 0.0
.symtab 179232 179232 0 0.0
.tcm_data 692 692 0 0.0
.tcmcode 512 512 0 0.0
.text 0 0 0 0.0
961284 961284 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1188788 1188788 0 0.0
.boot2 400 400 0 0.0
.bss 20752 20752 0 0.0
.bss_psram 79248 79248 0 0.0
.comment 48 48 0 0.0
.data 4912 4912 0 0.0
.debug_abbrev 1542487 1542487 0 0.0
.debug_aranges 135208 135208 0 0.0
.debug_frame 495996 495996 0 0.0
.debug_info 41331307 41331313 6 0.0
.debug_line 5407259 5407282 23 0.0
.debug_loc 3642921 3642922 1 0.0
.debug_ranges 454864 454864 0 0.0
.debug_str 4110809 4110809 0 0.0
.hbn 3220 3220 0 0.0
.hbn_noinit 308 308 0 0.0
.init 408 408 0 0.0
.init_array 148 148 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 99588 99588 0 0.0
.romdata 3224 3224 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 605365 605365 0 0.0
.symtab 181024 181024 0 0.0
.tcm_data 692 692 0 0.0
.tcmcode 512 512 0 0.0
.text 0 0 0 0.0
973660 973660 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 734883 734883 0 0.0
(read/write) 166436 166436 0 0.0
.bss 88852 88852 0 0.0
.data 3420 3420 0 0.0
.rodata 84287 84287 0 0.0
.text 650208 650208 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 756531 756531 0 0.0
(read/write) 176720 176720 0 0.0
.bss 99100 99100 0 0.0
.data 3440 3440 0 0.0
.rodata 79863 79863 0 0.0
.text 676276 676276 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 743875 743875 0 0.0
(read/write) 171176 171176 0 0.0
.bss 93556 93556 0 0.0
.data 3440 3440 0 0.0
.rodata 105951 105951 0 0.0
.text 637532 637532 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 694683 694683 0 0.0
(read/write) 165528 165528 0 0.0
.bss 87720 87720 0 0.0
.data 3408 3408 0 0.0
.rodata 80111 80111 0 0.0
.text 614184 614184 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 680363 680363 0 0.0
(read/write) 165668 165668 0 0.0
.bss 87864 87864 0 0.0
.data 3404 3404 0 0.0
.rodata 75943 75943 0 0.0
.text 604032 604032 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 561266 561266 0 0.0
(read/write) 206492 206492 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 199956 199956 0 0.0
.comment 206 206 0 0.0
.data 1412 1412 0 0.0
.debug_abbrev 895728 895728 0 0.0
.debug_aranges 104272 104272 0 0.0
.debug_frame 351088 351096 8 0.0
.debug_info 19381898 19381937 39 0.0
.debug_line 2584885 2584883 -2 -0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1577831 1577841 10 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 107563 107562 -1 -0.0
.debug_str 3381764 3381764 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 83610 83610 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 466469 466469 0 0.0
.symtab 278848 278848 0 0.0
.text 475536 475536 0 0.0
lock CC3235SF_LAUNCHXL (read only) 617450 617450 0 0.0
(read/write) 206896 206896 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 200336 200336 0 0.0
.comment 206 206 0 0.0
.data 1440 1440 0 0.0
.debug_abbrev 936343 936343 0 0.0
.debug_aranges 108752 108752 0 0.0
.debug_frame 366400 366408 8 0.0
.debug_info 20556258 20556297 39 0.0
.debug_line 2655212 2655210 -2 -0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1633661 1633671 10 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 112112 112111 -1 -0.0
.debug_str 3446010 3446010 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 106162 106162 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 515782 515782 0 0.0
.symtab 298512 298512 0 0.0
.text 0 0 0 0.0
509164 509164 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 551999 551999 0 0.0
.app_xip_area 443217 443217 0 0.0
.bss 63752 63752 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 538135 538135 0 0.0
.app_xip_area 424553 424553 0 0.0
.bss 68520 68520 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 573615 573615 0 0.0
.app_xip_area 466153 466153 0 0.0
.bss 62504 62504 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 549871 549871 0 0.0
.app_xip_area 439329 439329 0 0.0
.bss 65488 65488 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1006544 1006544 0 0.0
.bss 171952 171952 0 0.0
.data 2692 2692 0 0.0
.text 831880 831880 0 0.0
BRD4187C (read/write) 1093040 1093040 0 0.0
.bss 196116 196116 0 0.0
.data 3300 3300 0 0.0
.text 893604 893604 0 0.0
lock-app BRD4161A+wf200 (read/write) 1103560 1103560 0 0.0
.bss 186664 186664 0 0.0
.data 2708 2708 0 0.0
.text 914164 914164 0 0.0
window-app BRD4187C (read/write) 1129372 1129372 0 0.0
.bss 168532 168532 0 0.0
.data 3172 3172 0 0.0
.text 957648 957648 0 0.0
esp32 all-clusters-app c3devkit (read only) 1132326 1132326 0 0.0
(read/write) 1670220 1670220 0 0.0
.dram0.bss 71904 71904 0 0.0
.dram0.data 13020 13020 0 0.0
.flash.rodata 241432 241432 0 0.0
.flash.text 1132326 1132326 0 0.0
.iram0.text 75694 75694 0 0.0
m5stack (read only) 1176955 1176955 0 0.0
(read/write) 520116 520116 0 0.0
.dram0.bss 78552 78552 0 0.0
.dram0.data 34036 34036 0 0.0
.flash.rodata 273164 273164 0 0.0
.flash.text 1171571 1171571 0 0.0
.iram0.text 123907 123907 0 0.0
k32w contact k32w0+release (read only) 589132 589132 0 0.0
(read/write) 87508 87508 0 0.0
.bss 70752 70752 0 0.0
.data 2132 2132 0 0.0
.text 588596 588596 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 684028 684028 0 0.0
.bss 66952 66952 0 0.0
.data 2716 2716 0 0.0
.text 570880 570880 0 0.0
light k32w0+release (read only) 588836 588836 0 0.0
(read/write) 87192 87192 0 0.0
.bss 70448 70448 0 0.0
.data 2120 2120 0 0.0
.text 588300 588300 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 776008 776008 0 0.0
.bss 76628 76628 0 0.0
.data 1928 1928 0 0.0
.text 653992 653992 0 0.0
lock k32w0+release (read only) 560668 560668 0 0.0
(read/write) 85020 85020 0 0.0
.bss 68336 68336 0 0.0
.data 2060 2060 0 0.0
.text 560132 560132 0 0.0
linux air-purifier-app debug (read only) 2464533 2464533 0 0.0
(read/write) 126072 126072 0 0.0
.bss 46608 46608 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 72008 72008 0 0.0
.dynamic 608 608 0 0.0
.got 4560 4560 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 177088 177088 0 0.0
.text 2113909 2113909 0 0.0
all-clusters-app debug (read only) 5286057 5286057 0 0.0
(read/write) 416632 416632 0 0.0
.bss 128976 128976 0 0.0
.data 3856 3856 0 0.0
.data.rel.ro 276560 276560 0 0.0
.dynamic 624 624 0 0.0
.got 5360 5360 0 0.0
.init 27 27 0 0.0
.init_array 1216 1216 0 0.0
.rodata 299468 299468 0 0.0
.text 4608531 4608531 0 0.0
all-clusters-minimal-app debug (read only) 4879649 4879681 32 0.0
(read/write) 232664 232888 224 0.1
.bss 126480 126704 224 0.2
.data 3760 3760 0 0.0
.data.rel.ro 95280 95280 0 0.0
.dynamic 624 624 0 0.0
.got 5320 5320 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 270141 270173 32 0.0
.text 4378675 4378675 0 0.0
bridge-app debug (read only) 4361217 4361217 0 0.0
(read/write) 214968 214968 0 0.0
.bss 118872 118872 0 0.0
.data 4704 4704 0 0.0
.data.rel.ro 84624 84624 0 0.0
.dynamic 624 624 0 0.0
.got 5288 5288 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 217981 217981 0 0.0
.text 3925891 3925891 0 0.0
chip-tool debug (read only) 10266369 10266369 0 0.0
(read/write) 444480 444480 0 0.0
.bss 93688 93688 0 0.0
.data 4994 4994 0 0.0
.data.rel.ro 338576 338576 0 0.0
.dynamic 624 624 0 0.0
.got 5784 5784 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 386505 386505 0 0.0
.text 9280323 9280323 0 0.0
chip-tool-ipv6only arm64 (read only) 10138836 10138836 0 0.0
(read/write) 506424 506424 0 0.0
.bss 103048 103048 0 0.0
.data 4288 4288 0 0.0
.data.rel.ro 375104 375104 0 0.0
.dynamic 512 512 0 0.0
.got 18552 18552 0 0.0
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 315008 315008 0 0.0
.text 9055208 9055208 0 0.0
lighting-app debug+rpc+ui (read only) 5219297 5219297 0 0.0
(read/write) 222960 222960 0 0.0
.bss 118160 118160 0 0.0
.data 4416 4416 0 0.0
.data.rel.ro 92832 92832 0 0.0
.dynamic 672 672 0 0.0
.got 5904 5904 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 336148 336148 0 0.0
.text 4640211 4640211 0 0.0
lock-app debug (read only) 4460657 4460657 0 0.0
(read/write) 203064 203064 0 0.0
.bss 113392 113392 0 0.0
.data 3648 3648 0 0.0
.data.rel.ro 79288 79288 0 0.0
.dynamic 624 624 0 0.0
.got 5240 5240 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 247293 247293 0 0.0
.text 4004051 4004051 0 0.0
ota-provider-app debug (read only) 4117921 4117921 0 0.0
(read/write) 192032 192032 0 0.0
.bss 113536 113536 0 0.0
.data 3920 3920 0 0.0
.data.rel.ro 68656 68656 0 0.0
.dynamic 624 624 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 199773 199773 0 0.0
.text 3727587 3727587 0 0.0
ota-requestor-app debug (read only) 4203129 4203129 0 0.0
(read/write) 196216 196216 0 0.0
.bss 114560 114560 0 0.0
.data 4160 4160 0 0.0
.data.rel.ro 71600 71600 0 0.0
.dynamic 624 624 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 203037 203037 0 0.0
.text 3805251 3805251 0 0.0
shell debug (read only) 2752809 2752809 0 0.0
(read/write) 148992 148992 0 0.0
.bss 59592 59592 0 0.0
.data 816 816 0 0.0
.data.rel.ro 82792 82792 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 180800 180800 0 0.0
.text 2401634 2401634 0 0.0
thermostat-no-ble arm64 (read only) 4346580 4346580 0 0.0
(read/write) 241864 241864 0 0.0
.bss 122168 122168 0 0.0
.data 2792 2792 0 0.0
.data.rel.ro 100528 100528 0 0.0
.dynamic 512 512 0 0.0
.got 11912 11912 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 160820 160820 0 0.0
.text 3851144 3851144 0 0.0
tv-app debug (read only) 5284689 5284721 32 0.0
(read/write) 351664 351888 224 0.1
.bss 242880 243104 224 0.1
.data 5024 5024 0 0.0
.data.rel.ro 96384 96384 0 0.0
.dynamic 624 624 0 0.0
.got 5584 5584 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 271021 271053 32 0.0
.text 4769875 4769875 0 0.0
tv-casting-app debug (read only) 8214633 8214633 0 0.0
(read/write) 314008 314008 0 0.0
.bss 155872 155872 0 0.0
.data 2464 2464 0 0.0
.data.rel.ro 148816 148816 0 0.0
.dynamic 624 624 0 0.0
.got 5064 5064 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 337432 337432 0 0.0
.text 7473043 7473043 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2521976 2521976 0 0.0
.bss 219048 219048 0 0.0
.data 5136 5136 0 0.0
.text 1484660 1484660 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1178724 1178724 0 0.0
bss 153980 153980 0 0.0
rodata 118672 118672 0 0.0
text 827164 827164 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1326208 1326208 0 0.0
bss 139990 139990 0 0.0
rodata 134736 134736 0 0.0
text 760828 760828 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1160412 1160552 140 0.0
bss 153994 154219 225 0.1
rodata 113712 113724 12 0.0
text 813688 813688 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 838144 838144 0 0.0
(read/write) 1722604 1722604 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 192700 192700 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2496 2496 0 0.0
.debug_abbrev 1318303 1318303 0 0.0
.debug_aranges 140968 140968 0 0.0
.debug_frame 466984 466992 8 0.0
.debug_info 30188740 30188779 39 0.0
.debug_line 3888455 3888453 -2 -0.0
.debug_line_str 957 957 0 0.0
.debug_loclists 2244326 2244336 10 0.0
.debug_rnglists 151676 151675 -1 -0.0
.debug_str 4108000 4108000 0 0.0
.heap 838144 838144 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 797030 797030 0 0.0
.symtab 493728 493728 0 0.0
.text 0 0 0 0.0
1519020 1519020 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 840160 839936 -224 -0.0
(read/write) 1680932 1681164 232 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 190708 190932 224 0.1
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1258899 1258899 0 0.0
.debug_aranges 137184 137184 0 0.0
.debug_frame 460372 460380 8 0.0
.debug_info 28465238 28465286 48 0.0
.debug_line 3793955 3793953 -2 -0.0
.debug_line_str 981 981 0 0.0
.debug_loclists 2188807 2188817 10 0.0
.debug_rnglists 147491 147490 -1 -0.0
.debug_str 4001027 4001027 0 0.0
.heap 840160 839936 -224 -0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 741385 741385 0 0.0
.symtab 474784 474784 0 0.0
.text 1479364 1479372 8 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 846488 846488 0 0.0
(read/write) 1607364 1607364 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184492 184492 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2360 2360 0 0.0
.debug_abbrev 1100274 1100274 0 0.0
.debug_aranges 127240 127240 0 0.0
.debug_frame 423264 423272 8 0.0
.debug_info 23591973 23592012 39 0.0
.debug_line 3369083 3369081 -2 -0.0
.debug_line_str 942 942 0 0.0
.debug_loclists 2025154 2025164 10 0.0
.debug_rnglists 137025 137024 -1 -0.0
.debug_str 3807916 3807916 0 0.0
.heap 846488 846488 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 654477 654477 0 0.0
.symtab 436240 436240 0 0.0
.text 1412124 1412124 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 819224 819224 0 0.0
(read/write) 1640212 1640212 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 211740 211740 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2376 2376 0 0.0
.debug_abbrev 1093306 1093306 0 0.0
.debug_aranges 125936 125936 0 0.0
.debug_frame 418532 418540 8 0.0
.debug_info 23402966 23403005 39 0.0
.debug_line 3321806 3321804 -2 -0.0
.debug_line_str 933 933 0 0.0
.debug_loclists 2002041 2002051 10 0.0
.debug_rnglists 135060 135059 -1 -0.0
.debug_str 3770497 3770497 0 0.0
.heap 819224 819224 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 628059 628059 0 0.0
.symtab 427824 427824 0 0.0
.text 1417708 1417708 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1176172 1176172 0 0.0
.bss 100608 100608 0 0.0
.data 744 744 0 0.0
.text 623016 623016 0 0.0
lock-app qpg6105+debug (read/write) 1132652 1132652 0 0.0
.bss 95288 95288 0 0.0
.data 748 748 0 0.0
.text 579492 579492 0 0.0
telink air-quality-sensor-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 856128 856128 0 0.0
bss 77996 77996 0 0.0
text 603756 603756 0 0.0
all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1077648 1077648 0 0.0
bss 112632 112632 0 0.0
text 757426 757426 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1076128 1076364 236 0.0
bss 122236 122460 224 0.2
text 743898 743898 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 931424 931424 0 0.0
bss 106876 106876 0 0.0
text 640952 640952 0 0.0
contact-sensor-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 859488 859488 0 0.0
bss 78120 78120 0 0.0
text 606822 606822 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 4 4 0 0.0
(read/write) 961608 961608 0 0.0
bss 88184 88184 0 0.0
text 683242 683242 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1087380 1087380 0 0.0
bss 112384 112384 0 0.0
text 761594 761594 0 0.0
lock-app-dfu tlsr9528a (read only) 4 4 0 0.0
(read/write) 917948 917948 0 0.0
bss 78812 78812 0 0.0
text 637694 637694 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 944752 944752 0 0.0
bss 104976 104976 0 0.0
text 656724 656724 0 0.0
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 863356 863356 0 0.0
bss 78228 78228 0 0.0
text 611028 611028 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 804224 804224 0 0.0
bss 66248 66248 0 0.0
text 578064 578064 0 0.0
resource-monitoring-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 819880 819880 0 0.0
bss 66652 66652 0 0.0
text 588644 588644 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 708920 708920 0 0.0
bss 86424 86424 0 0.0
text 461956 461956 0 0.0
smoke_co_alarm-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 861936 861936 0 0.0
bss 78204 78204 0 0.0
text 610206 610206 0 0.0
temperature-measurement-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 847168 847168 0 0.0
bss 77932 77932 0 0.0
text 597562 597562 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 825268 825268 0 0.0
bss 66536 66536 0 0.0
text 593388 593388 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 822732 822732 0 0.0
bss 66888 66888 0 0.0
text 590436 590436 0 0.0

bzbarsky-apple
bzbarsky-apple approved these changes Oct 24, 2023
View reviewed changes
src/app/zap-templates/zcl/data-model/chip/application-basic-cluster.xml
@@ -26,12 +26,15 @@ limitations under the License.
<description>This cluster provides information about an application running on a TV or media player device which is represented as an endpoint.</description>
<attribute side="server" code="0x0000" define="APPLICATION_VENDOR_NAME" type="char_string" default="" length="32" writable="false" optional="true">VendorName</attribute>
<attribute side="server" code="0x0001" define="APPLICATION_VENDOR_ID" type="vendor_id" default="0x0" min="0x0000" max="0xFFFF" writable="false" optional="true">VendorID</attribute>
<attribute side="server" code="0x0002" define="APPLICATION_NAME" type="char_string" length="32" writable="false" optional="false">ApplicationName</attribute>
<attribute side="server" code="0x0002" define="APPLICATION_NAME" type="long_char_string" length="256" writable="false" optional="false">ApplicationName</attribute>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. Is there a spec issue tracking the fact that this has a "desc" constraint when it should hust have a normal constraint?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that I am aware ... only saw this because I saw the scraper saying "no constraint" and reading the description said 256 .... it should actually be 256 I guess but from an SDK perspective I would prefer bytes.

@mergify mergify bot merged commit a0d3555 into project-chip:master Oct 25, 2023
53 checks passed
shripad621git pushed a commit to shripad621git/connectedhomeip that referenced this pull request Oct 31, 2023
@andy31415 @andreilitvin @shripad621git
Change Media::ApplicationBasic cluster to match spec (project-chip#29959
25970b7 
)

* Application basic: increase length of application name and mark vendor list as access administer

* Zap regen

* Switch to long char string, to support 256 characters

---------

Co-authored-by: Andrei Litvin <andreilitvin@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@tehampson tehampson tehampson approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app controller examples review - approved scripts skip-protocol-compatibility Marker that protocol backwards compatibility checks are to be skipped
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andy31415 @tehampson @bzbarsky-apple @andreilitvin