-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't generate Objective-C compatibility headers for Matter.framework Swift APIs. #30028
Merged
woody-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:disable-objc-compat-header
Oct 27, 2023
Merged
Don't generate Objective-C compatibility headers for Matter.framework Swift APIs. #30028
woody-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:disable-objc-compat-header
Oct 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mhazley
October 26, 2023 18:25
pullapprove
bot
requested review from
p0fi,
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
October 26, 2023 18:25
bzbarsky-apple
force-pushed
the
disable-objc-compat-header
branch
from
October 26, 2023 18:25
879ddb9
to
9d2d6d2
Compare
PR #30028: Size comparison from 9b07f01 to 9d2d6d2 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
… Swift APIs. Our Swift APIs are meant for use from Swift only anyway: they are implementing convenience APIs for NS_REFINED_FOR_SWIFT bits and other places where the Objective-C API maps oddly to Swift.
bzbarsky-apple
force-pushed
the
disable-objc-compat-header
branch
from
October 26, 2023 21:42
9d2d6d2
to
eda5391
Compare
PR #30028: Size comparison from 28de696 to eda5391 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
approved these changes
Oct 27, 2023
shripad621git
pushed a commit
to shripad621git/connectedhomeip
that referenced
this pull request
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our Swift APIs are meant for use from Swift only anyway: they are implementing convenience APIs for NS_REFINED_FOR_SWIFT bits and other places where the Objective-C API maps oddly to Swift.