-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chip::to_underlying is missing [air-quality-sensor-manager] #30057
Conversation
@bzbarsky-apple Hi! I closed #30034 because I could not sign the CLA, with the previous PR something went wrong because of wrong email. |
PR #30057: Size comparison from 02e7647 to de79f8b Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
I think we should remove the following line: Line 139 in 02e7647
Because we are converting AirQualityEnum type to AirQualityEnum type |
examples/air-quality-sensor-app/air-quality-sensor-common/src/air-quality-sensor-manager.cpp
Outdated
Show resolved
Hide resolved
@BurievSardor Thank you! |
PR #30057: Size comparison from 02e7647 to a4f033a Increases above 0.2%:
Increases (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (11 builds for cc32xx, efr32, linux, psoc6)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…chip#30057) * chip::to_underlying is missing * Apply suggested fix to remove unnecessary cast. --------- Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Fixes #29735
chip::to_underlying is missing