-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Application Launcher Cluster
to be spec compliant
#30134
Move Application Launcher Cluster
to be spec compliant
#30134
Conversation
PR #30134: Size comparison from 5c9d8e8 to 02fead0 Decreases (13 builds for bl702, bl702l, cc32xx, psoc6)
Full report (56 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #30134: Size comparison from 5218c3b to c25d72b Increases above 0.2%:
Increases (1 build for qpg)
Decreases (3 builds for cc32xx, qpg)
Full report (5 builds for cc32xx, mbed, qpg)
|
PR #30134: Size comparison from 2bd5940 to 08f0cfb Increases (1 build for linux)
Decreases (14 builds for bl702, bl702l, cc32xx, linux, psoc6)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
@@ -69,7 +69,7 @@ limitations under the License. | |||
<item name="ApplicationID" type="char_string"/> | |||
</struct> | |||
|
|||
<enum name="ApplicationLauncherStatusEnum" type="enum8"> | |||
<enum name="StatusEnum" type="enum8"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there a reason a backwards compat shim for the old name was not added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
created #30202
<attribute side="server" code="0x0000" define="APPLICATION_LAUNCHER_LIST" type="ARRAY" entryType="int16u" length="254" reportable="true" writable="false" optional="true">CatalogList</attribute> | ||
<attribute side="server" code="0x0001" define="APPLICATION_LAUNCHER_CURRENT_APP" type="ApplicationEPStruct" default="0x0" isNullable="true" writable="true" optional="true">CurrentApp</attribute> | ||
<attribute side="server" code="0x0000" define="APPLICATION_LAUNCHER_LIST" type="ARRAY" entryType="int16u" reportable="true" writable="false" optional="true">CatalogList</attribute> | ||
<attribute side="server" code="0x0001" define="APPLICATION_LAUNCHER_CURRENT_APP" type="ApplicationEPStruct" isNullable="true" writable="false" optional="true">CurrentApp</attribute> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change. This might need to get changed in the spec instead, if we can't figure out a way to not have client APIs break on this.
* Mark new things as provisional. * Fix incorrect availability for ApplicationLauncher's StatusEnum introduced by project-chip#30134
* Mark new things as provisional. * Fix incorrect availability for ApplicationLauncher's StatusEnum introduced by #30134
Changes:
ApplicationLauncherStatusEnum
toStatusEnum
to match spec naming