-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix darwin-tests workflow file syntax. #30162
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mhazley
November 2, 2023 01:45
pullapprove
bot
requested review from
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
November 2, 2023 01:45
andy31415
approved these changes
Nov 2, 2023
PR #30162: Size comparison from edfc199 to a305f28 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There were extra curly braces that failed on some (but not all?) CI runs.
bzbarsky-apple
force-pushed
the
fix-workflow-file
branch
from
November 2, 2023 05:45
a305f28
to
88eff27
Compare
PR #30162: Size comparison from a607daa to 88eff27 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
simonhmorris1
approved these changes
Nov 2, 2023
simonhmorris1
pushed a commit
to simonhmorris1/connectedhomeip
that referenced
this pull request
Nov 2, 2023
There were extra curly braces that failed on some (but not all?) CI runs.
mergify bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
* Add non-concurrent SupportsConcurrentConnection * Address CI build issues (#29865) * Fix style issue (#29865) * Fix read of SupportsConcurrentConnection (#29865) * Correct intermittent missing SSID(#29865) * ConnectNetworkResponse Supression (#29865) * Add non-concurrent SupportsConcurrentConnection * Address CI build issues (#29865) * Fix style issue (#29865) * Fix read of SupportsConcurrentConnection (#29865) * Fix merge issue with ICD attributes(#29865) * Fix darwin-tests workflow file syntax. (#30162) There were extra curly braces that failed on some (but not all?) CI runs. * Add non-concurrent SupportsConcurrentConnection * Address CI build issues (#29865) * Fix style issue (#29865) * Fix read of SupportsConcurrentConnection (#29865) * Fix merge issue with ICD attributes(#29865) * Only start WiFi on BLE Commissioning pass(#29865) * Remove use of Breadcrumb::Get from BLE (#29865) * Add non-concurrent SupportsConcurrentConnection * Address CI build issues (#29865) * Fix style issue (#29865) * Fix read of SupportsConcurrentConnection (#29865) * Fix merge issue with ICD attributes(#29865) * Only start WiFi on BLE Commissioning pass(#29865) * Remove use of Breadcrumb::Get from BLE (#29865) * Tidy comments (#29865) * Default on error, check timeout, tidy up (#29865) * Make log messages user friendly (#29865) * Change to compile time non-concurrent mode(#29865) * Restyled by whitespace * Restyled by clang-format * Improve code style (#29865) * Restyled by clang-format * Add CommandHandler issue reference 30576 (#29865) --------- Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> Co-authored-by: Restyled.io <commits@restyled.io>
DamMicSzm
pushed a commit
to DamMicSzm/connectedhomeip
that referenced
this pull request
Nov 30, 2023
* Add non-concurrent SupportsConcurrentConnection * Address CI build issues (project-chip#29865) * Fix style issue (project-chip#29865) * Fix read of SupportsConcurrentConnection (project-chip#29865) * Correct intermittent missing SSID(project-chip#29865) * ConnectNetworkResponse Supression (project-chip#29865) * Add non-concurrent SupportsConcurrentConnection * Address CI build issues (project-chip#29865) * Fix style issue (project-chip#29865) * Fix read of SupportsConcurrentConnection (project-chip#29865) * Fix merge issue with ICD attributes(project-chip#29865) * Fix darwin-tests workflow file syntax. (project-chip#30162) There were extra curly braces that failed on some (but not all?) CI runs. * Add non-concurrent SupportsConcurrentConnection * Address CI build issues (project-chip#29865) * Fix style issue (project-chip#29865) * Fix read of SupportsConcurrentConnection (project-chip#29865) * Fix merge issue with ICD attributes(project-chip#29865) * Only start WiFi on BLE Commissioning pass(project-chip#29865) * Remove use of Breadcrumb::Get from BLE (project-chip#29865) * Add non-concurrent SupportsConcurrentConnection * Address CI build issues (project-chip#29865) * Fix style issue (project-chip#29865) * Fix read of SupportsConcurrentConnection (project-chip#29865) * Fix merge issue with ICD attributes(project-chip#29865) * Only start WiFi on BLE Commissioning pass(project-chip#29865) * Remove use of Breadcrumb::Get from BLE (project-chip#29865) * Tidy comments (project-chip#29865) * Default on error, check timeout, tidy up (project-chip#29865) * Make log messages user friendly (project-chip#29865) * Change to compile time non-concurrent mode(project-chip#29865) * Restyled by whitespace * Restyled by clang-format * Improve code style (project-chip#29865) * Restyled by clang-format * Add CommandHandler issue reference 30576 (project-chip#29865) --------- Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were extra curly braces that failed on some (but not all?) CI runs.