-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Darwin handling of provisional fields in non-provisional commands/structs. #30279
Merged
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:provisional-struct-members
Nov 7, 2023
Merged
Fix Darwin handling of provisional fields in non-provisional commands/structs. #30279
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:provisional-struct-members
Nov 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mhazley,
mkardous-silabs,
mspang and
nivi-apple
November 7, 2023 15:20
pullapprove
bot
requested review from
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
November 7, 2023 15:20
PR #30279: Size comparison from a61a58f to 2177101 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jtung-apple
approved these changes
Nov 7, 2023
bzbarsky-apple
commented
Nov 7, 2023
src/darwin/Framework/CHIP/templates/MTRCommandPayloadsObjc-src.zapt
Outdated
Show resolved
Hide resolved
bzbarsky-apple
force-pushed
the
provisional-struct-members
branch
from
November 7, 2023 19:11
2177101
to
021fe07
Compare
…/structs. We want to make sure that our framework-internal code knows about provisional things whether the API client enables them or not. The xcodebuild bit in the darwin workflow that was testing that MTR_ENABLE_PROVISIONAL compiled is now redundant. I verified that trying to use provisional things in the XCTest unit tests fails to compile unless MTR_ENABLE_PROVISIONAL=1 is explicitly used for the "xcodebuild test" command.
bzbarsky-apple
force-pushed
the
provisional-struct-members
branch
from
November 7, 2023 19:25
021fe07
to
e4e549f
Compare
ksperling-apple
approved these changes
Nov 7, 2023
PR #30279: Size comparison from 9332885 to e4e549f Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to make sure that our framework-internal code knows about provisional
things whether the API client enables them or not.
The xcodebuild bit in the darwin workflow that was testing that
MTR_ENABLE_PROVISIONAL compiled is now redundant.
I verified that trying to use provisional things in the XCTest unit tests fails
to compile unless MTR_ENABLE_PROVISIONAL=1 is explicitly used for the
"xcodebuild test" command.