-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs] Sleepy changes for 917 SoC #30307
[Silabs] Sleepy changes for 917 SoC #30307
Conversation
@@ -130,8 +130,8 @@ if (silabs_board == "BRD4304A") { | |||
} else if (silabs_board == "BRD4338A") { | |||
silabs_family = "SiWx917-common" | |||
silabs_mcu = "SiWG917M111MGTBA" | |||
disable_lcd = false | |||
show_qr_code = true | |||
disable_lcd = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to be removed, just disabled the lcd and qr by default since it creates conflicts with the sleep
PR #30307: Size comparison from 155917e to a7e166c Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
@@ -43,6 +43,9 @@ | |||
|
|||
#ifdef SIWX_917 | |||
#include "wfx_rsi.h" | |||
#if SL_ICD_ENABLED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CHIP_CONFIG_ENABLE_ICD_SERVER
should work here.
We want to avoid using SL_ICD_ENABLED
where it is not necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay got it
extern "C" void vApplicationIdleHook(void) | ||
{ | ||
// FreeRTOS Idle callback | ||
#if ((SIWX_917 == 1) && (SL_ICD_ENABLED == 1)) | ||
if(ConnectivityMgr().IsWiFiStationConnected()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't check commissioning. This only checks if we are connected to a wifi network.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, the device can go to sleep once it is connected to router and TA will handle the wakeup/sleep
"SI917_COMMON_FLASH=1", | ||
"SRAM_BASE=0x0c", | ||
"SRAM_SIZE=0x00040000", | ||
"DEBUG_ENABLE=1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will these debug flags be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah the cleanup will be done
"SL_CATALOG_SLEEPTIMER_PRESENT", | ||
"WIFI_DEBUG_ENABLED=1", | ||
"SL_ICD_ENABLED=1", | ||
"SL_ACTIVE_MODE_THRESHOLD=${sl_active_mode_threshold_ms}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you add the associateed gn arguments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gn arguments are shared between the siwx917_sdk.gni and efr32_sdk.gni so it can be reused
PR #30307: Size comparison from d389403 to 15d8e21 Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30307: Size comparison from 02683ee to 781aad1 Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Created a new PR since the wifi sdk got updated |
No description provided.