-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Level Control Cluster
to match the spec
#30417
Move Level Control Cluster
to match the spec
#30417
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
PR #30417: Size comparison from 8d8d8a2 to 3604d6c Increases (8 builds for bl702l, esp32, linux, telink)
Decreases (33 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, k32w, linux, nrfconnect, psoc6, qpg)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Added StepModeEnum back because https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/7831 adds it in the spec |
PR #30417: Size comparison from baa1d7a to 6b261fd Decreases (3 builds for bl602, bl702, mbed)
Full report (38 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, k32w, mbed, nrfconnect, psoc6, qpg)
|
PR #30417: Size comparison from baa1d7a to 2a68bef Decreases (4 builds for bl602, bl702, efr32, mbed)
Full report (61 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30417: Size comparison from baa1d7a to 7e27317 Increases (50 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (7 builds for bl602, bl702, bl702l, efr32, linux, mbed)
Full report (61 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Unwanted third_party changes should be removed now.
PR #30417: Size comparison from 05f985a to 7957832 Full report (8 builds for cc32xx, mbed, nrfconnect, qpg)
|
PR #30417: Size comparison from 05f985a to 6456de2 Increases (7 builds for linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Changes:
MoveMode
toMoveModeEnum
StepMode
withStepModeEnum
(usage of StepMode appearing in https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/7831)LevelControlOptions
toOptionsBitmap
Along with changes for compilation (zap regen, zap-update-all, adding to backwards compat and replace the usages of the above enums/bitmaps in code where I could find them)
NOT changed (will change spec)
Spec says OptionsMask is
map8
(untyped) however using OptionsBitmap sems to correct thing to do.