Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization Time Format Cluster: add UseActiveLocale tag as a placeholder for NULL #30520

Merged
merged 30 commits into from
Dec 7, 2023
Merged

Localization Time Format Cluster: add UseActiveLocale tag as a placeholder for NULL #30520

Show file tree
Hide file tree
Changes from 23 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
5cf8cef
Define a new constant
andreilitvin Nov 16, 2023
42099b2
Another constant addition
andreilitvin Nov 16, 2023
e828835
Adjust range
andreilitvin Nov 16, 2023
eaf0e45
Zap regen
andreilitvin Nov 16, 2023
30986df
Undo my editor auto-format, to make diff easier to read
andreilitvin Nov 16, 2023
4b11783
Update Darwin availability annotations.
bzbarsky-apple Nov 17, 2023
ba67c1a
Add extra validation for calendar locales
andy31415 Nov 17, 2023
bbfeaa0
Always support using active locale (seems like a better default than …
andy31415 Nov 17, 2023
5166ecc
Set the return value to constraint error on invalid calendar
andy31415 Nov 17, 2023
fd17608
Restyle
andy31415 Nov 17, 2023
c3d39e9
Use the pre-change callback for validation, less complex than the wri…
andy31415 Nov 17, 2023
9516af5
Fix range for hour format
andy31415 Nov 17, 2023
33e8463
Revert "Fix range for hour format"
andy31415 Nov 17, 2023
84e3917
Fix hour format ranges as well
andy31415 Nov 17, 2023
40fe67e
make compile happy
andy31415 Nov 17, 2023
74e5e00
Handle null value in autoreleaser
andy31415 Nov 17, 2023
176064b
Enforce that validType is ALWAYS a valid type
andy31415 Nov 17, 2023
90ac9ce
Undo refactor changes
andy31415 Nov 17, 2023
f9a968e
Merge branch 'master' into localization_update_constant
andy31415 Nov 20, 2023
2f03415
Rely on IM logic to detect unknown values and return a correct response
andy31415 Nov 20, 2023
7cd8bfd
Restyle
andy31415 Nov 20, 2023
07bf1ed
More validation logic ... seems it is not automatic after all
andy31415 Nov 20, 2023
6488f2d
Merge branch 'master' into localization_update_constant
andy31415 Dec 1, 2023
a1ff69c
Remove some chip namespace and use NullOptional
andy31415 Dec 1, 2023
19b3805
Use EnsureKnownEnumValue helper
andy31415 Dec 1, 2023
775e875
Restyle
andy31415 Dec 1, 2023
4c40df0
make code consistent
andy31415 Dec 1, 2023
3d85b6d
Merge branch 'master' into localization_update_constant
andreilitvin Dec 7, 2023
e483418
update based on review
andreilitvin Dec 7, 2023
5b6d36a
Fix the merge
andreilitvin Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions examples/all-clusters-app/all-clusters-common/all-clusters-app.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1219,11 +1219,13 @@ cluster TimeFormatLocalization = 44 {
kKorean = 9;
kPersian = 10;
kTaiwanese = 11;
kUseActiveLocale = 255;
}

enum HourFormatEnum : enum8 {
k12hr = 0;
k24hr = 1;
kUseActiveLocale = 255;
}

bitmap Feature : bitmap32 {
Expand Down
2 changes: 2 additions & 0 deletions examples/all-clusters-minimal-app/all-clusters-common/all-clusters-minimal-app.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1112,11 +1112,13 @@ cluster TimeFormatLocalization = 44 {
kKorean = 9;
kPersian = 10;
kTaiwanese = 11;
kUseActiveLocale = 255;
}

enum HourFormatEnum : enum8 {
k12hr = 0;
k24hr = 1;
kUseActiveLocale = 255;
}

bitmap Feature : bitmap32 {
Expand Down
2 changes: 2 additions & 0 deletions examples/bridge-app/bridge-common/bridge-app.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -763,11 +763,13 @@ cluster TimeFormatLocalization = 44 {
kKorean = 9;
kPersian = 10;
kTaiwanese = 11;
kUseActiveLocale = 255;
}

enum HourFormatEnum : enum8 {
k12hr = 0;
k24hr = 1;
kUseActiveLocale = 255;
}

bitmap Feature : bitmap32 {
Expand Down
2 changes: 2 additions & 0 deletions examples/chef/devices/noip_rootnode_dimmablelight_bCwGYSDpoe.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -742,11 +742,13 @@ cluster TimeFormatLocalization = 44 {
kKorean = 9;
kPersian = 10;
kTaiwanese = 11;
kUseActiveLocale = 255;
}

enum HourFormatEnum : enum8 {
k12hr = 0;
k24hr = 1;
kUseActiveLocale = 255;
}

bitmap Feature : bitmap32 {
Expand Down
2 changes: 2 additions & 0 deletions examples/chef/devices/rootnode_airqualitysensor_e63187f6c9.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,11 +447,13 @@ cluster TimeFormatLocalization = 44 {
kKorean = 9;
kPersian = 10;
kTaiwanese = 11;
kUseActiveLocale = 255;
}

enum HourFormatEnum : enum8 {
k12hr = 0;
k24hr = 1;
kUseActiveLocale = 255;
}

bitmap Feature : bitmap32 {
Expand Down
2 changes: 2 additions & 0 deletions examples/chef/devices/rootnode_basicvideoplayer_0ff86e943b.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,11 +469,13 @@ cluster TimeFormatLocalization = 44 {
kKorean = 9;
kPersian = 10;
kTaiwanese = 11;
kUseActiveLocale = 255;
}

enum HourFormatEnum : enum8 {
k12hr = 0;
k24hr = 1;
kUseActiveLocale = 255;
}

bitmap Feature : bitmap32 {
Expand Down
2 changes: 2 additions & 0 deletions examples/chef/devices/rootnode_contactsensor_lFAGG1bfRO.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,11 +545,13 @@ cluster TimeFormatLocalization = 44 {
kKorean = 9;
kPersian = 10;
kTaiwanese = 11;
kUseActiveLocale = 255;
}

enum HourFormatEnum : enum8 {
k12hr = 0;
k24hr = 1;
kUseActiveLocale = 255;
}

bitmap Feature : bitmap32 {
Expand Down
2 changes: 2 additions & 0 deletions examples/chef/devices/rootnode_dimmablelight_bCwGYSDpoe.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -742,11 +742,13 @@ cluster TimeFormatLocalization = 44 {
kKorean = 9;
kPersian = 10;
kTaiwanese = 11;
kUseActiveLocale = 255;
}

enum HourFormatEnum : enum8 {
k12hr = 0;
k24hr = 1;
kUseActiveLocale = 255;
}

bitmap Feature : bitmap32 {
Expand Down
2 changes: 2 additions & 0 deletions examples/chef/devices/rootnode_dishwasher_cc105034fe.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,11 +293,13 @@ cluster TimeFormatLocalization = 44 {
kKorean = 9;
kPersian = 10;
kTaiwanese = 11;
kUseActiveLocale = 255;
}

enum HourFormatEnum : enum8 {
k12hr = 0;
k24hr = 1;
kUseActiveLocale = 255;
}

bitmap Feature : bitmap32 {
Expand Down
2 changes: 2 additions & 0 deletions examples/chef/devices/rootnode_doorlock_aNKYAreMXE.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,11 +545,13 @@ cluster TimeFormatLocalization = 44 {
kKorean = 9;
kPersian = 10;
kTaiwanese = 11;
kUseActiveLocale = 255;
}

enum HourFormatEnum : enum8 {
k12hr = 0;
k24hr = 1;
kUseActiveLocale = 255;
}

bitmap Feature : bitmap32 {
Expand Down
2 changes: 2 additions & 0 deletions examples/chef/devices/rootnode_extendedcolorlight_8lcaaYJVAa.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -742,11 +742,13 @@ cluster TimeFormatLocalization = 44 {
kKorean = 9;
kPersian = 10;
kTaiwanese = 11;
kUseActiveLocale = 255;
}

enum HourFormatEnum : enum8 {
k12hr = 0;
k24hr = 1;
kUseActiveLocale = 255;
}

bitmap Feature : bitmap32 {
Expand Down
2 changes: 2 additions & 0 deletions examples/chef/devices/rootnode_fan_7N2TobIlOX.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,11 +524,13 @@ cluster TimeFormatLocalization = 44 {
kKorean = 9;
kPersian = 10;
kTaiwanese = 11;
kUseActiveLocale = 255;
}

enum HourFormatEnum : enum8 {
k12hr = 0;
k24hr = 1;
kUseActiveLocale = 255;
}

bitmap Feature : bitmap32 {
Expand Down
2 changes: 2 additions & 0 deletions examples/chef/devices/rootnode_flowsensor_1zVxHedlaV.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,11 +545,13 @@ cluster TimeFormatLocalization = 44 {
kKorean = 9;
kPersian = 10;
kTaiwanese = 11;
kUseActiveLocale = 255;
}

enum HourFormatEnum : enum8 {
k12hr = 0;
k24hr = 1;
kUseActiveLocale = 255;
}

bitmap Feature : bitmap32 {
Expand Down
2 changes: 2 additions & 0 deletions examples/chef/devices/rootnode_heatingcoolingunit_ncdGai1E5a.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -742,11 +742,13 @@ cluster TimeFormatLocalization = 44 {
kKorean = 9;
kPersian = 10;
kTaiwanese = 11;
kUseActiveLocale = 255;
}

enum HourFormatEnum : enum8 {
k12hr = 0;
k24hr = 1;
kUseActiveLocale = 255;
}

bitmap Feature : bitmap32 {
Expand Down
2 changes: 2 additions & 0 deletions examples/chef/devices/rootnode_humiditysensor_Xyj4gda6Hb.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,11 +545,13 @@ cluster TimeFormatLocalization = 44 {
kKorean = 9;
kPersian = 10;
kTaiwanese = 11;
kUseActiveLocale = 255;
}

enum HourFormatEnum : enum8 {
k12hr = 0;
k24hr = 1;
kUseActiveLocale = 255;
}

bitmap Feature : bitmap32 {
Expand Down
2 changes: 2 additions & 0 deletions examples/chef/devices/rootnode_laundrywasher_fb10d238c8.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,11 +293,13 @@ cluster TimeFormatLocalization = 44 {
kKorean = 9;
kPersian = 10;
kTaiwanese = 11;
kUseActiveLocale = 255;
}

enum HourFormatEnum : enum8 {
k12hr = 0;
k24hr = 1;
kUseActiveLocale = 255;
}

bitmap Feature : bitmap32 {
Expand Down
2 changes: 2 additions & 0 deletions examples/chef/devices/rootnode_lightsensor_lZQycTFcJK.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,11 +545,13 @@ cluster TimeFormatLocalization = 44 {
kKorean = 9;
kPersian = 10;
kTaiwanese = 11;
kUseActiveLocale = 255;
}

enum HourFormatEnum : enum8 {
k12hr = 0;
k24hr = 1;
kUseActiveLocale = 255;
}

bitmap Feature : bitmap32 {
Expand Down
2 changes: 2 additions & 0 deletions examples/chef/devices/rootnode_occupancysensor_iHyVgifZuo.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,11 +545,13 @@ cluster TimeFormatLocalization = 44 {
kKorean = 9;
kPersian = 10;
kTaiwanese = 11;
kUseActiveLocale = 255;
}

enum HourFormatEnum : enum8 {
k12hr = 0;
k24hr = 1;
kUseActiveLocale = 255;
}

bitmap Feature : bitmap32 {
Expand Down
2 changes: 2 additions & 0 deletions examples/chef/devices/rootnode_onofflight_bbs1b7IaOV.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -742,11 +742,13 @@ cluster TimeFormatLocalization = 44 {
kKorean = 9;
kPersian = 10;
kTaiwanese = 11;
kUseActiveLocale = 255;
}

enum HourFormatEnum : enum8 {
k12hr = 0;
k24hr = 1;
kUseActiveLocale = 255;
}

bitmap Feature : bitmap32 {
Expand Down
2 changes: 2 additions & 0 deletions examples/chef/devices/rootnode_onofflight_samplemei.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -742,11 +742,13 @@ cluster TimeFormatLocalization = 44 {
kKorean = 9;
kPersian = 10;
kTaiwanese = 11;
kUseActiveLocale = 255;
}

enum HourFormatEnum : enum8 {
k12hr = 0;
k24hr = 1;
kUseActiveLocale = 255;
}

bitmap Feature : bitmap32 {
Expand Down
2 changes: 2 additions & 0 deletions examples/chef/devices/rootnode_onofflightswitch_FsPlMr090Q.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,11 +689,13 @@ cluster TimeFormatLocalization = 44 {
kKorean = 9;
kPersian = 10;
kTaiwanese = 11;
kUseActiveLocale = 255;
}

enum HourFormatEnum : enum8 {
k12hr = 0;
k24hr = 1;
kUseActiveLocale = 255;
}

bitmap Feature : bitmap32 {
Expand Down
2 changes: 2 additions & 0 deletions examples/chef/devices/rootnode_onoffpluginunit_Wtf8ss5EBY.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,11 +617,13 @@ cluster TimeFormatLocalization = 44 {
kKorean = 9;
kPersian = 10;
kTaiwanese = 11;
kUseActiveLocale = 255;
}

enum HourFormatEnum : enum8 {
k12hr = 0;
k24hr = 1;
kUseActiveLocale = 255;
}

bitmap Feature : bitmap32 {
Expand Down
2 changes: 2 additions & 0 deletions examples/chef/devices/rootnode_pressuresensor_s0qC9wLH4k.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,11 +545,13 @@ cluster TimeFormatLocalization = 44 {
kKorean = 9;
kPersian = 10;
kTaiwanese = 11;
kUseActiveLocale = 255;
}

enum HourFormatEnum : enum8 {
k12hr = 0;
k24hr = 1;
kUseActiveLocale = 255;
}

bitmap Feature : bitmap32 {
Expand Down
2 changes: 2 additions & 0 deletions examples/chef/devices/rootnode_pump_5f904818cc.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,11 +365,13 @@ cluster TimeFormatLocalization = 44 {
kKorean = 9;
kPersian = 10;
kTaiwanese = 11;
kUseActiveLocale = 255;
}

enum HourFormatEnum : enum8 {
k12hr = 0;
k24hr = 1;
kUseActiveLocale = 255;
}

bitmap Feature : bitmap32 {
Expand Down
2 changes: 2 additions & 0 deletions examples/chef/devices/rootnode_pump_a811bb33a0.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,11 +365,13 @@ cluster TimeFormatLocalization = 44 {
kKorean = 9;
kPersian = 10;
kTaiwanese = 11;
kUseActiveLocale = 255;
}

enum HourFormatEnum : enum8 {
k12hr = 0;
k24hr = 1;
kUseActiveLocale = 255;
}

bitmap Feature : bitmap32 {
Expand Down
2 changes: 2 additions & 0 deletions ..._refrigerator_temperaturecontrolledcabinet_temperaturecontrolledcabinet_ffdb696680.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,11 +293,13 @@ cluster TimeFormatLocalization = 44 {
kKorean = 9;
kPersian = 10;
kTaiwanese = 11;
kUseActiveLocale = 255;
}

enum HourFormatEnum : enum8 {
k12hr = 0;
k24hr = 1;
kUseActiveLocale = 255;
}

bitmap Feature : bitmap32 {
Expand Down
2 changes: 2 additions & 0 deletions examples/chef/devices/rootnode_speaker_RpzeXdimqA.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,11 +665,13 @@ cluster TimeFormatLocalization = 44 {
kKorean = 9;
kPersian = 10;
kTaiwanese = 11;
kUseActiveLocale = 255;
}

enum HourFormatEnum : enum8 {
k12hr = 0;
k24hr = 1;
kUseActiveLocale = 255;
}

bitmap Feature : bitmap32 {
Expand Down
2 changes: 2 additions & 0 deletions examples/chef/devices/rootnode_temperaturesensor_Qy1zkNW7c3.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,11 +545,13 @@ cluster TimeFormatLocalization = 44 {
kKorean = 9;
kPersian = 10;
kTaiwanese = 11;
kUseActiveLocale = 255;
}

enum HourFormatEnum : enum8 {
k12hr = 0;
k24hr = 1;
kUseActiveLocale = 255;
}

bitmap Feature : bitmap32 {
Expand Down
Loading
Loading