-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove WeakEnums for Color Control Cluster
(and all weakenum handling as a result)
#30524
Merged
mergify
merged 15 commits into
project-chip:master
from
andy31415:color_control_remove_weak_enums
Nov 17, 2023
Merged
Remove WeakEnums for Color Control Cluster
(and all weakenum handling as a result)
#30524
mergify
merged 15 commits into
project-chip:master
from
andy31415:color_control_remove_weak_enums
Nov 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…move them from weak enums
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
November 16, 2023 19:14
PR #30524: Size comparison from 732d5e7 to 657d69b Full report (5 builds for cc32xx, mbed, qpg)
|
PR #30524: Size comparison from 732d5e7 to cad4f85 Full report (2 builds for cc32xx)
|
PR #30524: Size comparison from 732d5e7 to 31cad92 Increases (2 builds for nrfconnect)
Full report (8 builds for cc32xx, mbed, nrfconnect, qpg)
|
PR #30524: Size comparison from 732d5e7 to 2ca2a7d Increases (11 builds for esp32, linux, nrfconnect, psoc6, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Nov 17, 2023
arkq
approved these changes
Nov 17, 2023
github-actions
bot
added
platform
esp32
linux
controller
tizen
For Tizen platform
labels
Nov 17, 2023
andy31415
changed the title
Remove WeakEnums for
Remove WeakEnums for Nov 17, 2023
Color Control Cluster
Color Control Cluster
(and all weakenum handling as a result)
bzbarsky-apple
approved these changes
Nov 17, 2023
PR #30524: Size comparison from 523c19f to fce3055 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30524: Size comparison from 523c19f to 0ef8dd7 Increases (64 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (33 builds for bl602, bl702, bl702l, esp32, k32w, linux, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since these enumeration names are not yet defined by the spec, I placed the constants inside the C++ file.
Since this was the last weak-enum, I removed weak enum.h file globally.
Testing:
compiled:
linux-x64-all-clusters
linux-x64-light-no-ble-with-ui
tizen-arm-light
tizen-arm-light-with-ui