-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NetworkCommissioning]Add Encoding of the new NetworkCommisisoning attributes #30551
Merged
mergify
merged 9 commits into
project-chip:master
from
jmartinez-silabs:thread_capabilities
Nov 23, 2023
Merged
[NetworkCommissioning]Add Encoding of the new NetworkCommisisoning attributes #30551
mergify
merged 9 commits into
project-chip:master
from
jmartinez-silabs:thread_capabilities
Nov 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…function in the two related wirelessDrivers, Implement them for thread, provide default implementation for wifi
PR #30551: Size comparison from 30d622d to 4bbe276 Increases (39 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, psoc6, qpg)
Full report (42 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, psoc6, qpg)
|
PR #30551: Size comparison from 30d622d to 0782d99 Increases above 0.2%:
Increases (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (5 builds for linux, psoc6)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…rs out on conversion types. Assumed that it is due to how the type of a define vs enum is seeing on their platform
mkardous-silabs
approved these changes
Nov 17, 2023
PR #30551: Size comparison from 30d622d to 44f302d Increases above 0.2%:
Increases (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (5 builds for linux, psoc6)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
src/app/clusters/network-commissioning/network-commissioning.cpp
Outdated
Show resolved
Hide resolved
…pply original implementation GetSupportedThreadFeatures on Tizen, matching the other platforms implementation. Check featuremap before dereferencing mpDriver->Get
andy31415
reviewed
Nov 21, 2023
andy31415
reviewed
Nov 21, 2023
andy31415
reviewed
Nov 21, 2023
andy31415
reviewed
Nov 21, 2023
andy31415
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #30105
Add encoding for the new attributes
SupportedWiFiBands
,SupportedThreadFeatures
andThreadVersion
The respective NetworkCommissioning drivers (WiFiDriver or ThreadDriver) now have a virtual function to fetch the needed data.
Thread capabilities depend on your thread stack build configuration. Thread stack defines are not available in the matter stack so we use the Matter thread config definitions.
A default implementation is provided for the WiFiDriver
GetSupportedWiFiBands
virtual function, returning support for the 2.4 GHz band.Each different wifi platform should override this implementation and provide their complete band support in the
NetworkCommissiongWiFiiDriver
Edit:
I currently left
GetThreadVersion()
unimplemented (return 0) for the following platforms (Tizen, WebOS and Linux) as I found no information about Tizen thread stack APIs or how to use DBUS openthread.io for Linux/WebOs.#30602