-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ICD] Add Keep active during MDNS resolution ICD Check-In Sender #30552
Merged
jepenven-silabs
merged 3 commits into
project-chip:master
from
jepenven-silabs:icd_fix_active_request_checkin_sender
Nov 21, 2023
Merged
[ICD] Add Keep active during MDNS resolution ICD Check-In Sender #30552
jepenven-silabs
merged 3 commits into
project-chip:master
from
jepenven-silabs:icd_fix_active_request_checkin_sender
Nov 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
app
tests
icd
Intermittently Connected Devices
messaging
labels
Nov 17, 2023
jepenven-silabs
force-pushed
the
icd_fix_active_request_checkin_sender
branch
from
November 17, 2023 16:16
75c0b25
to
3798404
Compare
jepenven-silabs
changed the title
[ICD] Fix Keep active during MDNS resolution ICD Check-In Sender
[ICD] Add Keep active during MDNS resolution ICD Check-In Sender
Nov 17, 2023
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel and
ksperling-apple
November 17, 2023 16:18
pullapprove
bot
requested review from
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
November 17, 2023 16:18
jepenven-silabs
force-pushed
the
icd_fix_active_request_checkin_sender
branch
from
November 17, 2023 16:20
3798404
to
41366a9
Compare
PR #30552: Size comparison from 30d622d to 41366a9 Increases (12 builds for qpg, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30552: Size comparison from 30d622d to b317ed0 Increases (14 builds for linux, qpg, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
mkardous-silabs
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- LGTM after the last comment
jmartinez-silabs
approved these changes
Nov 17, 2023
bzbarsky-apple
approved these changes
Nov 18, 2023
PR #30552: Size comparison from 30d622d to 57c2ba8 Increases above 0.2%:
Increases (30 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, k32w, linux, mbed, nrfconnect, qpg)
Decreases (2 builds for linux)
Full report (30 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, k32w, linux, mbed, nrfconnect, qpg)
|
mkardous-silabs
approved these changes
Nov 20, 2023
jepenven-silabs
force-pushed
the
icd_fix_active_request_checkin_sender
branch
from
November 20, 2023 14:11
57c2ba8
to
1419503
Compare
PR #30552: Size comparison from d2ba2fc to 1419503 Increases (12 builds for qpg, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jepenven-silabs
force-pushed
the
icd_fix_active_request_checkin_sender
branch
from
November 21, 2023 13:44
1419503
to
c5a1f12
Compare
andy31415
approved these changes
Nov 21, 2023
PR #30552: Size comparison from a3c5d19 to c5a1f12 Increases (12 builds for qpg, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
DamMicSzm
pushed a commit
to DamMicSzm/connectedhomeip
that referenced
this pull request
Nov 30, 2023
…ject-chip#30552) * Fix 30492 * apply comments * fix last comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Keep Active during MDNS resolution
Fix #30492
Breakout of PR #30526 to speed up review and merge.
Also remove Message layer dependency on the ICDManager.