[dns-sd] Untangle dependencies between Resolver and ResolverProxy #30563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
pullapprove
bot
requested review from
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yufengwangca
|
PR #30563: Size comparison from 64a6594 to 21bf84e Increases (26 builds for bl602, bl702, cc32xx, efr32, esp32, linux, mbed, nrfconnect, psoc6)
Decreases (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, qpg, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Nov 20, 2023
The relationship between Resolver and Resolver Proxy is unclear as both classes depend on each other and Resolver Proxy is implemented in a source file of concrete Resolver implementation. This makes it impossible to build Matter library with several Resolver implementations and select one to be used at runtime. The main reason for introducing Resolver Proxy was the need for running multiple parallel DNS-SD queries. Address this by adding Discovery Delegate parameter to the Resolver interface methods for starting and stopping the discovery. Then implement Resolver Proxy as a convenience class on top of the Resolver interface. Additionally, simplify the Commissionable Node Controller class by injecting a test Resolver into Resolver Proxy.
Damian-Nordic
force-pushed
the
resolver-proxy
branch
from
21bf84e to
b3a4e07
Compare
|
PR #30563: Size comparison from a3c5d19 to b3a4e07 Increases (26 builds for bl602, bl702, cc32xx, efr32, esp32, linux, mbed, nrfconnect, psoc6)
Decreases (58 builds for bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, nrfconnect, qpg, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The relationship between Resolver and Resolver Proxy is unclear as both classes depend on each other and Resolver Proxy is implemented in a source file of concrete Resolver implementation. This makes it impossible to build Matter library with several Resolver implementations and select one to be used at runtime.
The main reason for introducing Resolver Proxy was the need for running multiple parallel DNS-SD queries. Address this by adding Discovery Delegate parameter to the Resolver interface methods for starting and stopping the discovery.
Then implement Resolver Proxy as a convenience class on top of the Resolver interface. Additionally, simplify the Commissionable Node Controller class by injecting a test Resolver into Resolver Proxy.
This change is sort of aligned with #29264 that removed the usage of
ResolverProxyfrom the operational discovery path.