-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove resource monitoring example, add air quality to build scripts #30587
Merged
mergify
merged 4 commits into
project-chip:master
from
cecille:add_resmon_and_aq_to_build_examples
Nov 23, 2023
Merged
Remove resource monitoring example, add air quality to build scripts #30587
mergify
merged 4 commits into
project-chip:master
from
cecille:add_resmon_and_aq_to_build_examples
Nov 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resource monitoring and air quality both have linux impls, but weren't in the script.
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mhazley and
mkardous-silabs
November 20, 2023 23:01
pullapprove
bot
requested review from
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
November 20, 2023 23:01
PR #30587: Size comparison from a3c5d19 to d5f181b Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Per offline discussion, the resource monitoring app is no longer used and is superceded by the air purifier app.
github-actions
bot
added
documentation
Improvements or additions to documentation
examples
github
workflows
labels
Nov 21, 2023
cecille
changed the title
build_examples: Add new host apps
Remove resource monitoring example, add air quality to build scripts
Nov 21, 2023
PR #30587: Size comparison from a3c5d19 to e796715 Increases above 0.2%:
Increases (23 builds for cyw30739, esp32, linux, nrfconnect, psoc6, qpg, telink)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
arkq
approved these changes
Nov 22, 2023
andy31415
approved these changes
Nov 23, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
examples
github
review - approved
scripts
workflows
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per an offline discussion with Matt and Tobias, the resource monitoring app was originally used for testing, but is now more properly tested in the air purifier app.
Also adds air quality to the build examples because I was in there, and it was missing.