Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CommandSender to support sending batch commands #30675

Merged
merged 22 commits into from
Dec 6, 2023
Merged

Update CommandSender to support sending batch commands #30675

merged 22 commits into from
Dec 6, 2023

Conversation

tehampson
Copy link
Contributor

This is a Matter 1.3 feature. Currently this allows sending batch commands to remote peer that support it.

This PR is completed up to the point it is so that we have this feature in for FC date. But we will continue to work on follow up as more bug fixes to this feature that way we make it in time for 1.3 release

Work still remaining that will be complete in a follow up PR:

  • Capable of processing InvokeResponse with MoreChunkedMessages set to true

Test:

tehampson
tehampson commented Nov 27, 2023
View reviewed changes
src/app/CommandSender.h Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 30, 2023 •
edited
Loading

PR #30675: Size comparison from ce4befc to a5f3046

Increases above 0.2%:

platform target config section ce4befc a5f3046 change % change
linux chip-tool debug (read only) 10914625 10973921 59296 0.5
.text 9869571 9928867 59296 0.6
chip-tool-ipv6only arm64 (read only) 10746632 10810840 64208 0.6
.text 9601096 9665256 64160 0.7
tv-casting-app debug (read only) 8861289 8918553 57264 0.6
.text 8079203 8136467 57264 0.7
Increases (51 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
platform target config section ce4befc a5f3046 change % change
bl602 lighting-app bl602 (read/write) 1412798 1413590 792 0.1
.text 1080678 1081470 792 0.1
bl602+mfd (read/write) 1427254 1428046 792 0.1
.text 1096042 1096834 792 0.1
bl602+rpc (read/write) 1460574 1461110 536 0.0
.text 1112422 1112958 536 0.0
bl702 lighting-app bl702 (read/write) 1177487 1178023 536 0.0
.text 950082 950618 536 0.1
bl702+mfd (read/write) 1188355 1189147 792 0.1
.text 961890 962682 792 0.1
bl702+rpc (read/write) 1277299 1278091 792 0.1
.text 1024888 1025680 792 0.1
bl706-eth (read/write) 997453 997989 536 0.1
.text 743318 743854 536 0.1
bl706-wifi (read/write) 1233746 1234586 840 0.1
.text 968778 969618 840 0.1
bl702l lighting-app bl702l (read/write) 1147692 1147716 24 0.0
.text 943172 943708 536 0.1
bl702l+mfd (read/write) 1158384 1159176 792 0.1
.text 955292 956084 792 0.1
cc13x4_26x4 pump-app LP_EM_CC1354P10_6 (read only) 699691 699755 64 0.0
.text 618884 618948 64 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 685195 685259 64 0.0
.text 608556 608620 64 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 560487 560911 424 0.1
.app_xip_area 450777 451201 424 0.1
lock cyw930739m2evb_01 (read/write) 542535 542959 424 0.1
.app_xip_area 428089 428513 424 0.1
ota-requestor cyw930739m2evb_01 (read/write) 561375 561791 416 0.1
.app_xip_area 453121 453537 416 0.1
switch cyw930739m2evb_01 (read/write) 556583 557207 624 0.1
.app_xip_area 445097 445721 624 0.1
efr32 lighting-app BRD4161A+rs9116 (read/write) 1015560 1016264 704 0.1
.text 840280 840984 704 0.1
BRD4187C (read/write) 1100168 1100592 424 0.0
.text 900676 901100 424 0.0
lock-app BRD4161A+wf200 (read/write) 1112840 1113256 416 0.0
.text 921484 921900 416 0.0
window-app BRD4187C (read/write) 1134444 1135148 704 0.1
.text 963048 963752 704 0.1
esp32 all-clusters-app c3devkit (read only) 1135794 1136136 342 0.0
.flash.text 1135794 1136136 342 0.0
m5stack (read only) 1181111 1181455 344 0.0
.flash.text 1175727 1176071 344 0.0
k32w contact k32w0+release (read only) 594196 594628 432 0.1
.text 593660 594092 432 0.1
k32w1+release (read/write) 689844 690268 424 0.1
.text 576072 576496 424 0.1
light k32w0+release (read only) 593916 594348 432 0.1
.text 593380 593812 432 0.1
k32w1+release (read/write) 781688 782120 432 0.1
.text 659048 659480 432 0.1
linux all-clusters-app debug (read only) 5348313 5351097 2784 0.1
.text 4650147 4652931 2784 0.1
all-clusters-minimal-app debug (read only) 4942313 4945113 2800 0.1
.text 4439043 4441843 2800 0.1
chip-tool debug (read only) 10914625 10973921 59296 0.5
.text 9869571 9928867 59296 0.6
chip-tool-ipv6only arm64 (read only) 10746632 10810840 64208 0.6
(read/write) 539560 540872 1312 0.2
.data.rel.ro 405856 405904 48 0.0
.text 9601096 9665256 64160 0.7
ota-requestor-app debug (read only) 4249097 4252025 2928 0.1
.text 3848259 3851187 2928 0.1
shell debug (read only) 2776137 2776665 528 0.0
.text 2424546 2425074 528 0.0
thermostat-no-ble arm64 (read only) 4400000 4400400 400 0.0
.text 3897880 3898280 400 0.0
tv-app debug (read only) 5297785 5303193 5408 0.1
.text 4794259 4799667 5408 0.1
tv-casting-app debug (read only) 8861289 8918553 57264 0.6
.text 8079203 8136467 57264 0.7
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1060448 1060768 320 0.0
text 779568 779896 328 0.0
nrf7002dk_nrf5340_cpuapp (read/write) 1186976 1187408 432 0.0
text 777104 777532 428 0.1
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1045552 1046000 448 0.0
text 769208 769656 448 0.1
psoc6 all-clusters cy8ckit_062s2_43012 (read/write) 1740868 1740932 64 0.0
.text 1535364 1535428 64 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1704564 1704628 64 0.0
.text 1500772 1500836 64 0.0
qpg lighting-app qpg6105+debug (read/write) 1115780 1116204 424 0.0
.text 628160 628584 424 0.1
lock-app qpg6105+debug (read/write) 1079060 1079508 448 0.0
.text 591436 591884 448 0.1
telink all-clusters-app tlsr9518adk80d (read/write) 1077328 1077664 336 0.0
text 760044 760378 334 0.0
all-clusters-minimal-app tlsr9528a (read/write) 1082012 1082348 336 0.0
text 751594 751928 334 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read/write) 976152 976720 568 0.1
text 692048 692616 568 0.1
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read/write) 1091644 1092076 432 0.0
text 768468 768898 430 0.1
ota-requestor-app tlsr9518adk80d (read/write) 946968 947392 424 0.0
text 661674 662104 430 0.1
pump-app tlsr9528a (read/write) 878292 878380 88 0.0
text 620396 620478 82 0.0
pump-controller-app tlsr9518adk80d (read/write) 818904 818984 80 0.0
text 587272 587354 82 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read/write) 875697 876129 432 0.0
text 628712 629142 430 0.1
thermostat tlsr9518adk80d (read/write) 843116 843196 80 0.0
text 605598 605680 82 0.0
Decreases (1 build for linux)
platform target config section ce4befc a5f3046 change % change
linux thermostat-no-ble arm64 (read/write) 246400 246000 -400 -0.2
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section ce4befc a5f3046 change % change
bl602 lighting-app bl602 (read/write) 1412798 1413590 792 0.1
.bss 85160 85160 0 0.0
.data 9376 9376 0 0.0
.rodata 156932 156932 0 0.0
.text 1080678 1081470 792 0.1
bl602+mfd (read/write) 1427254 1428046 792 0.1
.bss 85328 85328 0 0.0
.data 9344 9344 0 0.0
.rodata 155892 155892 0 0.0
.text 1096042 1096834 792 0.1
bl602+rpc (read/write) 1460574 1461110 536 0.0
.bss 93192 93192 0 0.0
.data 9744 9744 0 0.0
.rodata 164548 164548 0 0.0
.text 1112422 1112958 536 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1177487 1178023 536 0.0
.bss 11197 11197 0 0.0
.data 3560 3560 0 0.0
.rodata 106304 106304 0 0.0
.text 950082 950618 536 0.1
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1188355 1189147 792 0.1
.bss 11373 11373 0 0.0
.data 3536 3536 0 0.0
.rodata 105244 105244 0 0.0
.text 961890 962682 792 0.1
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1277299 1278091 792 0.1
.bss 19677 19677 0 0.0
.data 4112 4112 0 0.0
.rodata 121720 121720 0 0.0
.text 1024888 1025680 792 0.1
bl706-eth (read/write) 997453 997989 536 0.1
.bss 23772 23772 0 0.0
.data 3128 3128 0 0.0
.rodata 99644 99644 0 0.0
.text 743318 743854 536 0.1
bl706-wifi (read/write) 1233746 1234586 840 0.1
.bss 10641 10641 0 0.0
.data 3568 3568 0 0.0
.rodata 120616 120616 0 0.0
.text 968778 969618 840 0.1
bl702l lighting-app bl702l (read/write) 1147692 1147716 24 0.0
.bss 16392 16392 0 0.0
.data 4920 4920 0 0.0
.rodata 100308 100308 0 0.0
.text 943172 943708 536 0.1
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1158384 1159176 792 0.1
.bss 16568 16568 0 0.0
.data 4904 4904 0 0.0
.rodata 99248 99248 0 0.0
.text 955292 956084 792 0.1
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 742059 742059 0 0.0
(read/write) 167112 167112 0 0.0
.bss 89524 89524 0 0.0
.data 3424 3424 0 0.0
.rodata 84647 84647 0 0.0
.text 657020 657020 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 759235 759235 0 0.0
(read/write) 177356 177356 0 0.0
.bss 99708 99708 0 0.0
.data 3452 3452 0 0.0
.rodata 79727 79727 0 0.0
.text 679116 679116 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 746171 746171 0 0.0
(read/write) 171804 171804 0 0.0
.bss 94156 94156 0 0.0
.data 3452 3452 0 0.0
.rodata 105487 105487 0 0.0
.text 640296 640296 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 699691 699755 64 0.0
(read/write) 166124 166124 0 0.0
.bss 88304 88304 0 0.0
.data 3412 3412 0 0.0
.rodata 80415 80415 0 0.0
.text 618884 618948 64 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 685195 685259 64 0.0
(read/write) 166288 166288 0 0.0
.bss 88480 88480 0 0.0
.data 3408 3408 0 0.0
.rodata 76247 76247 0 0.0
.text 608556 608620 64 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 566458 566458 0 0.0
(read/write) 207624 207624 0 0.0
.bss 201084 201084 0 0.0
.data 1416 1416 0 0.0
.rodata 83930 83930 0 0.0
.text 480404 480404 0 0.0
lock CC3235SF_LAUNCHXL (read only) 619706 619706 0 0.0
(read/write) 208020 208020 0 0.0
.bss 201448 201448 0 0.0
.data 1452 1452 0 0.0
.rodata 105802 105802 0 0.0
.text 511784 511784 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 560487 560911 424 0.1
.app_xip_area 450777 451201 424 0.1
.bss 64624 64624 0 0.0
.data 664 664 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 542535 542959 424 0.1
.app_xip_area 428089 428513 424 0.1
.bss 69320 69320 0 0.0
.data 704 704 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 561375 561791 416 0.1
.app_xip_area 453121 453537 416 0.1
.bss 63240 63240 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 556583 557207 624 0.1
.app_xip_area 445097 445721 624 0.1
.bss 66360 66360 0 0.0
.data 700 700 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1015560 1016264 704 0.1
.bss 172568 172568 0 0.0
.data 2692 2692 0 0.0
.text 840280 840984 704 0.1
BRD4187C (read/write) 1100168 1100592 424 0.0
.bss 196172 196172 0 0.0
.data 3300 3300 0 0.0
.text 900676 901100 424 0.0
lock-app BRD4161A+wf200 (read/write) 1112840 1113256 416 0.0
.bss 188616 188616 0 0.0
.data 2716 2716 0 0.0
.text 921484 921900 416 0.0
window-app BRD4187C (read/write) 1134444 1135148 704 0.1
.bss 168204 168204 0 0.0
.data 3172 3172 0 0.0
.text 963048 963752 704 0.1
esp32 all-clusters-app c3devkit (read only) 1135794 1136136 342 0.0
(read/write) 1671268 1671268 0 0.0
.dram0.bss 72544 72544 0 0.0
.dram0.data 12996 12996 0 0.0
.flash.rodata 241856 241856 0 0.0
.flash.text 1135794 1136136 342 0.0
.iram0.text 75694 75694 0 0.0
m5stack (read only) 1181111 1181455 344 0.0
(read/write) 520880 520880 0 0.0
.dram0.bss 79184 79184 0 0.0
.dram0.data 34020 34020 0 0.0
.flash.rodata 273312 273312 0 0.0
.flash.text 1175727 1176071 344 0.0
.iram0.text 123907 123907 0 0.0
k32w contact k32w0+release (read only) 594196 594628 432 0.1
(read/write) 88132 88132 0 0.0
.bss 71376 71376 0 0.0
.data 2132 2132 0 0.0
.text 593660 594092 432 0.1
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 689844 690268 424 0.1
.bss 67576 67576 0 0.0
.data 2720 2720 0 0.0
.text 576072 576496 424 0.1
light k32w0+release (read only) 593916 594348 432 0.1
(read/write) 87808 87808 0 0.0
.bss 71064 71064 0 0.0
.data 2120 2120 0 0.0
.text 593380 593812 432 0.1
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 781688 782120 432 0.1
.bss 77252 77252 0 0.0
.data 1932 1932 0 0.0
.text 659048 659480 432 0.1
lock k32w0+release (read only) 565692 565692 0 0.0
(read/write) 85604 85604 0 0.0
.bss 68920 68920 0 0.0
.data 2060 2060 0 0.0
.text 565156 565156 0 0.0
linux air-purifier-app debug (read only) 2523597 2523597 0 0.0
(read/write) 127176 127176 0 0.0
.bss 46944 46944 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 72760 72760 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 178856 178856 0 0.0
.text 2169429 2169429 0 0.0
all-clusters-app debug (read only) 5348313 5351097 2784 0.1
(read/write) 435904 435904 0 0.0
.bss 130064 130064 0 0.0
.data 3856 3856 0 0.0
.data.rel.ro 294752 294752 0 0.0
.dynamic 624 624 0 0.0
.got 5352 5352 0 0.0
.init 27 27 0 0.0
.init_array 1224 1224 0 0.0
.rodata 304476 304476 0 0.0
.text 4650147 4652931 2784 0.1
all-clusters-minimal-app debug (read only) 4942313 4945113 2800 0.1
(read/write) 234592 234592 0 0.0
.bss 127856 127856 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 95824 95824 0 0.0
.dynamic 624 624 0 0.0
.got 5312 5312 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 270989 270989 0 0.0
.text 4439043 4441843 2800 0.1
bridge-app debug (read only) 4413329 4413329 0 0.0
(read/write) 215864 215864 0 0.0
.bss 119224 119224 0 0.0
.data 4704 4704 0 0.0
.data.rel.ro 85200 85200 0 0.0
.dynamic 624 624 0 0.0
.got 5280 5280 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 218645 218645 0 0.0
.text 3976179 3976179 0 0.0
chip-tool debug (read only) 10914625 10973921 59296 0.5
(read/write) 473928 473928 0 0.0
.bss 94072 94072 0 0.0
.data 4994 4994 0 0.0
.data.rel.ro 367624 367624 0 0.0
.dynamic 624 624 0 0.0
.got 5784 5784 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 404297 404297 0 0.0
.text 9869571 9928867 59296 0.6
chip-tool-ipv6only arm64 (read only) 10746632 10810840 64208 0.6
(read/write) 539560 540872 1312 0.2
.bss 103352 103352 0 0.0
.data 4296 4296 0 0.0
.data.rel.ro 405856 405904 48 0.0
.dynamic 512 512 0 0.0
.got 19056 19056 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 329616 329616 0 0.0
.text 9601096 9665256 64160 0.7
lighting-app debug+rpc+ui (read only) 5298825 5298825 0 0.0
(read/write) 224936 224936 0 0.0
.bss 119360 119360 0 0.0
.data 4416 4416 0 0.0
.data.rel.ro 93616 93616 0 0.0
.dynamic 672 672 0 0.0
.got 5896 5896 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 339860 339860 0 0.0
.text 4714243 4714243 0 0.0
lock-app debug (read only) 4499025 4499025 0 0.0
(read/write) 203584 203584 0 0.0
.bss 113760 113760 0 0.0
.data 3648 3648 0 0.0
.data.rel.ro 79432 79432 0 0.0
.dynamic 624 624 0 0.0
.got 5232 5232 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 246645 246645 0 0.0
.text 4042435 4042435 0 0.0
ota-provider-app debug (read only) 4162697 4162697 0 0.0
(read/write) 192696 192696 0 0.0
.bss 113632 113632 0 0.0
.data 3920 3920 0 0.0
.data.rel.ro 69216 69216 0 0.0
.dynamic 624 624 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 200917 200917 0 0.0
.text 3769971 3769971 0 0.0
ota-requestor-app debug (read only) 4249097 4252025 2928 0.1
(read/write) 196912 196912 0 0.0
.bss 114656 114656 0 0.0
.data 4192 4192 0 0.0
.data.rel.ro 72176 72176 0 0.0
.dynamic 624 624 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 204725 204725 0 0.0
.text 3848259 3851187 2928 0.1
shell debug (read only) 2776137 2776665 528 0.0
(read/write) 149792 149792 0 0.0
.bss 60616 60616 0 0.0
.data 784 784 0 0.0
.data.rel.ro 82584 82584 0 0.0
.dynamic 592 592 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 180928 180928 0 0.0
.text 2424546 2425074 528 0.0
thermostat-no-ble arm64 (read only) 4400000 4400400 400 0.0
(read/write) 246400 246000 -400 -0.2
.bss 122232 122232 0 0.0
.data 2800 2800 0 0.0
.data.rel.ro 102288 102288 0 0.0
.dynamic 512 512 0 0.0
.got 11944 11944 0 0.0
.init 24 24 0 0.0
.init_array 424 424 0 0.0
.rodata 161996 161996 0 0.0
.text 3897880 3898280 400 0.0
tv-app debug (read only) 5297785 5303193 5408 0.1
(read/write) 345392 345392 0 0.0
.bss 242592 242592 0 0.0
.data 4992 4992 0 0.0
.data.rel.ro 90504 90504 0 0.0
.dynamic 624 624 0 0.0
.got 5520 5520 0 0.0
.init 27 27 0 0.0
.init_array 1128 1128 0 0.0
.rodata 268501 268501 0 0.0
.text 4794259 4799667 5408 0.1
tv-casting-app debug (read only) 8861289 8918553 57264 0.6
(read/write) 325304 325304 0 0.0
.bss 156192 156192 0 0.0
.data 2464 2464 0 0.0
.data.rel.ro 159816 159816 0 0.0
.dynamic 624 624 0 0.0
.got 5064 5064 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 350920 350920 0 0.0
.text 8079203 8136467 57264 0.7
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2525472 2525472 0 0.0
.bss 220184 220184 0 0.0
.data 5144 5144 0 0.0
.text 1488156 1488156 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1060448 1060768 320 0.0
bss 129029 129029 0 0.0
rodata 104176 104176 0 0.0
text 779568 779896 328 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1186976 1187408 432 0.0
bss 121239 121239 0 0.0
rodata 138304 138304 0 0.0
text 777104 777532 428 0.1
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1045552 1046000 448 0.0
bss 129316 129316 0 0.0
rodata 99352 99352 0 0.0
text 769208 769656 448 0.1
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 836224 836224 0 0.0
(read/write) 1740868 1740932 64 0.0
.bss 194644 194644 0 0.0
.data 2472 2472 0 0.0
.text 1535364 1535428 64 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 837936 837936 0 0.0
(read/write) 1704564 1704628 64 0.0
.bss 192924 192924 0 0.0
.data 2480 2480 0 0.0
.text 1500772 1500836 64 0.0
light cy8ckit_062s2_43012 (read only) 844624 844624 0 0.0
(read/write) 1630268 1630268 0 0.0
.bss 186348 186348 0 0.0
.data 2368 2368 0 0.0
.text 1433164 1433164 0 0.0
lock cy8ckit_062s2_43012 (read only) 817504 817504 0 0.0
(read/write) 1657164 1657164 0 0.0
.bss 213444 213444 0 0.0
.data 2392 2392 0 0.0
.text 1432940 1432940 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1115780 1116204 424 0.0
.bss 101200 101200 0 0.0
.data 744 744 0 0.0
.text 628160 628584 424 0.1
lock-app qpg6105+debug (read/write) 1079060 1079508 448 0.0
.bss 97328 97328 0 0.0
.data 788 788 0 0.0
.text 591436 591884 448 0.1
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 821818 821818 0 0.0
bss 55036 55036 0 0.0
text 613784 613784 0 0.0
all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1077328 1077664 336 0.0
bss 100072 100072 0 0.0
text 760044 760378 334 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1082012 1082348 336 0.0
bss 109764 109764 0 0.0
text 751594 751928 334 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 933696 933696 0 0.0
bss 94272 94272 0 0.0
text 645944 645944 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 822002 822002 0 0.0
bss 55088 55088 0 0.0
text 614076 614076 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 4 4 0 0.0
(read/write) 976152 976720 568 0.1
bss 78932 78932 0 0.0
text 692048 692616 568 0.1
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1091644 1092076 432 0.0
bss 99836 99836 0 0.0
text 768468 768898 430 0.1
lock-app-dfu tlsr9528a (read only) 4 4 0 0.0
(read/write) 962868 962868 0 0.0
bss 97196 97196 0 0.0
text 646186 646186 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 946968 947392 424 0.0
bss 92380 92380 0 0.0
text 661674 662104 430 0.1
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 878292 878380 88 0.0
bss 68924 68924 0 0.0
text 620396 620478 82 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 818904 818984 80 0.0
bss 57160 57160 0 0.0
text 587272 587354 82 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 705404 705404 0 0.0
bss 73588 73588 0 0.0
text 461922 461922 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 823654 823654 0 0.0
bss 55216 55216 0 0.0
text 616746 616746 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 875697 876129 432 0.0
bss 60636 60636 0 0.0
text 628712 629142 430 0.1
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 843116 843196 80 0.0
bss 57456 57456 0 0.0
text 605598 605680 82 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 837616 837616 0 0.0
bss 57808 57808 0 0.0
text 599826 599826 0 0.0

andy31415
andy31415 approved these changes Dec 4, 2023
View reviewed changes
src/app/CommandSender.cpp Outdated Show resolved Hide resolved
src/app/CommandSender.cpp Outdated Show resolved Hide resolved
src/app/CommandSender.h Outdated Show resolved Hide resolved
src/app/CommandSender.h Outdated Show resolved Hide resolved
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 4, 2023
bzbarsky-apple
bzbarsky-apple reviewed Dec 5, 2023
View reviewed changes
src/app/CommandSender.cpp Outdated Show resolved Hide resolved
src/app/CommandSender.h Outdated Show resolved Hide resolved
src/app/CommandSender.h Outdated Show resolved Hide resolved
src/app/CommandSender.h Show resolved Hide resolved
src/app/CommandSender.h Outdated Show resolved Hide resolved
src/app/CommandSender.h Outdated Show resolved Hide resolved
src/app/CommandSender.h Outdated Show resolved Hide resolved
src/app/CommandSender.h Outdated Show resolved Hide resolved
src/app/CommandSender.h Outdated Show resolved Hide resolved
src/app/tests/TestCommandInteraction.cpp Show resolved Hide resolved
bzbarsky-apple
bzbarsky-apple reviewed Dec 6, 2023
View reviewed changes
src/app/CommandSender.h Outdated Show resolved Hide resolved
src/app/CommandSender.h Outdated Show resolved Hide resolved
src/app/CommandSender.h Outdated Show resolved Hide resolved
src/app/CommandSender.h Outdated Show resolved Hide resolved
src/app/CommandSender.h Outdated Show resolved Hide resolved
src/app/CommandSender.h Outdated Show resolved Hide resolved
src/app/tests/TestCommandInteraction.cpp Outdated Show resolved Hide resolved
src/app/tests/TestCommandInteraction.cpp Show resolved Hide resolved
src/app/tests/TestCommandInteraction.cpp Show resolved Hide resolved
src/app/tests/TestCommandInteraction.cpp Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023 •
edited
Loading

PR #30675: Size comparison from 360ab99 to 1ce2e71

Increases above 0.2%:

platform target config section 360ab99 1ce2e71 change % change
linux chip-tool debug (read only) 11369345 11424217 54872 0.5
(read/write) 493736 496040 2304 0.5
.data.rel.ro 387448 389728 2280 0.6
.text 10280739 10328723 47984 0.5
chip-tool-ipv6only arm64 (read only) 11102432 11145632 43200 0.4
(read/write) 560560 562440 1880 0.3
.data.rel.ro 426120 428464 2344 0.6
.text 9913832 9950104 36272 0.4
tv-casting-app debug (read only) 9285297 9335929 50632 0.5
(read/write) 332632 334840 2208 0.7
.data.rel.ro 167128 169336 2208 1.3
.text 8476515 8520547 44032 0.5
Increases (51 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
platform target config section 360ab99 1ce2e71 change % change
bl602 lighting-app bl602 (read/write) 1413674 1414202 528 0.0
.rodata 156912 156928 16 0.0
.text 1081346 1081862 516 0.0
bl602+mfd (read/write) 1428138 1428674 536 0.0
.rodata 155872 155888 16 0.0
.text 1096710 1097226 516 0.0
bl602+rpc (read/write) 1461194 1461978 784 0.1
.rodata 164528 164544 16 0.0
.text 1112834 1113606 772 0.1
bl702 lighting-app bl702 (read/write) 1178359 1178891 532 0.0
.rodata 106284 106300 16 0.0
.text 950726 951242 516 0.1
bl702+mfd (read/write) 1189235 1189767 532 0.0
.rodata 105224 105240 16 0.0
.text 962534 963050 516 0.1
bl702+rpc (read/write) 1270115 1270647 532 0.0
.rodata 121704 121720 16 0.0
.text 1025532 1026048 516 0.1
bl706-eth (read/write) 998301 998833 532 0.1
.rodata 99616 99632 16 0.0
.text 743938 744454 516 0.1
bl706-wifi (read/write) 1234714 1235550 836 0.1
.rodata 120596 120612 16 0.0
.text 969510 970330 820 0.1
bl702l lighting-app bl702l (read/write) 1148064 1148596 532 0.0
.rodata 100288 100304 16 0.0
.text 943852 944368 516 0.1
bl702l+mfd (read/write) 1159260 1159792 532 0.0
.rodata 99228 99244 16 0.0
.text 955972 956488 516 0.1
cc13x4_26x4 pump-app LP_EM_CC1354P10_6 (read only) 699972 700036 64 0.0
.text 619124 619188 64 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 685476 685540 64 0.0
.text 608788 608852 64 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 560887 561247 360 0.1
.app_xip_area 451009 451369 360 0.1
lock cyw930739m2evb_01 (read/write) 542991 543351 360 0.1
.app_xip_area 428377 428737 360 0.1
ota-requestor cyw930739m2evb_01 (read/write) 561807 562167 360 0.1
.app_xip_area 453385 453745 360 0.1
switch cyw930739m2evb_01 (read/write) 557055 557527 472 0.1
.app_xip_area 445409 445881 472 0.1
efr32 lighting-app BRD4161A+rs9116 (read/write) 1016180 1016804 624 0.1
.text 840736 841360 624 0.1
BRD4187C (read/write) 1100588 1100956 368 0.0
.text 900932 901300 368 0.0
lock-app BRD4161A+wf200 (read/write) 1114040 1114400 360 0.0
.text 922436 922796 360 0.0
window-app BRD4187C (read/write) 1134800 1135432 632 0.1
.text 963240 963872 632 0.1
esp32 all-clusters-app c3devkit (read only) 1135772 1136118 346 0.0
(read/write) 1670732 1670740 8 0.0
.flash.rodata 241176 241184 8 0.0
.flash.text 1135772 1136118 346 0.0
m5stack (read only) 1180879 1181267 388 0.0
.flash.text 1175495 1175883 388 0.0
k32w contact k32w0+release (read only) 594520 594888 368 0.1
.text 593984 594352 368 0.1
k32w1+release (read/write) 690376 690736 360 0.1
.text 576432 576792 360 0.1
light k32w0+release (read only) 594240 594600 360 0.1
.text 593704 594064 360 0.1
k32w1+release (read/write) 782196 782564 368 0.0
.text 659392 659760 368 0.1
linux all-clusters-app debug (read only) 5361529 5364345 2816 0.1
.data.rel.ro 306552 306568 16 0.0
.text 4650131 4652899 2768 0.1
all-clusters-minimal-app debug (read only) 4946649 4949481 2832 0.1
.data.rel.ro 95960 95976 16 0.0
.text 4441395 4444179 2784 0.1
chip-tool debug (read only) 11369345 11424217 54872 0.5
(read/write) 493736 496040 2304 0.5
.data.rel.ro 387448 389728 2280 0.6
.text 10280739 10328723 47984 0.5
chip-tool-ipv6only arm64 (read only) 11102432 11145632 43200 0.4
(read/write) 560560 562440 1880 0.3
.data.rel.ro 426120 428464 2344 0.6
.text 9913832 9950104 36272 0.4
ota-requestor-app debug (read only) 4249873 4252897 3024 0.1
(read/write) 197008 197040 32 0.0
.data.rel.ro 72272 72304 32 0.0
.text 3848531 3851459 2928 0.1
shell debug (read only) 2776625 2777153 528 0.0
.text 2424850 2425378 528 0.0
thermostat-no-ble arm64 (read only) 4401152 4401568 416 0.0
.text 3898360 3898776 416 0.0
tv-app debug (read only) 5375385 5381577 6192 0.1
(read/write) 348864 348960 96 0.0
.data.rel.ro 92184 92280 96 0.1
.text 4865027 4870883 5856 0.1
tv-casting-app debug (read only) 9285297 9335929 50632 0.5
(read/write) 332632 334840 2208 0.7
.data.rel.ro 167128 169336 2208 1.3
.text 8476515 8520547 44032 0.5
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1060724 1061064 340 0.0
rodata 104196 104200 4 0.0
text 779700 780036 336 0.0
nrf7002dk_nrf5340_cpuapp (read/write) 1187284 1187664 380 0.0
rodata 138320 138332 12 0.0
text 777240 777608 368 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1046316 1046696 380 0.0
rodata 99452 99464 12 0.0
text 769752 770124 372 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read/write) 1741588 1741668 80 0.0
.text 1535652 1535732 80 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1705892 1705972 80 0.0
.text 1501676 1501756 80 0.0
qpg lighting-app qpg6105+debug (read/write) 1116132 1116508 376 0.0
.text 628508 628884 376 0.1
lock-app qpg6105+debug (read/write) 1079772 1080140 368 0.0
.text 592152 592520 368 0.1
telink all-clusters-app tlsr9518adk80d (read/write) 1077768 1078108 340 0.0
text 760296 760634 338 0.0
all-clusters-minimal-app tlsr9528a (read/write) 1083004 1083344 340 0.0
text 752306 752644 338 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read/write) 977148 977576 428 0.0
text 692694 693112 418 0.1
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read/write) 1092056 1092420 364 0.0
text 768696 769046 350 0.0
ota-requestor-app tlsr9518adk80d (read/write) 947376 947740 364 0.0
text 661902 662252 350 0.1
pump-app tlsr9528a (read/write) 879272 879352 80 0.0
text 621030 621112 82 0.0
pump-controller-app tlsr9518adk80d (read/write) 819876 819956 80 0.0
text 587906 587988 82 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read/write) 876661 877025 364 0.0
text 629334 629684 350 0.1
thermostat tlsr9518adk80d (read/write) 844088 844168 80 0.0
text 606232 606314 82 0.0
Decreases (1 build for linux)
platform target config section 360ab99 1ce2e71 change % change
linux thermostat-no-ble arm64 (read/write) 245264 244848 -416 -0.2
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 360ab99 1ce2e71 change % change
bl602 lighting-app bl602 (read/write) 1413674 1414202 528 0.0
.bss 85352 85352 0 0.0
.data 9416 9416 0 0.0
.rodata 156912 156928 16 0.0
.text 1081346 1081862 516 0.0
bl602+mfd (read/write) 1428138 1428674 536 0.0
.bss 85520 85520 0 0.0
.data 9384 9384 0 0.0
.rodata 155872 155888 16 0.0
.text 1096710 1097226 516 0.0
bl602+rpc (read/write) 1461194 1461978 784 0.1
.bss 93384 93384 0 0.0
.data 9784 9784 0 0.0
.rodata 164528 164544 16 0.0
.text 1112834 1113606 772 0.1
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1178359 1178891 532 0.0
.bss 11197 11197 0 0.0
.data 3584 3584 0 0.0
.rodata 106284 106300 16 0.0
.text 950726 951242 516 0.1
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1189235 1189767 532 0.0
.bss 11373 11373 0 0.0
.data 3568 3568 0 0.0
.rodata 105224 105240 16 0.0
.text 962534 963050 516 0.1
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1270115 1270647 532 0.0
.bss 19677 19677 0 0.0
.data 4144 4144 0 0.0
.rodata 121704 121720 16 0.0
.text 1025532 1026048 516 0.1
bl706-eth (read/write) 998301 998833 532 0.1
.bss 23772 23772 0 0.0
.data 3160 3160 0 0.0
.rodata 99616 99632 16 0.0
.text 743938 744454 516 0.1
bl706-wifi (read/write) 1234714 1235550 836 0.1
.bss 10641 10641 0 0.0
.data 3600 3600 0 0.0
.rodata 120596 120612 16 0.0
.text 969510 970330 820 0.1
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1148064 1148596 532 0.0
.bss 16392 16392 0 0.0
.data 4952 4952 0 0.0
.rodata 100288 100304 16 0.0
.text 943852 944368 516 0.1
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1159260 1159792 532 0.0
.bss 16568 16568 0 0.0
.data 4928 4928 0 0.0
.rodata 99228 99244 16 0.0
.text 955972 956488 516 0.1
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 742308 742308 0 0.0
(read/write) 167284 167284 0 0.0
.bss 89700 89700 0 0.0
.data 3420 3420 0 0.0
.rodata 84680 84680 0 0.0
.text 657236 657236 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 759492 759492 0 0.0
(read/write) 177512 177512 0 0.0
.bss 99876 99876 0 0.0
.data 3448 3448 0 0.0
.rodata 79744 79744 0 0.0
.text 679356 679356 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 746484 746484 0 0.0
(read/write) 171968 171968 0 0.0
.bss 94332 94332 0 0.0
.data 3448 3448 0 0.0
.rodata 105528 105528 0 0.0
.text 640568 640568 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 699972 700036 64 0.0
(read/write) 166288 166288 0 0.0
.bss 88480 88480 0 0.0
.data 3408 3408 0 0.0
.rodata 80456 80456 0 0.0
.text 619124 619188 64 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 685476 685540 64 0.0
(read/write) 166460 166460 0 0.0
.bss 88656 88656 0 0.0
.data 3404 3404 0 0.0
.rodata 76296 76296 0 0.0
.text 608788 608852 64 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 566762 566762 0 0.0
(read/write) 208052 208052 0 0.0
.bss 201516 201516 0 0.0
.data 1412 1412 0 0.0
.rodata 83938 83938 0 0.0
.text 480700 480700 0 0.0
lock CC3235SF_LAUNCHXL (read only) 620074 620074 0 0.0
(read/write) 208448 208448 0 0.0
.bss 201880 201880 0 0.0
.data 1448 1448 0 0.0
.rodata 105810 105810 0 0.0
.text 512140 512140 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 560887 561247 360 0.1
.app_xip_area 451009 451369 360 0.1
.bss 64792 64792 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 542991 543351 360 0.1
.app_xip_area 428377 428737 360 0.1
.bss 69488 69488 0 0.0
.data 700 700 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 561807 562167 360 0.1
.app_xip_area 453385 453745 360 0.1
.bss 63408 63408 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 557055 557527 472 0.1
.app_xip_area 445409 445881 472 0.1
.bss 66528 66528 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1016180 1016804 624 0.1
.bss 172736 172736 0 0.0
.data 2688 2688 0 0.0
.text 840736 841360 624 0.1
BRD4187C (read/write) 1100588 1100956 368 0.0
.bss 196340 196340 0 0.0
.data 3296 3296 0 0.0
.text 900932 901300 368 0.0
lock-app BRD4161A+wf200 (read/write) 1114040 1114400 360 0.0
.bss 188872 188872 0 0.0
.data 2712 2712 0 0.0
.text 922436 922796 360 0.0
window-app BRD4187C (read/write) 1134800 1135432 632 0.1
.bss 168372 168372 0 0.0
.data 3168 3168 0 0.0
.text 963240 963872 632 0.1
esp32 all-clusters-app c3devkit (read only) 1135772 1136118 346 0.0
(read/write) 1670732 1670740 8 0.0
.dram0.bss 72704 72704 0 0.0
.dram0.data 12988 12988 0 0.0
.flash.rodata 241176 241184 8 0.0
.flash.text 1135772 1136118 346 0.0
.iram0.text 75694 75694 0 0.0
m5stack (read only) 1180879 1181267 388 0.0
(read/write) 519928 519928 0 0.0
.dram0.bss 79360 79360 0 0.0
.dram0.data 34004 34004 0 0.0
.flash.rodata 272200 272200 0 0.0
.flash.text 1175495 1175883 388 0.0
.iram0.text 123907 123907 0 0.0
k32w contact k32w0+release (read only) 594520 594888 368 0.1
(read/write) 88296 88296 0 0.0
.bss 71544 71544 0 0.0
.data 2128 2128 0 0.0
.text 593984 594352 368 0.1
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 690376 690736 360 0.1
.bss 67752 67752 0 0.0
.data 2716 2716 0 0.0
.text 576432 576792 360 0.1
light k32w0+release (read only) 594240 594600 360 0.1
(read/write) 87972 87972 0 0.0
.bss 71232 71232 0 0.0
.data 2116 2116 0 0.0
.text 593704 594064 360 0.1
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 782196 782564 368 0.0
.bss 77420 77420 0 0.0
.data 1928 1928 0 0.0
.text 659392 659760 368 0.1
lock k32w0+release (read only) 566008 566008 0 0.0
(read/write) 85768 85768 0 0.0
.bss 69088 69088 0 0.0
.data 2056 2056 0 0.0
.text 565472 565472 0 0.0
linux air-purifier-app debug (read only) 2524421 2524421 0 0.0
(read/write) 127240 127240 0 0.0
.bss 46944 46944 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 72840 72840 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 179240 179240 0 0.0
.text 2169749 2169749 0 0.0
all-clusters-app debug (read only) 5361529 5364345 2816 0.1
(read/write) 447680 447680 0 0.0
.bss 130064 130064 0 0.0
.data 3840 3840 0 0.0
.data.rel.ro 306552 306568 16 0.0
.dynamic 624 624 0 0.0
.got 5352 5352 0 0.0
.init 27 27 0 0.0
.init_array 1224 1224 0 0.0
.rodata 307964 307964 0 0.0
.text 4650131 4652899 2768 0.1
all-clusters-minimal-app debug (read only) 4946649 4949481 2832 0.1
(read/write) 234720 234720 0 0.0
.bss 127856 127856 0 0.0
.data 3776 3776 0 0.0
.data.rel.ro 95960 95976 16 0.0
.dynamic 624 624 0 0.0
.got 5312 5312 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 272781 272781 0 0.0
.text 4441395 4444179 2784 0.1
bridge-app debug (read only) 4414201 4414201 0 0.0
(read/write) 215960 215960 0 0.0
.bss 119224 119224 0 0.0
.data 4704 4704 0 0.0
.data.rel.ro 85296 85296 0 0.0
.dynamic 624 624 0 0.0
.got 5280 5280 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 219125 219125 0 0.0
.text 3976451 3976451 0 0.0
chip-tool debug (read only) 11369345 11424217 54872 0.5
(read/write) 493736 496040 2304 0.5
.bss 94072 94072 0 0.0
.data 4994 4994 0 0.0
.data.rel.ro 387448 389728 2280 0.6
.dynamic 624 624 0 0.0
.got 5784 5784 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 418281 418281 0 0.0
.text 10280739 10328723 47984 0.5
chip-tool-ipv6only arm64 (read only) 11102432 11145632 43200 0.4
(read/write) 560560 562440 1880 0.3
.bss 103352 103352 0 0.0
.data 4280 4280 0 0.0
.data.rel.ro 426120 428464 2344 0.6
.dynamic 512 512 0 0.0
.got 19600 19600 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 341016 341016 0 0.0
.text 9913832 9950104 36272 0.4
lighting-app debug+rpc+ui (read only) 5300225 5300225 0 0.0
(read/write) 225032 225032 0 0.0
.bss 119360 119360 0 0.0
.data 4416 4416 0 0.0
.data.rel.ro 93696 93696 0 0.0
.dynamic 672 672 0 0.0
.got 5896 5896 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 340212 340212 0 0.0
.text 4715171 4715171 0 0.0
lock-app debug (read only) 4499849 4499849 0 0.0
(read/write) 203680 203680 0 0.0
.bss 113760 113760 0 0.0
.data 3648 3648 0 0.0
.data.rel.ro 79528 79528 0 0.0
.dynamic 624 624 0 0.0
.got 5232 5232 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 247029 247029 0 0.0
.text 4042755 4042755 0 0.0
ota-provider-app debug (read only) 4163473 4163473 0 0.0
(read/write) 192760 192760 0 0.0
.bss 113632 113632 0 0.0
.data 3904 3904 0 0.0
.data.rel.ro 69312 69312 0 0.0
.dynamic 624 624 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 201301 201301 0 0.0
.text 3770243 3770243 0 0.0
ota-requestor-app debug (read only) 4249873 4252897 3024 0.1
(read/write) 197008 197040 32 0.0
.bss 114656 114656 0 0.0
.data 4176 4176 0 0.0
.data.rel.ro 72272 72304 32 0.0
.dynamic 624 624 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 205109 205109 0 0.0
.text 3848531 3851459 2928 0.1
shell debug (read only) 2776625 2777153 528 0.0
(read/write) 149856 149856 0 0.0
.bss 60616 60616 0 0.0
.data 768 768 0 0.0
.data.rel.ro 82672 82672 0 0.0
.dynamic 592 592 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 180992 180992 0 0.0
.text 2424850 2425378 528 0.0
thermostat-no-ble arm64 (read only) 4401152 4401568 416 0.0
(read/write) 245264 244848 -416 -0.2
.bss 122232 122232 0 0.0
.data 2784 2784 0 0.0
.data.rel.ro 102368 102368 0 0.0
.dynamic 512 512 0 0.0
.got 12024 12024 0 0.0
.init 24 24 0 0.0
.init_array 424 424 0 0.0
.rodata 162332 162332 0 0.0
.text 3898360 3898776 416 0.0
tv-app debug (read only) 5375385 5381577 6192 0.1
(read/write) 348864 348960 96 0.0
.bss 244384 244384 0 0.0
.data 4992 4992 0 0.0
.data.rel.ro 92184 92280 96 0.1
.dynamic 624 624 0 0.0
.got 5520 5520 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 272789 272789 0 0.0
.text 4865027 4870883 5856 0.1
tv-casting-app debug (read only) 9285297 9335929 50632 0.5
(read/write) 332632 334840 2208 0.7
.bss 156192 156192 0 0.0
.data 2464 2464 0 0.0
.data.rel.ro 167128 169336 2208 1.3
.dynamic 624 624 0 0.0
.got 5064 5064 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 359976 359976 0 0.0
.text 8476515 8520547 44032 0.5
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2525640 2525640 0 0.0
.bss 220616 220616 0 0.0
.data 5144 5144 0 0.0
.text 1488324 1488324 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1060724 1061064 340 0.0
bss 129197 129197 0 0.0
rodata 104196 104200 4 0.0
text 779700 780036 336 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1187284 1187664 380 0.0
bss 121407 121407 0 0.0
rodata 138320 138332 12 0.0
text 777240 777608 368 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1046316 1046696 380 0.0
bss 129484 129484 0 0.0
rodata 99452 99464 12 0.0
text 769752 770124 372 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 835792 835792 0 0.0
(read/write) 1741588 1741668 80 0.0
.bss 195076 195076 0 0.0
.data 2472 2472 0 0.0
.text 1535652 1535732 80 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 837512 837512 0 0.0
(read/write) 1705892 1705972 80 0.0
.bss 193356 193356 0 0.0
.data 2472 2472 0 0.0
.text 1501676 1501756 80 0.0
light cy8ckit_062s2_43012 (read only) 844200 844200 0 0.0
(read/write) 1630996 1630996 0 0.0
.bss 186780 186780 0 0.0
.data 2360 2360 0 0.0
.text 1433468 1433468 0 0.0
lock cy8ckit_062s2_43012 (read only) 817080 817080 0 0.0
(read/write) 1657940 1657940 0 0.0
.bss 213876 213876 0 0.0
.data 2384 2384 0 0.0
.text 1433292 1433292 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1116132 1116508 376 0.0
.bss 101368 101368 0 0.0
.data 740 740 0 0.0
.text 628508 628884 376 0.1
lock-app qpg6105+debug (read/write) 1079772 1080140 368 0.0
.bss 97584 97584 0 0.0
.data 784 784 0 0.0
.text 592152 592520 368 0.1
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 820358 820358 0 0.0
bss 55152 55152 0 0.0
text 612776 612776 0 0.0
all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1077768 1078108 340 0.0
bss 100240 100240 0 0.0
text 760296 760634 338 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1083004 1083344 340 0.0
bss 109932 109932 0 0.0
text 752306 752644 338 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 934088 934088 0 0.0
bss 94440 94440 0 0.0
text 646160 646160 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 820534 820534 0 0.0
bss 55196 55196 0 0.0
text 613070 613070 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 4 4 0 0.0
(read/write) 977148 977576 428 0.0
bss 79180 79180 0 0.0
text 692694 693112 418 0.1
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1092056 1092420 364 0.0
bss 100004 100004 0 0.0
text 768696 769046 350 0.0
lock-app-dfu tlsr9528a (read only) 4 4 0 0.0
(read/write) 963848 963848 0 0.0
bss 97444 97444 0 0.0
text 646818 646818 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 947376 947740 364 0.0
bss 92548 92548 0 0.0
text 661902 662252 350 0.1
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 879272 879352 80 0.0
bss 69172 69172 0 0.0
text 621030 621112 82 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 819876 819956 80 0.0
bss 57408 57408 0 0.0
text 587906 587988 82 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 705672 705672 0 0.0
bss 73724 73724 0 0.0
text 462004 462004 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 822234 822234 0 0.0
bss 55332 55332 0 0.0
text 615782 615782 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 876661 877025 364 0.0
bss 60884 60884 0 0.0
text 629334 629684 350 0.1
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 844088 844168 80 0.0
bss 57704 57704 0 0.0
text 606232 606314 82 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 838580 838580 0 0.0
bss 58056 58056 0 0.0
text 600448 600448 0 0.0

@tehampson tehampson enabled auto-merge (squash) December 6, 2023 18:32
@tehampson tehampson merged commit 1b11535 into project-chip:master Dec 6, 2023
57 checks passed
bzbarsky-apple
bzbarsky-apple reviewed Dec 6, 2023
View reviewed changes
src/app/CommandSender.h
@@ -109,6 +111,9 @@ class CommandSender final : public Messaging::ExchangeDelegate
* The CommandSender object MUST continue to exist after this call is completed. The application shall wait until it
* receives an OnDone call to destroy the object.
*
* It is advised that subclass should only override this or `OnResponseWithAdditionalData`. But, it shouldn't actually
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"that subclasses".

@tehampson tehampson mentioned this pull request Feb 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple left review comments

@andy31415 andy31415 andy31415 approved these changes

@cecille cecille cecille approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@p0fi p0fi Awaiting requested review from p0fi

Assignees
No one assigned
Labels
app core documentation Improvements or additions to documentation fast track lib review - pending tests
Projects
[1.3] SDK Feature Complete
Status: Done
Milestone
1.3 Feature Complete
Development

Successfully merging this pull request may close these issues.
5 participants
@tehampson @andy31415 @cecille @bzbarsky-apple @woody-apple