[Crypto] Add HMAC function using KeyHandle #30751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepenven-silabs
force-pushed
the
crypto_fix_hmac_psa
branch
from
271684b to
fe7267a
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mhazley and
mkardous-silabs
mkardous-silabs
force-pushed
the
crypto_fix_hmac_psa
branch
from
5e07424 to
b74bb95
Compare
github-actions
bot
added
transport
app
icd
mkardous-silabs
requested review from
Damian-Nordic,
tcarmelveilleux and
jmartinez-silabs
mkardous-silabs
dismissed stale reviews from jmartinez-silabs and tcarmelveilleux
Significant changes to PR
mkardous-silabs
force-pushed
the
crypto_fix_hmac_psa
branch
from
6a24eb4 to
b74bb95
Compare
|
PR #30751: Size comparison from e9df864 to b74bb95 Increases (6 builds for linux, psoc6)
Decreases (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Dec 6, 2023
bzbarsky-apple
approved these changes
Dec 6, 2023
Damian-Nordic
approved these changes
Dec 6, 2023
yunhanw-google
approved these changes
Dec 6, 2023
|
PR #30751: Size comparison from e9df864 to 87b1066 Increases above 0.2%:
Increases (50 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
maciejbaczmanski
pushed a commit
to maciejbaczmanski/connectedhomeip
that referenced
this pull request
Jul 15, 2024
…p#30751) * Add new API for HMAC with key handle * Rename Aes128BitsKeyHandle to Aes128KeyHandle * Rename Hmac128BitsKeyHandle to Hmac128KeyHandle * Replace virtual destructor with a protected one * key algo creation --------- Co-authored-by: Mathieu Kardous <mathieu.kardous@silabs.com>
maciejbaczmanski
pushed a commit
to maciejbaczmanski/connectedhomeip
that referenced
this pull request
Jul 15, 2024
…ject-chip#30751)" This reverts commit bdded49.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed on Issue #30718 Check-in message seems to be using the HMAC function in the only way possible and this cause problem using PSA as the key is not stored withing the KeyHandle (only a keyID is stored within it).
This PR adds an API call to the HMAC_SHA256 which takes the KeyHandle directly as an argument and then relies on the underlying implementation to either retrieve the key from it or the KeyID.
Tests