-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ICD] Refactor ICD Monitoring Table to support HMAC handle and AES key handle #30881
Merged
mkardous-silabs
merged 7 commits into
project-chip:master
from
mkardous-silabs:fix/add_hmac_handle
Dec 8, 2023
Merged
[ICD] Refactor ICD Monitoring Table to support HMAC handle and AES key handle #30881
mkardous-silabs
merged 7 commits into
project-chip:master
from
mkardous-silabs:fix/add_hmac_handle
Dec 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Hmac Key Handle to ICD Monitoring Table
github-actions
bot
added
platform
crypto
app
tests
icd
Intermittently Connected Devices
silabs
labels
Dec 7, 2023
PR #30881: Size comparison from 23f11a3 to 537fed9 Increases (20 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, linux, mbed, psoc6, qpg, telink)
Decreases (1 build for cc32xx)
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30881: Size comparison from 23f11a3 to 30aea85 Increases (9 builds for cc13x4_26x4, cyw30739, efr32, linux, mbed, psoc6, qpg)
Full report (54 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #30881: Size comparison from 23f11a3 to b70d3dc Increases (20 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, linux, mbed, psoc6, qpg, telink)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
mkardous-silabs
force-pushed
the
fix/add_hmac_handle
branch
from
December 8, 2023 14:24
b70d3dc
to
cc38e83
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn and
Damian-Nordic
December 8, 2023 14:24
pullapprove
bot
requested review from
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
December 8, 2023 14:24
PR #30881: Size comparison from 1583a24 to cc38e83 Increases (20 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, linux, mbed, psoc6, qpg, telink)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
rcasallas-silabs
approved these changes
Dec 8, 2023
bzbarsky-apple
approved these changes
Dec 8, 2023
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
PR #30881: Size comparison from 1583a24 to 5b13467 Increases (2 builds for cc32xx, mbed)
Full report (3 builds for cc32xx, mbed)
|
PR #30881: Size comparison from 1583a24 to c5de8ba Increases above 0.2%:
Increases (36 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (1 build for linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor ICD Monitoring Table to support two key handles, AesKeyHandle & HmacKeyHandle.
Refactor of the ICD Monitoring Table is necessary to properly support PSA crypto for the Check-In Protocol.
PSA forces a KeyHandle to only be used with cryptographic algorithms defined when the key handle is created
The same key handle cannot be used for AES_CCM and for HMAC_SHA256 which forces us to have two key handles for each operation.
partly addresses #30718
Problems to be addressed in a follow up
PSA_KEY_LIFETIME_VOLATILE
which is not the correct lifetime for symmetric keys used in the ICD Monitoring tableSymmetric128BitsKeyByteArray
even if the the key handle might be a psa key idTests