Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TV commissioning and control #30904

Merged
merged 9 commits into from
Dec 14, 2023
Merged

Fix TV commissioning and control #30904

merged 9 commits into from
Dec 14, 2023

Conversation

chrisdecenzo
Copy link
Contributor

Two items fixed in this PR

  1. Recent changes to default operational discovery advertising for commissioners broke casting (when restarting client)
  2. Recent UDC changes did not allow optional pid in new vidList

Copy link

PR #30904: Size comparison from 2980e51 to 57469e8

Full report (4 builds for mbed, nrfconnect)
platform target config section 2980e51 57469e8 change % change
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2525848 2525848 0 0.0
.bss 220184 220184 0 0.0
.data 5144 5144 0 0.0
.text 1488532 1488532 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1060828 1060828 0 0.0
bss 129029 129029 0 0.0
rodata 104172 104172 0 0.0
text 779952 779952 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1046456 1046456 0 0.0
bss 129316 129316 0 0.0
rodata 99432 99432 0 0.0
text 770040 770040 0 0.0
all-clusters-app nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1187384 1187384 0 0.0
bss 121239 121239 0 0.0
rodata 138300 138300 0 0.0
text 777516 777516 0 0.0

Copy link

github-actions bot commented Dec 13, 2023

PR #30904: Size comparison from d389403 to b665b95

Decreases (1 build for efr32)
platform target config section d389403 b665b95 change % change
efr32 lock-app BRD4161A+wf200 (read/write) 1114448 1114440 -8 -0.0
.text 923060 923052 -8 -0.0
Full report (8 builds for efr32, mbed, nrfconnect)
platform target config section d389403 b665b95 change % change
efr32 lighting-app BRD4161A+rs9116 (read/write) 1016988 1016988 0 0.0
.bss 172600 172600 0 0.0
.data 2688 2688 0 0.0
.text 841680 841680 0 0.0
BRD4187C (read/write) 1100988 1100988 0 0.0
.bss 196204 196204 0 0.0
.data 3296 3296 0 0.0
.text 901468 901468 0 0.0
lock-app BRD4161A+wf200 (read/write) 1114448 1114440 -8 -0.0
.bss 188656 188656 0 0.0
.data 2712 2712 0 0.0
.text 923060 923052 -8 -0.0
window-app BRD4187C (read/write) 1135712 1135712 0 0.0
.bss 168236 168236 0 0.0
.data 3168 3168 0 0.0
.text 964288 964288 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2526040 2526040 0 0.0
.bss 220216 220216 0 0.0
.data 5144 5144 0 0.0
.text 1488724 1488724 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1062456 1062456 0 0.0
bss 129375 129375 0 0.0
rodata 104392 104392 0 0.0
text 781104 781104 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1189032 1189032 0 0.0
bss 121585 121585 0 0.0
rodata 138460 138460 0 0.0
text 778648 778648 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1046728 1046728 0 0.0
bss 129348 129348 0 0.0
rodata 99432 99432 0 0.0
text 770320 770320 0 0.0

Copy link

github-actions bot commented Dec 13, 2023

PR #30904: Size comparison from d389403 to 0c234de

Increases above 0.2%:

platform target config section d389403 0c234de change % change
linux chip-tool-ipv6only arm64 (read/write) 570416 573152 2736 0.5
Increases (1 build for linux)
platform target config section d389403 0c234de change % change
linux chip-tool-ipv6only arm64 (read only) 11412176 11413504 1328 0.0
(read/write) 570416 573152 2736 0.5
.rodata 344872 344968 96 0.0
.text 10199320 10200552 1232 0.0
Full report (18 builds for cc32xx, cyw30739, esp32, linux, mbed, nrfconnect, psoc6)
platform target config section d389403 0c234de change % change
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 566962 566962 0 0.0
(read/write) 207652 207652 0 0.0
.bss 201116 201116 0 0.0
.data 1412 1412 0 0.0
.rodata 83922 83922 0 0.0
.text 480916 480916 0 0.0
lock CC3235SF_LAUNCHXL (read only) 620298 620298 0 0.0
(read/write) 208048 208048 0 0.0
.bss 201480 201480 0 0.0
.data 1448 1448 0 0.0
.rodata 105786 105786 0 0.0
.text 512388 512388 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 561351 561351 0 0.0
.app_xip_area 451609 451609 0 0.0
.bss 64656 64656 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 543567 543567 0 0.0
.app_xip_area 429089 429089 0 0.0
.bss 69352 69352 0 0.0
.data 700 700 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 562335 562335 0 0.0
.app_xip_area 454049 454049 0 0.0
.bss 63272 63272 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 557799 557799 0 0.0
.app_xip_area 446289 446289 0 0.0
.bss 66392 66392 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
esp32 all-clusters-app c3devkit (read only) 1137748 1137748 0 0.0
(read/write) 1671092 1671092 0 0.0
.dram0.bss 72864 72864 0 0.0
.dram0.data 12988 12988 0 0.0
.flash.rodata 241376 241376 0 0.0
.flash.text 1137748 1137748 0 0.0
.iram0.text 75694 75694 0 0.0
m5stack (read only) 1182659 1182659 0 0.0
(read/write) 520292 520292 0 0.0
.dram0.bss 79512 79512 0 0.0
.dram0.data 34004 34004 0 0.0
.flash.rodata 272412 272412 0 0.0
.flash.text 1177275 1177275 0 0.0
.iram0.text 123907 123907 0 0.0
linux chip-tool-ipv6only arm64 (read only) 11412176 11413504 1328 0.0
(read/write) 570416 573152 2736 0.5
.bss 103448 103448 0 0.0
.data 4288 4288 0 0.0
.data.rel.ro 436448 436448 0 0.0
.dynamic 512 512 0 0.0
.got 19816 19816 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 344872 344968 96 0.0
.text 10199320 10200552 1232 0.0
thermostat-no-ble arm64 (read only) 4405296 4405296 0 0.0
(read/write) 245192 245192 0 0.0
.bss 122232 122232 0 0.0
.data 2784 2784 0 0.0
.data.rel.ro 102312 102312 0 0.0
.dynamic 512 512 0 0.0
.got 12008 12008 0 0.0
.init 24 24 0 0.0
.init_array 424 424 0 0.0
.rodata 162332 162332 0 0.0
.text 3902648 3902648 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2526040 2526040 0 0.0
.bss 220216 220216 0 0.0
.data 5144 5144 0 0.0
.text 1488724 1488724 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1062456 1062456 0 0.0
bss 129375 129375 0 0.0
rodata 104392 104392 0 0.0
text 781104 781104 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1189032 1189032 0 0.0
bss 121585 121585 0 0.0
rodata 138460 138460 0 0.0
text 778648 778648 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1046728 1046728 0 0.0
bss 129348 129348 0 0.0
rodata 99432 99432 0 0.0
text 770320 770320 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 835880 835880 0 0.0
(read/write) 1743436 1743436 0 0.0
.bss 194988 194988 0 0.0
.data 2472 2472 0 0.0
.text 1537588 1537588 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 837912 837912 0 0.0
(read/write) 1705924 1705924 0 0.0
.bss 192956 192956 0 0.0
.data 2472 2472 0 0.0
.text 1502108 1502108 0 0.0
light cy8ckit_062s2_43012 (read only) 844600 844600 0 0.0
(read/write) 1630884 1630884 0 0.0
.bss 186380 186380 0 0.0
.data 2360 2360 0 0.0
.text 1433756 1433756 0 0.0
lock cy8ckit_062s2_43012 (read only) 817480 817480 0 0.0
(read/write) 1657796 1657796 0 0.0
.bss 213476 213476 0 0.0
.data 2384 2384 0 0.0
.text 1433548 1433548 0 0.0

@chrisdecenzo chrisdecenzo enabled auto-merge (squash) December 14, 2023 10:06
@chrisdecenzo chrisdecenzo merged commit 4fe0f8d into master Dec 14, 2023
106 checks passed
@chrisdecenzo chrisdecenzo deleted the tv2 branch December 14, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants