-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add yaml test to validate previous fix to group including multiple endpoints #31146
Merged
mergify
merged 4 commits into
project-chip:master
from
tehampson:add-yaml-group-test-to-same-fabric-but-different-endpoints
Jan 4, 2024
Merged
Add yaml test to validate previous fix to group including multiple endpoints #31146
mergify
merged 4 commits into
project-chip:master
from
tehampson:add-yaml-group-test-to-same-fabric-but-different-endpoints
Jan 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi and
harsha-rajendran
December 20, 2023 23:11
pullapprove
bot
requested review from
yunhanw-google,
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yufengwangca
December 20, 2023 23:11
PR #31146: Size comparison from 2544b6e to 61ae292 Full report (18 builds for cc13x4_26x4, cc32xx, k32w, mbed, nrfconnect, qpg)
|
PR #31146: Size comparison from 2544b6e to e02e57e Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Jan 4, 2024
Fast track: test only, validated that test runs and still passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands test in
TestGroupMessaging.yaml
so that two endpoints on one device on one fabric are in the same group that gets sent a command. Prior to real fix in #30484 and #30614 , this would.All we are doing is adding a test that would have previously failed prior to #30484. We are trying to have CI insures that we don't accidentally reintroduce the bug.
Fixes: #30472
^ Comment added to auto close that issue. The issues was fixed for real for Status response in