Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes: [OPSTATE] specific phase in the list should not null #31176
Fixes: [OPSTATE] specific phase in the list should not null #31176
Changes from 2 commits
db93e5c
dd17a97
2e58f15
35aff20
407a397
3136b0d
b4b7273
5d1c066
ac0f34e
7b93188
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about:
and the same in all the other places where this got copy/pasted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably more of a spec question than an SDK question, but why have a nullable list to begin with? Per 17.18.1
This seems like extra wrappers for no good reason. Or is this just for backwards compatibility?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spec could have gone either way here.... There are various opinions about which is better (e.g. null is one less byte on the wire than an empty list is). But for purposes of the SDK, this is what the spec says, and yes, this has already shipped as nullable, so at this point we can't really change the spec.