-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency between chip-tool and the nlunit-test #31234
Merged
mergify
merged 3 commits into
project-chip:master
from
jlatusek:independent-chip-from-tests
Jan 13, 2024
Merged
Remove dependency between chip-tool and the nlunit-test #31234
mergify
merged 3 commits into
project-chip:master
from
jlatusek:independent-chip-from-tests
Jan 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tools
examples
transport
platform
darwin
lib
controller
app
tests
support
core
protocols
labels
Jan 3, 2024
PR #31234: Size comparison from c7f8ec9 to d2e527b Decreases (3 builds for linux)
Full report (56 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, mbed, psoc6, telink)
|
jlatusek
changed the title
Move sleeping methods to TimeUtils
Remove dependency between chip-tool and the nlunit-test
Jan 4, 2024
jlatusek
force-pushed
the
independent-chip-from-tests
branch
from
January 4, 2024 06:15
31c98c0
to
c8db2ef
Compare
PR #31234: Size comparison from 9279628 to c8db2ef Full report (26 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, mbed, psoc6)
|
PR #31234: Size comparison from 9279628 to 859c046 Full report (58 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, mbed, psoc6, telink)
|
src/app/tests/suites/commands/interaction_model/InteractionModel.h
Outdated
Show resolved
Hide resolved
jlatusek
force-pushed
the
independent-chip-from-tests
branch
from
January 11, 2024 09:32
859c046
to
8313e68
Compare
PR #31234: Size comparison from d2a13cb to 8b32d6a Full report (40 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #31234: Size comparison from d2a13cb to 9a6ddf7 Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jlatusek
force-pushed
the
independent-chip-from-tests
branch
from
January 11, 2024 12:07
c7d7fd4
to
9bdffc1
Compare
PR #31234: Size comparison from d2a13cb to 9bdffc1 Decreases (1 build for efr32)
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
|
PR #31234: Size comparison from d2a13cb to 452baa1 Increases (42 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, nrfconnect, qpg)
Decreases (26 builds for bl602, bl702, bl702l, cc13x4_26x4, esp32, linux, nrfconnect)
Full report (56 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
pullapprove
bot
requested review from
mspang,
nivi-apple,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
January 12, 2024 12:55
bzbarsky-apple
approved these changes
Jan 12, 2024
arkq
approved these changes
Jan 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is related to #29682.
Problem
The chip-tool has in dependency to nlunit-test trought other targets:
This causes a problem while replacing the nlunit-test with pigweed ones.
Pigweed unit tests require setting the proper backend for used modules. Without it, the compilation ends up with an error. The build of the chip-tool should not set variables related to unit testing.
Changes
I've split testing into two new targets:
testing_nlunit
andtest_utils
.testing_nlunit
will be removed entirely after the end of the integration of pigweed tests.Testing
Ci will test it, the dependency can be check by: