-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle the RvcOperationalState GoHome command #31289
Merged
mergify
merged 30 commits into
project-chip:master
from
dysonltd:Handle_RvcOpState_GoHome_command
Jan 18, 2024
Merged
Handle the RvcOperationalState GoHome command #31289
mergify
merged 30 commits into
project-chip:master
from
dysonltd:Handle_RvcOpState_GoHome_command
Jan 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s derived clusters to handle the invocation of their specific commands. This method is called by the operational state cluster if the received command is not a known base cluster command.
…ved cluster methods to handle commands intended for them.
…gate's HandleGoHomeCommandCallback method since the GoHome command is optional. Use the correct delegate type of in the rvc-app example.
hicklin
commented
Jan 8, 2024
src/app/clusters/operational-state-server/operational-state-server.cpp
Outdated
Show resolved
Hide resolved
PR #31289: Size comparison from 7381d76 to 255c976 Decreases (1 build for efr32)
Full report (56 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
|
…-app and implemented its GoHome command handle.
PR #31289: Size comparison from 7381d76 to db51705 Increases above 0.2%:
Increases (12 builds for esp32, linux, nrfconnect, psoc6, telink)
Decreases (2 builds for efr32, telink)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jan 11, 2024
src/app/clusters/operational-state-server/operational-state-server.cpp
Outdated
Show resolved
Hide resolved
…oHome_command. This brings in the changes in the geterated code.
… in the previous merge.
…icOperationalPhase class was removed when main was merget.
…tances in the all-clusters-app. Replaced the custom implementation of the OperationalState and RvcOperationalState delegates for the ameba platform with the common implementations.
pullapprove
bot
requested review from
kkasperczyk-no,
kpschoedel,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mhazley,
mkardous-silabs,
mspang,
p0fi,
pidarped,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
wiba-nordic,
younghak-hwang and
yufengwangca
January 18, 2024 10:31
PR #31289: Size comparison from 2b577ca to cbce399 Increases (2 builds for cc32xx)
Full report (2 builds for cc32xx)
|
PR #31289: Size comparison from 88c0d58 to e6d687d Increases (11 builds for esp32, linux, nrfconnect, psoc6, telink)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31241.
This PR builds on the PR 8723. This is not yet merged so the changes from that PR will appear here for now.
This PR is the first case where a derived cluster handles a command that is not implemented in the base cluster. When reviewing please note the pattern used. Note that both the base cluster and the derived cluster hold a private pointer to the same delegate but with different types.