Introduce CommandSender::ExtendedCallback #31324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tehampson
commented
Jan 9, 2024
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple and
lazarkov
|
PR #31324: Size comparison from a2c88cf to 9fedf93 Increases (43 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg)
Decreases (19 builds for bl602, bl702, bl702l, cc13x4_26x4, linux, nrfconnect)
Full report (44 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
tcarmelveilleux
approved these changes
Jan 10, 2024
|
PR #31324: Size comparison from a2c88cf to 7d2d077 Increases (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (24 builds for bl602, bl702, bl702l, cc13x4_26x4, linux, nrfconnect)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
This was referenced Jan 10, 2024
Closed
Closed
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
bzbarsky-apple
approved these changes
Jan 11, 2024
Emill
reviewed
Jan 15, 2024
| Messaging::ExchangeHolder mExchangeCtx; | ||
| Callback * mpCallback = nullptr; | ||
| ExtendableCallback * mpExtendableCallback = nullptr; |
There was a problem hiding this comment.
Consider putting this together with mpCallback in a union to save RAM. An outer bitfield:1 could be used to differentiate which field is active.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #30991
The two major differences between
CommandSender::ExtendedCallbackandCommandSender::Callbackare:CommandSenderso as functionality expands and more data needs to pass into the callback they are added to the struct instead of function argument list.Alternatives considered:
Callback::PathSpecificErrorGoesToOnResponseCallbacks, where we would call OnResponse* callback with path specific errors.Test:
src/app/tests/TestCommandInteraction.cpppasschip-repl, verified able to receive two path specific errors.