Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle [samples/nrfconnect] Added updating ZCL cluster state to fit actual light/lock state. #3133

Closed
wants to merge 2 commits into from

Conversation

restyled-io[bot]
Copy link
Contributor

@restyled-io restyled-io bot commented Oct 8, 2020

A duplicate of #3132 with additional commits that automatically address
incorrect style, created by Restyled.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

  • clang-format

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Expand for example instructions
    ```console
    git remote add upstream https://github.com/project-chip/connectedhomeip.git
    git fetch upstream pull/<this PR number>/head
    git merge --ff-only FETCH_HEAD
    git push
    ```
    

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.

kkasperczyk-no and others added 2 commits October 8, 2020 15:15
…tual light/lock state.

Initial value of ZCL ON/OFF cluster is not defined,
while the lock/lighting is initially turned on in nRF Connect examples.

* Added UpdateClusterState method called on the init and each completed
on/off action.
@restyled-io restyled-io bot added the restyled label Oct 8, 2020
@restyled-io restyled-io bot closed this Oct 8, 2020
@restyled-io restyled-io bot deleted the restyled/pull-3132 branch October 8, 2020 13:26
@github-actions
Copy link

github-actions bot commented Oct 8, 2020

Size increase report for "nrfconnect-example-build"

File Section File VM
chip-lighting.elf text 80 80
chip-lighting.elf rodata 24 24
chip-lock.elf text 76 76
chip-lock.elf rodata 24 24
chip-lock.elf [LOAD #1 [RWX]] 4 4
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lighting.elf and ./pull_artifact/chip-lighting.elf:

sections,vmsize,filesize
.debug_info,0,2610
.debug_line,0,450
.debug_abbrev,0,140
text,80,80
.symtab,0,64
.debug_str,0,55
.debug_frame,0,40
.strtab,0,34
rodata,24,24
.debug_loc,0,23
.debug_ranges,0,16
.debug_aranges,0,8
[Unmapped],0,4

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_info,0,2614
.debug_line,0,417
.debug_abbrev,0,78
text,76,76
.symtab,0,64
.debug_str,0,55
.strtab,0,34
.debug_frame,0,24
rodata,24,24
.debug_loc,0,23
.debug_aranges,0,8
[LOAD #1 [RWX]],4,4
[Unmapped],0,3
.debug_ranges,0,-16


@github-actions
Copy link

github-actions bot commented Oct 8, 2020

Size increase report for "esp32-example-build"

File Section File VM
chip-wifi-echo.elf .flash.rodata 8 8
chip-wifi-echo.elf .dram0.bss 0 -8
chip-wifi-echo.elf .dram0.data -8 -8
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize
.flash.rodata,8,8
.dram0.bss,-8,0
.dram0.data,-8,-8


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants