Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup callbacks a bit: remove client-side attribute callbacks and some useless comments #31345

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Cleanup callbacks a bit: remove client-side attribute callbacks and some useless comments #31345

merged 2 commits into from
Jan 10, 2024

Conversation

andy31415
Copy link
Contributor

Generally this makes the code shorter, especially since we check in generated code.

@github-actions github-actions bot added the app label Jan 10, 2024
@andy31415 andy31415 changed the title Cleanup callbacsk a bit: remove client-side attribute callbacks and some useless comments Cleanup callbacks a bit: remove client-side attribute callbacks and some useless comments Jan 10, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 10, 2024 •
edited
Loading

PR #31345: Size comparison from 79a05c9 to e3fad81

Decreases (1 build for efr32)
platform target config section 79a05c9 e3fad81 change % change
efr32 lighting-app BRD4161A+rs9116 (read/write) 1041856 1041848 -8 -0.0
.text 846396 846388 -8 -0.0
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 79a05c9 e3fad81 change % change
bl602 lighting-app bl602 (read/write) 1419658 1419658 0 0.0
.bss 85256 85256 0 0.0
.data 9416 9416 0 0.0
.rodata 156992 156992 0 0.0
.text 1087352 1087352 0 0.0
bl602+mfd (read/write) 1434130 1434130 0 0.0
.bss 85424 85424 0 0.0
.data 9384 9384 0 0.0
.rodata 155952 155952 0 0.0
.text 1102720 1102720 0 0.0
bl602+rpc (read/write) 1467178 1467178 0 0.0
.bss 93288 93288 0 0.0
.data 9784 9784 0 0.0
.rodata 164608 164608 0 0.0
.text 1118840 1118840 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1184375 1184375 0 0.0
.bss 11197 11197 0 0.0
.data 3584 3584 0 0.0
.rodata 106364 106364 0 0.0
.text 956760 956760 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1195507 1195507 0 0.0
.bss 11373 11373 0 0.0
.data 3568 3568 0 0.0
.rodata 105304 105304 0 0.0
.text 968824 968824 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1276391 1276391 0 0.0
.bss 19677 19677 0 0.0
.data 4144 4144 0 0.0
.rodata 121784 121784 0 0.0
.text 1031822 1031822 0 0.0
bl706-eth (read/write) 1003769 1003769 0 0.0
.bss 23772 23772 0 0.0
.data 3160 3160 0 0.0
.rodata 99696 99696 0 0.0
.text 749422 749422 0 0.0
bl706-wifi (read/write) 1242678 1242678 0 0.0
.bss 10641 10641 0 0.0
.data 3600 3600 0 0.0
.rodata 120676 120676 0 0.0
.text 977492 977492 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1154084 1154084 0 0.0
.bss 16392 16392 0 0.0
.data 4952 4952 0 0.0
.rodata 100368 100368 0 0.0
.text 949886 949886 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1165536 1165536 0 0.0
.bss 16568 16568 0 0.0
.data 4928 4928 0 0.0
.rodata 99308 99308 0 0.0
.text 962262 962262 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 777824 777824 0 0.0
(read/write) 168308 168308 0 0.0
.bss 90524 90524 0 0.0
.data 3452 3452 0 0.0
.rodata 88832 88832 0 0.0
.text 688724 688724 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 793896 793896 0 0.0
(read/write) 178536 178536 0 0.0
.bss 100700 100700 0 0.0
.data 3480 3480 0 0.0
.rodata 83088 83088 0 0.0
.text 710544 710544 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 782152 782152 0 0.0
(read/write) 172992 172992 0 0.0
.bss 95156 95156 0 0.0
.data 3480 3480 0 0.0
.rodata 109696 109696 0 0.0
.text 672192 672192 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 734768 734768 0 0.0
(read/write) 167312 167312 0 0.0
.bss 89304 89304 0 0.0
.data 3440 3440 0 0.0
.rodata 84424 84424 0 0.0
.text 650076 650076 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 720296 720296 0 0.0
(read/write) 167492 167492 0 0.0
.bss 89488 89488 0 0.0
.data 3436 3436 0 0.0
.rodata 80264 80264 0 0.0
.text 639764 639764 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 567722 567722 0 0.0
(read/write) 207748 207748 0 0.0
.bss 201212 201212 0 0.0
.data 1412 1412 0 0.0
.rodata 83970 83970 0 0.0
.text 481632 481632 0 0.0
lock CC3235SF_LAUNCHXL (read only) 621058 621058 0 0.0
(read/write) 208144 208144 0 0.0
.bss 201576 201576 0 0.0
.data 1448 1448 0 0.0
.rodata 105834 105834 0 0.0
.text 513104 513104 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 562015 562015 0 0.0
.app_xip_area 452169 452169 0 0.0
.bss 64760 64760 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 544255 544255 0 0.0
.app_xip_area 429673 429673 0 0.0
.bss 69456 69456 0 0.0
.data 700 700 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 562943 562943 0 0.0
.app_xip_area 454553 454553 0 0.0
.bss 63376 63376 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 558439 558439 0 0.0
.app_xip_area 446825 446825 0 0.0
.bss 66496 66496 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1041856 1041848 -8 -0.0
.bss 192728 192728 0 0.0
.data 2708 2708 0 0.0
.text 846396 846388 -8 -0.0
BRD4187C (read/write) 1105012 1105012 0 0.0
.bss 195004 195004 0 0.0
.data 3316 3316 0 0.0
.text 906672 906672 0 0.0
lock-app BRD4161A+wf200 (read/write) 1117928 1117928 0 0.0
.bss 188112 188112 0 0.0
.data 2732 2732 0 0.0
.text 927064 927064 0 0.0
window-app BRD4187C (read/write) 1138296 1138296 0 0.0
.bss 167036 167036 0 0.0
.data 3188 3188 0 0.0
.text 968052 968052 0 0.0
esp32 all-clusters-app c3devkit (read only) 1153472 1153472 0 0.0
(read/write) 1669208 1669208 0 0.0
.dram0.bss 71784 71784 0 0.0
.dram0.data 13444 13444 0 0.0
.flash.rodata 239976 239976 0 0.0
.flash.text 1153472 1153472 0 0.0
.iram0.text 75530 75530 0 0.0
m5stack (read only) 1199595 1199595 0 0.0
(read/write) 519832 519832 0 0.0
.dram0.bss 78656 78656 0 0.0
.dram0.data 34988 34988 0 0.0
.flash.rodata 270268 270268 0 0.0
.flash.text 1193431 1193431 0 0.0
.iram0.text 125403 125403 0 0.0
k32w contact k32w0+release (read only) 606416 606416 0 0.0
(read/write) 81176 81176 0 0.0
.bss 69024 69024 0 0.0
.data 2168 2168 0 0.0
.text 605880 605880 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 691664 691664 0 0.0
.bss 67680 67680 0 0.0
.data 2716 2716 0 0.0
.text 577792 577792 0 0.0
light k32w0+release (read only) 595816 595816 0 0.0
(read/write) 79192 79192 0 0.0
.bss 67088 67088 0 0.0
.data 2120 2120 0 0.0
.text 595280 595280 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 783500 783500 0 0.0
.bss 77356 77356 0 0.0
.data 1928 1928 0 0.0
.text 660760 660760 0 0.0
lock k32w0+release (read only) 577288 577288 0 0.0
(read/write) 78648 78648 0 0.0
.bss 66568 66568 0 0.0
.data 2096 2096 0 0.0
.text 576752 576752 0 0.0
linux air-purifier-app debug (read only) 2534125 2534125 0 0.0
(read/write) 127248 127248 0 0.0
.bss 46944 46944 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 72856 72856 0 0.0
.dynamic 608 608 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 179592 179592 0 0.0
.text 2179109 2179109 0 0.0
all-clusters-app debug (read only) 5432865 5432865 0 0.0
(read/write) 457888 457888 0 0.0
.bss 131760 131760 0 0.0
.data 3840 3840 0 0.0
.data.rel.ro 315032 315032 0 0.0
.dynamic 624 624 0 0.0
.got 5336 5336 0 0.0
.init 27 27 0 0.0
.init_array 1288 1288 0 0.0
.rodata 314140 314140 0 0.0
.text 4706611 4706611 0 0.0
all-clusters-minimal-app debug (read only) 4962017 4962017 0 0.0
(read/write) 234728 234728 0 0.0
.bss 127856 127856 0 0.0
.data 3776 3776 0 0.0
.data.rel.ro 95992 95992 0 0.0
.dynamic 624 624 0 0.0
.got 5296 5296 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 272813 272813 0 0.0
.text 4456723 4456723 0 0.0
bridge-app debug (read only) 4424985 4424985 0 0.0
(read/write) 215968 215968 0 0.0
.bss 119224 119224 0 0.0
.data 4704 4704 0 0.0
.data.rel.ro 85312 85312 0 0.0
.dynamic 624 624 0 0.0
.got 5264 5264 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 219477 219477 0 0.0
.text 3986915 3986915 0 0.0
chip-tool debug (read only) 11770713 11770713 0 0.0
(read/write) 507992 507992 0 0.0
.bss 94200 94200 0 0.0
.data 4994 4994 0 0.0
.data.rel.ro 401544 401544 0 0.0
.dynamic 624 624 0 0.0
.got 5784 5784 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 428681 428681 0 0.0
.text 10646195 10646195 0 0.0
chip-tool-ipv6only arm64 (read only) 11344392 11344392 0 0.0
(read/write) 576672 576672 0 0.0
.bss 103272 103272 0 0.0
.data 4384 4384 0 0.0
.data.rel.ro 440816 440816 0 0.0
.dynamic 512 512 0 0.0
.got 19960 19960 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 339716 339716 0 0.0
.text 10128732 10128732 0 0.0
lighting-app debug+rpc+ui (read only) 5310977 5310977 0 0.0
(read/write) 225040 225040 0 0.0
.bss 119360 119360 0 0.0
.data 4416 4416 0 0.0
.data.rel.ro 93728 93728 0 0.0
.dynamic 672 672 0 0.0
.got 5880 5880 0 0.0
.init 27 27 0 0.0
.init_array 968 968 0 0.0
.rodata 340724 340724 0 0.0
.text 4725443 4725443 0 0.0
lock-app debug (read only) 4510105 4510105 0 0.0
(read/write) 203688 203688 0 0.0
.bss 113760 113760 0 0.0
.data 3648 3648 0 0.0
.data.rel.ro 79544 79544 0 0.0
.dynamic 624 624 0 0.0
.got 5216 5216 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 247381 247381 0 0.0
.text 4052675 4052675 0 0.0
ota-provider-app debug (read only) 4174145 4174145 0 0.0
(read/write) 192736 192736 0 0.0
.bss 113632 113632 0 0.0
.data 3904 3904 0 0.0
.data.rel.ro 69312 69312 0 0.0
.dynamic 624 624 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 201589 201589 0 0.0
.text 3780659 3780659 0 0.0
ota-requestor-app debug (read only) 4264721 4264721 0 0.0
(read/write) 197048 197048 0 0.0
.bss 114656 114656 0 0.0
.data 4176 4176 0 0.0
.data.rel.ro 72320 72320 0 0.0
.dynamic 624 624 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 205397 205397 0 0.0
.text 3863027 3863027 0 0.0
shell debug (read only) 2803569 2803569 0 0.0
(read/write) 152672 152672 0 0.0
.bss 62440 62440 0 0.0
.data 768 768 0 0.0
.data.rel.ro 83656 83656 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 1104 1104 0 0.0
.rodata 182592 182592 0 0.0
.text 2449602 2449602 0 0.0
thermostat-no-ble arm64 (read only) 4353400 4353400 0 0.0
(read/write) 247808 247808 0 0.0
.bss 122056 122056 0 0.0
.data 2880 2880 0 0.0
.data.rel.ro 102752 102752 0 0.0
.dynamic 512 512 0 0.0
.got 12088 12088 0 0.0
.init 24 24 0 0.0
.init_array 424 424 0 0.0
.rodata 155644 155644 0 0.0
.text 3855244 3855244 0 0.0
tv-app debug (read only) 5411425 5411425 0 0.0
(read/write) 349248 349248 0 0.0
.bss 244608 244608 0 0.0
.data 4992 4992 0 0.0
.data.rel.ro 92344 92344 0 0.0
.dynamic 624 624 0 0.0
.got 5512 5512 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 273493 273493 0 0.0
.text 4899923 4899923 0 0.0
tv-casting-app debug (read only) 9647121 9647121 0 0.0
(read/write) 340144 340144 0 0.0
.bss 156384 156384 0 0.0
.data 2464 2464 0 0.0
.data.rel.ro 174432 174432 0 0.0
.dynamic 624 624 0 0.0
.got 5064 5064 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 365608 365608 0 0.0
.text 8813555 8813555 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2526712 2526712 0 0.0
.bss 220312 220312 0 0.0
.data 5144 5144 0 0.0
.text 1489396 1489396 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1070108 1070108 0 0.0
bss 129520 129520 0 0.0
rodata 105596 105596 0 0.0
text 787420 787420 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1196228 1196228 0 0.0
bss 121730 121730 0 0.0
rodata 139352 139352 0 0.0
text 784804 784804 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1041168 1041168 0 0.0
bss 129444 129444 0 0.0
rodata 98896 98896 0 0.0
text 765160 765160 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 835720 835720 0 0.0
(read/write) 1754172 1754172 0 0.0
.bss 195140 195140 0 0.0
.data 2480 2480 0 0.0
.text 1548164 1548164 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 837816 837816 0 0.0
(read/write) 1707164 1707164 0 0.0
.bss 193052 193052 0 0.0
.data 2472 2472 0 0.0
.text 1503252 1503252 0 0.0
light cy8ckit_062s2_43012 (read only) 844504 844504 0 0.0
(read/write) 1632068 1632068 0 0.0
.bss 186476 186476 0 0.0
.data 2360 2360 0 0.0
.text 1434844 1434844 0 0.0
lock cy8ckit_062s2_43012 (read only) 817384 817384 0 0.0
(read/write) 1658980 1658980 0 0.0
.bss 213572 213572 0 0.0
.data 2384 2384 0 0.0
.text 1434636 1434636 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1117548 1117548 0 0.0
.bss 101296 101296 0 0.0
.data 740 740 0 0.0
.text 629924 629924 0 0.0
lock-app qpg6105+debug (read/write) 1081460 1081460 0 0.0
.bss 97592 97592 0 0.0
.data 784 784 0 0.0
.text 593840 593840 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 822234 822234 0 0.0
bss 50988 50988 0 0.0
text 614508 614508 0 0.0
all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1089292 1089292 0 0.0
bss 100516 100516 0 0.0
text 769476 769476 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1085108 1085108 0 0.0
bss 109840 109840 0 0.0
text 754302 754302 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 935612 935612 0 0.0
bss 94348 94348 0 0.0
text 647608 647608 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 822470 822470 0 0.0
bss 51032 51032 0 0.0
text 614878 614878 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 4 4 0 0.0
(read/write) 979768 979768 0 0.0
bss 79112 79112 0 0.0
text 695174 695174 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1094160 1094160 0 0.0
bss 99912 99912 0 0.0
text 770700 770700 0 0.0
lock-app-dfu tlsr9528a (read only) 4 4 0 0.0
(read/write) 966184 966184 0 0.0
bss 97376 97376 0 0.0
text 648644 648644 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 949488 949488 0 0.0
bss 92456 92456 0 0.0
text 663918 663918 0 0.0
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 881372 881372 0 0.0
bss 69104 69104 0 0.0
text 622992 622992 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 822016 822016 0 0.0
bss 57348 57348 0 0.0
text 589916 589916 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 705628 705628 0 0.0
bss 73568 73568 0 0.0
text 462136 462136 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 824198 824198 0 0.0
bss 51168 51168 0 0.0
text 617622 617622 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 879205 879205 0 0.0
bss 60816 60816 0 0.0
text 631754 631754 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 846388 846388 0 0.0
bss 57636 57636 0 0.0
text 608382 608382 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 840552 840552 0 0.0
bss 57988 57988 0 0.0
text 602312 602312 0 0.0

@mergify mergify bot merged commit fcd82fd into project-chip:master Jan 10, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andy31415 @tcarmelveilleux @mkardous-silabs