-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EVSE update zap xml to reflect latest spec (ChargingTargetStruct) and removed 2 attributes #31406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed to use amperage_mA, energy_mWh - removed max on epoch_s - removed access for operate - removed side for events
…ogen, but still fails with some parts of regen_all
…ml-device-energy-management-to-use-new-types-and-clean-up-other-comments-with-optional-xml
…zap and regen_all
…d PowerAdjustmentCapability Nullable attributes. Added feature support.
…Device-Energy-Management-cluster-to-All-clusters-app
…ml-device-energy-management-to-use-new-types-and-clean-up-other-comments-with-optional-xml
…Nullable etc and in Fault Event).
…-energy-management-to-use-new-types-and-clean-up-other-comments-with-optional-xml
…Device-Energy-Management-cluster-to-All-clusters-app
…ement-to-use-new-types-and-clean-up-other-comments-with-optional-xml' into Fix-for-project-chip#30726---Add-Device-Energy-Management-cluster-to-All-clusters-app
…ement-to-use-new-types-and-clean-up-other-comments-with-optional-xml' into Fix-for-project-chip#30726---Add-Device-Energy-Management-cluster-to-All-clusters-app
…hip#30726---Add-Device-Energy-Management-cluster-to-All-clusters-app
… regen_all after merging from master.
pullapprove
bot
requested review from
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
January 17, 2024 11:08
PR #31406: Size comparison from f59323b to e8996a9 Increases (4 builds for esp32, linux)
Decreases (10 builds for esp32, linux, nrfconnect, psoc6, telink)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Jan 18, 2024
Checked against my copy of the spec, .matter file updates looked right. |
Fast track - no review in 5 days and I validated the changes match the spec. |
Approve, not on approval list so a 'grey check' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve, looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app
app-clusters
Application cluster work
controller
crypto
darwin
energy evse
Issue related to EVSE feature
energy
examples
fast track
github
platform
review - pending
scripts
skip-protocol-compatibility
Marker that protocol backwards compatibility checks are to be skipped
test driver
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the energy-evse-cluster.xml to reflect the latest EnergyEVSE.adoc
Updated energy-evse-cluster.xml to use latest EnergyEVSE.adoc which removes numberOfWeeklyTargets, numberOfDailyTargets, and adds new ChargingTargetScheduleStruct in Get/Set/Clear Target commands.
Also changes to CamelCase in DayOfWeekForSequence (was a lowercase
for
)