Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make src/system use pragma once in headers #3141

Merged
merged 1 commit into from
Oct 9, 2020

Conversation

andy31415
Copy link
Contributor

Problem

Include header guards are more typing, pollute the global define space, have a chance to mistmatch ending comments (if we ever rename and copy&paste).

#pragma once is supported most compilers already, let's use it.

Summary of Changes

uses #pragma once in headers under src/system

parth of #3138

@github-actions
Copy link

github-actions bot commented Oct 8, 2020

Size increase report for "esp32-example-build"

File Section File VM
chip-wifi-echo.elf .flash.rodata 8 8
chip-wifi-echo.elf .dram0.bss 0 -8
chip-wifi-echo.elf .dram0.data -8 -8
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize
.flash.rodata,8,8
.debug_abbrev,0,2
.debug_info,0,1
[Unmapped],0,-3
.dram0.bss,-8,0
.dram0.data,-8,-8


@mspang mspang merged commit 0c072ee into project-chip:master Oct 9, 2020
kpschoedel pushed a commit to kpschoedel/connectedhomeip that referenced this pull request Oct 9, 2020
@andy31415 andy31415 deleted the 01_system_pragma_once branch October 9, 2020 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants