Make src/lib/support to use pragma once in headers #3147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
mspang,
rwalker-apple and
saurabhst
saurabhst
approved these changes
Oct 8, 2020
rwalker-apple
approved these changes
Oct 8, 2020
mspang
approved these changes
Oct 9, 2020
kpschoedel
pushed a commit
to kpschoedel/connectedhomeip
that referenced
this pull request
Oct 9, 2020
* Make src/lib/support to use pragma once in headers * Remove extra newline in files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Include header guards are more typing, pollute the global define space, have a chance to mistmatch ending comments (if we ever rename and copy&paste).
#pragma onceis supported most compilers already, let's use it.Summary of Changes
Use pragma once.
Part of #3138