-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch rpc_console to ipython #31490
Conversation
What is the ptpython exception? FWIW I've seen one report of ptpython 3.0.24 breaking pw_console with |
PR #31490: Size comparison from a8df984 to 9373a7c Full report (3 builds for cc32xx, mbed)
|
Initial exception is:
however then falls into an error in pigweed capturing it:
since we do not use device logs, there seems to not be a strong argument to use the pt-python based console and ipython is probably enough for now (and unblocks us for the time being) |
PR #31490: Size comparison from a8df984 to 5eea4a9 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #31490: Size comparison from a8df984 to 0c5237d Increases (64 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (2 builds for linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
FWIW I've got the ptpython related exceptions fixed in https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/188146 |
Console is using a custom impl that does not age well.
Current breakage seems to be that ptpython compatibility with python 3.11 is broken (exception inside exception). Had to switch to ipython.
Changes