Check if the result of EncodeCommand is successful before trying to s… #3151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
mspang,
rwalker-apple and
saurabhst
saurabhst
approved these changes
Oct 8, 2020
rwalker-apple
approved these changes
Oct 8, 2020
bzbarsky-apple
approved these changes
Oct 8, 2020
vivien-apple
force-pushed
the
ChipTool_CheckSendCommand
branch
from
7df7b0f to
ded5307
Compare
mspang
approved these changes
Oct 12, 2020
rwalker-apple
pushed a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Oct 12, 2020
rwalker-apple
pushed a commit
that referenced
this pull request
Oct 12, 2020
* Use enum class for TLVElementType and TLVTagControl. This makes it easy to give them as specific size spec, which will prevent issues with people adding out-of-range values and simplify -Wconversion work. * Check if the result of EncodeCommand is successful before trying to send the command (#3151) * Remove verbose code comments (#3187) Some devices are configured to act as Thread router instead of sleepy-end device. This PR removes these incorrect or verbose comments. * Remove {#mainpage} from the main README.md file (#3190) * Remove Makefiles introduced by #3099 (#3191) * [nRF Connect] README updates on Docker for MacOS and NCS version (#3175) * [nRF Connect] README updates on Docker for MacOS and NCS version * Restyled by prettier-markdown * Rephrase a sentence Co-authored-by: Restyled.io <commits@restyled.io> * Modify the generated files for example lighting and lock apps to include server init callbacks. (#3180) This allows the app to implement emberAfPluginOnOffClusterServerPostInitCallback to sync up the data model state with the state of the actual device when the data model initializes. * Use pragma once in more places (#3182) * Add a lot of pragma once changes. Now scripted! * update pragma once in setup payload * More pragma once * Pragma once within platform and more * pragma once in the crypto layer * pragma once in examples * Fix by restyle-diff * [android] Use ATT Write Request instead of ATT Write Command (#3161) Co-authored-by: Vivien Nicolas <vnicolas@apple.com> Co-authored-by: Yakun Xu <xyk@google.com> Co-authored-by: Damian Królik <66667989+Damian-Nordic@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Andrei Litvin <andrei@andy314.com> Co-authored-by: Łukasz Duda <lukasz.duda@nordicsemi.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…end the command
Problem
When a command encoding failed in chip-tool, the current ignore it and still try to send it.
Changes