-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upon running out of space in InvokeResponseMessage for additional responses, allocate another #31516
Merged
tehampson
merged 20 commits into
project-chip:master
from
tehampson:start-using-more-chunked-messages-upload
Jan 19, 2024
Merged
Upon running out of space in InvokeResponseMessage for additional responses, allocate another #31516
tehampson
merged 20 commits into
project-chip:master
from
tehampson:start-using-more-chunked-messages-upload
Jan 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tehampson
force-pushed
the
start-using-more-chunked-messages-upload
branch
from
January 18, 2024 16:22
5b4bffa
to
2b285d0
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mhazley
January 18, 2024 16:23
PR #31516: Size comparison from 45aa5b7 to 59c652c Increases above 0.2%:
Increases (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (5 builds for linux, psoc6)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tcarmelveilleux
approved these changes
Jan 19, 2024
andy31415
reviewed
Jan 19, 2024
andy31415
reviewed
Jan 19, 2024
PR #31516: Size comparison from 45aa5b7 to 31f1f1a Increases above 0.2%:
Increases (18 builds for cc13x4_26x4, cc32xx, k32w, mbed, nrfconnect, qpg)
Full report (18 builds for cc13x4_26x4, cc32xx, k32w, mbed, nrfconnect, qpg)
|
PR #31516: Size comparison from 45aa5b7 to 0550805 Increases above 0.2%:
Increases (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (5 builds for linux, psoc6)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tehampson
commented
Jan 19, 2024
bzbarsky-apple
approved these changes
Jan 19, 2024
53 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries adding an
InvokeResponse
to a command into theInvokeResponseMessage
. Upon failure due to lack of remaining space, it finalize the currentInvokeResponseMessage
and allocates anotherInvokeResponseMessage
. It then retires to add thatInvokeResponse
into the newInvokeResponseMessage
.Change was also made to
TryAddResponseData
, instead of a template forCommandData
, we made added Function template. This should reduce compiled code size.Test: