-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TCR] Extended Announcement additions #31532
Conversation
PR #31532: Size comparison from d250a11 to 96e31f4 Full report (4 builds for cc32xx, mbed, stm32)
|
PR #31532: Size comparison from d250a11 to 856a9c9 Full report (9 builds for cc32xx, mbed, nrfconnect, qpg, stm32)
|
PR #31532: Size comparison from b840beb to 3b59593 Full report (19 builds for cc13x4_26x4, cc32xx, k32w, mbed, nrfconnect, qpg, stm32)
|
PR #31532: Size comparison from 46e1e4c to 675dddb Full report (19 builds for cc13x4_26x4, cc32xx, k32w, mbed, nrfconnect, qpg, stm32)
|
PR #31532: Size comparison from e09d5c8 to d3ee601 Full report (4 builds for cc32xx, mbed, stm32)
|
@cnanoleaf - You do not need to keep updating to master since that resets the CI pipline. Please let it finish as-is. |
PR #31532: Size comparison from 5fd93c4 to 3e5694c Full report (4 builds for cc32xx, mbed, stm32)
|
PR #31532: Size comparison from 73a4fd9 to 9d0f74d Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
* additions to support changes as discussed in connectedhomeip-spec project-chip#7825 * add Silabs platform example implementation * add extension for ExtendedAnnouncementFlag + Silabs platform usage * Restyled by clang-format * adjust based on review comments - 1 * Restyled by clang-format * add missing include guard for default case * Revert "Restyled by clang-format" This reverts commit 6d3f9e1. * fix extra bracket causing a bug + restyle changes * Restyled by clang-format * adjust based on review comments - 2 * Restyled by clang-format --------- Cherry picked from: ca17912 Co-authored-by: Restyled.io <commits@restyled.io>
…chip#31532)" This reverts commit be0c8be.
Hello,
This PR brings changes to support what was discussed/agreed as spec changes and merged based on #7825 regarding Extended Announcement.
This PR shows an example implementation for the Silabs platform. But the changes are generic and can be opted-into by any platform.
Platforms that do not require this functionality do not require any changes based on this PR.
For platforms that want to opt in, an example CHIPProjectConfig.h might look like this:
// current configuration option, extend the original basic window opened by the server
#define CHIP_DEVICE_CONFIG_DISCOVERY_TIMEOUT_SECS (60 * 60 * 48)
// new configuration option to opt-in into Extended Announcement
#define CHIP_DEVICE_CONFIG_BLE_EXT_ADVERTISING 1
// if required platforms can override the default configuration
#define CHIP_DEVICE_CONFIG_BLE_EXT_ADVERTISING_INTERVAL_CHANGE_TIME_MS (15 * 60 * 1000)
The problem this PR aims to solve is poor user setup experience (as defined in the spec change discussion) because the device cannot be found by a controller for a wide array of reasons (from time based to actual spurious failures especially based on the environment).
Fixes #31565