-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ICD] Remove ICDM OnTransitionToActiveMode
event
#31604
Merged
andy31415
merged 1 commit into
project-chip:master
from
mkardous-silabs:fix/remove_icd_event
Jan 22, 2024
Merged
[ICD] Remove ICDM OnTransitionToActiveMode
event
#31604
andy31415
merged 1 commit into
project-chip:master
from
mkardous-silabs:fix/remove_icd_event
Jan 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkardous-silabs
changed the title
[ICD] Remove ICDM event
[ICD] Remove ICDM Jan 22, 2024
OnTransitionToActiveMode
event
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mhazley
January 22, 2024 15:17
pullapprove
bot
requested review from
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
January 22, 2024 15:17
pullapprove
bot
added
review - pending
examples
darwin
controller
app
and removed
examples
darwin
controller
app
labels
Jan 22, 2024
Removing the Backwards compatibility check since the event / cluster was never released. |
mkardous-silabs
added
the
skip-protocol-compatibility
Marker that protocol backwards compatibility checks are to be skipped
label
Jan 22, 2024
PR #31604: Size comparison from c961d1b to 3facbd4 Increases (1 build for linux)
Decreases (5 builds for efr32, esp32, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
bzbarsky-apple
approved these changes
Jan 22, 2024
jmartinez-silabs
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app
controller
darwin
examples
review - approved
skip-protocol-compatibility
Marker that protocol backwards compatibility checks are to be skipped
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OnTransitionToActiveMode
was removed from the ICDM cluster spec.PR removes the event from the xml
Only change is the xml. Everything else is a regen.