Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow attribute-storage to compile even if GENERATED_CLUSTERS is not defined. #31693

Merged

Conversation

bzbarsky-apple
Copy link
Contributor

This can happen in configurations without any fixed endpoints at all (all endpoints are dynamic).

…defined.

This can happen in configurations without any fixed endpoints at all (all endpoints are dynamic).
Copy link

github-actions bot commented Jan 25, 2024

PR #31693: Size comparison from b8db5ee to 5ce0f49

Decreases (1 build for efr32)
platform target config section b8db5ee 5ce0f49 change % change
efr32 window-app BRD4187C (read/write) 1148000 1147992 -8 -0.0
.text 977532 977524 -8 -0.0
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
platform target config section b8db5ee 5ce0f49 change % change
bl602 lighting-app bl602 (read/write) 1428270 1428270 0 0.0
.bss 85328 85328 0 0.0
.data 9488 9488 0 0.0
.rodata 157320 157320 0 0.0
.text 1095490 1095490 0 0.0
bl602+mfd (read/write) 1442654 1442654 0 0.0
.bss 85488 85488 0 0.0
.data 9456 9456 0 0.0
.rodata 156280 156280 0 0.0
.text 1110792 1110792 0 0.0
bl602+rpc (read/write) 1475902 1475902 0 0.0
.bss 93360 93360 0 0.0
.data 9856 9856 0 0.0
.rodata 164896 164896 0 0.0
.text 1127132 1127132 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1193191 1193191 0 0.0
.bss 11121 11121 0 0.0
.data 3664 3664 0 0.0
.rodata 106708 106708 0 0.0
.text 964878 964878 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1204011 1204011 0 0.0
.bss 11297 11297 0 0.0
.data 3648 3648 0 0.0
.rodata 105648 105648 0 0.0
.text 976632 976632 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1284683 1284683 0 0.0
.bss 19589 19589 0 0.0
.data 4216 4216 0 0.0
.rodata 122080 122080 0 0.0
.text 1039582 1039582 0 0.0
bl706-eth (read/write) 1011725 1011725 0 0.0
.bss 23680 23680 0 0.0
.data 3240 3240 0 0.0
.rodata 100028 100028 0 0.0
.text 756822 756822 0 0.0
bl706-wifi (read/write) 1244622 1244622 0 0.0
.bss 10581 10581 0 0.0
.data 3672 3672 0 0.0
.rodata 121008 121008 0 0.0
.text 986972 986972 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1162524 1162524 0 0.0
.bss 16316 16316 0 0.0
.data 5032 5032 0 0.0
.rodata 100712 100712 0 0.0
.text 957728 957728 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1173924 1173924 0 0.0
.bss 16492 16492 0 0.0
.data 5008 5008 0 0.0
.rodata 99652 99652 0 0.0
.text 970050 970050 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 781412 781412 0 0.0
(read/write) 168864 168864 0 0.0
.bss 90884 90884 0 0.0
.data 3552 3552 0 0.0
.rodata 90316 90316 0 0.0
.text 690832 690832 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 798836 798836 0 0.0
(read/write) 179108 179108 0 0.0
.bss 101068 101068 0 0.0
.data 3580 3580 0 0.0
.rodata 84636 84636 0 0.0
.text 713932 713932 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 787356 787356 0 0.0
(read/write) 173564 173564 0 0.0
.bss 95524 95524 0 0.0
.data 3580 3580 0 0.0
.rodata 111388 111388 0 0.0
.text 675700 675700 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 738676 738676 0 0.0
(read/write) 167836 167836 0 0.0
.bss 89624 89624 0 0.0
.data 3540 3540 0 0.0
.rodata 86036 86036 0 0.0
.text 652376 652376 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 724316 724316 0 0.0
(read/write) 168048 168048 0 0.0
.bss 89848 89848 0 0.0
.data 3536 3536 0 0.0
.rodata 81884 81884 0 0.0
.text 642168 642168 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 572962 572962 0 0.0
(read/write) 207896 207896 0 0.0
.bss 201180 201180 0 0.0
.data 1592 1592 0 0.0
.rodata 84530 84530 0 0.0
.text 486312 486312 0 0.0
lock CC3235SF_LAUNCHXL (read only) 627250 627250 0 0.0
(read/write) 208296 208296 0 0.0
.bss 201656 201656 0 0.0
.data 1520 1520 0 0.0
.rodata 106402 106402 0 0.0
.text 518724 518724 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 564347 564347 0 0.0
.app_xip_area 454261 454261 0 0.0
.bss 64928 64928 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 547979 547979 0 0.0
.app_xip_area 433149 433149 0 0.0
.bss 69632 69632 0 0.0
.data 772 772 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566155 566155 0 0.0
.app_xip_area 457525 457525 0 0.0
.bss 63512 63512 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 562435 562435 0 0.0
.app_xip_area 450573 450573 0 0.0
.bss 66632 66632 0 0.0
.data 804 804 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 930384 930384 0 0.0
.bss 197912 197912 0 0.0
.data 1372 1372 0 0.0
.text 731080 731080 0 0.0
BRD4187C (read/write) 1108228 1108228 0 0.0
.bss 195164 195164 0 0.0
.data 3384 3384 0 0.0
.text 909660 909660 0 0.0
lock-app BRD4161A+wf200 (read/write) 1121688 1121688 0 0.0
.bss 188192 188192 0 0.0
.data 2800 2800 0 0.0
.text 930676 930676 0 0.0
window-app BRD4187C (read/write) 1148000 1147992 -8 -0.0
.bss 167156 167156 0 0.0
.data 3292 3292 0 0.0
.text 977532 977524 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1199900 1199900 0 0.0
(read/write) 1744776 1744776 0 0.0
.dram0.bss 73408 73408 0 0.0
.dram0.data 13588 13588 0 0.0
.flash.rodata 248248 248248 0 0.0
.flash.text 1199900 1199900 0 0.0
.iram0.text 75530 75530 0 0.0
m5stack (read only) 1241235 1241235 0 0.0
(read/write) 529720 529720 0 0.0
.dram0.bss 80272 80272 0 0.0
.dram0.data 35132 35132 0 0.0
.flash.rodata 278396 278396 0 0.0
.flash.text 1235071 1235071 0 0.0
.iram0.text 125403 125403 0 0.0
k32w contact k32w0+release (read only) 610592 610592 0 0.0
(read/write) 81324 81324 0 0.0
.bss 69104 69104 0 0.0
.data 2236 2236 0 0.0
.text 610056 610056 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 696276 696276 0 0.0
.bss 67760 67760 0 0.0
.data 2788 2788 0 0.0
.text 582256 582256 0 0.0
light k32w0+release (read only) 598952 598952 0 0.0
(read/write) 79332 79332 0 0.0
.bss 67160 67160 0 0.0
.data 2188 2188 0 0.0
.text 598416 598416 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 787256 787256 0 0.0
.bss 77428 77428 0 0.0
.data 2000 2000 0 0.0
.text 664376 664376 0 0.0
lock k32w0+release (read only) 580216 580216 0 0.0
(read/write) 78748 78748 0 0.0
.bss 66600 66600 0 0.0
.data 2164 2164 0 0.0
.text 579680 579680 0 0.0
linux air-purifier-app debug (read only) 2576741 2576741 0 0.0
(read/write) 127640 127640 0 0.0
.bss 46272 46272 0 0.0
.data 2176 2176 0 0.0
.data.rel.ro 73272 73272 0 0.0
.dynamic 608 608 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 181480 181480 0 0.0
.text 2218997 2218997 0 0.0
all-clusters-app debug (read only) 5790113 5790113 0 0.0
(read/write) 470432 470432 0 0.0
.bss 132992 132992 0 0.0
.data 4432 4432 0 0.0
.data.rel.ro 325624 325624 0 0.0
.dynamic 624 624 0 0.0
.got 5376 5376 0 0.0
.init 27 27 0 0.0
.init_array 1336 1336 0 0.0
.rodata 342500 342500 0 0.0
.text 5022835 5022835 0 0.0
all-clusters-minimal-app debug (read only) 5134465 5134465 0 0.0
(read/write) 235264 235264 0 0.0
.bss 127328 127328 0 0.0
.data 4336 4336 0 0.0
.data.rel.ro 96536 96536 0 0.0
.dynamic 624 624 0 0.0
.got 5296 5296 0 0.0
.init 27 27 0 0.0
.init_array 1112 1112 0 0.0
.rodata 285653 285653 0 0.0
.text 4615443 4615443 0 0.0
bridge-app debug (read only) 4551009 4551009 0 0.0
(read/write) 216496 216496 0 0.0
.bss 117920 117920 0 0.0
.data 6144 6144 0 0.0
.data.rel.ro 85712 85712 0 0.0
.dynamic 624 624 0 0.0
.got 5264 5264 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 227221 227221 0 0.0
.text 4104259 4104259 0 0.0
chip-tool debug (read only) 12109601 12109601 0 0.0
(read/write) 517776 517776 0 0.0
.bss 94232 94232 0 0.0
.data 5090 5090 0 0.0
.data.rel.ro 411200 411200 0 0.0
.dynamic 624 624 0 0.0
.got 5784 5784 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 440409 440409 0 0.0
.text 10961955 10961955 0 0.0
chip-tool-ipv6only arm64 (read only) 11642336 11642336 0 0.0
(read/write) 586000 586000 0 0.0
.bss 103288 103288 0 0.0
.data 4472 4472 0 0.0
.data.rel.ro 450760 450760 0 0.0
.dynamic 512 512 0 0.0
.got 20400 20400 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 347820 347820 0 0.0
.text 10405196 10405196 0 0.0
lighting-app debug+rpc+ui (read only) 5470033 5470033 0 0.0
(read/write) 225288 225288 0 0.0
.bss 118880 118880 0 0.0
.data 4800 4800 0 0.0
.data.rel.ro 94112 94112 0 0.0
.dynamic 672 672 0 0.0
.got 5880 5880 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 350964 350964 0 0.0
.text 4873443 4873443 0 0.0
lock-app debug (read only) 4621617 4621617 0 0.0
(read/write) 204080 204080 0 0.0
.bss 113280 113280 0 0.0
.data 4128 4128 0 0.0
.data.rel.ro 79960 79960 0 0.0
.dynamic 624 624 0 0.0
.got 5216 5216 0 0.0
.init 27 27 0 0.0
.init_array 840 840 0 0.0
.rodata 253845 253845 0 0.0
.text 4156787 4156787 0 0.0
ota-provider-app debug (read only) 4259729 4259729 0 0.0
(read/write) 192720 192720 0 0.0
.bss 113216 113216 0 0.0
.data 4288 4288 0 0.0
.data.rel.ro 69328 69328 0 0.0
.dynamic 624 624 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 206421 206421 0 0.0
.text 3861411 3861411 0 0.0
ota-requestor-app debug (read only) 4375745 4375745 0 0.0
(read/write) 196968 196968 0 0.0
.bss 114112 114112 0 0.0
.data 4688 4688 0 0.0
.data.rel.ro 72288 72288 0 0.0
.dynamic 624 624 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 212309 212309 0 0.0
.text 3967235 3967235 0 0.0
shell debug (read only) 2868145 2868145 0 0.0
(read/write) 154880 154880 0 0.0
.bss 62256 62256 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 85480 85480 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 185632 185632 0 0.0
.text 2510130 2510130 0 0.0
thermostat-no-ble arm64 (read only) 4448440 4448440 0 0.0
(read/write) 247056 247056 0 0.0
.bss 121672 121672 0 0.0
.data 3344 3344 0 0.0
.data.rel.ro 103272 103272 0 0.0
.dynamic 512 512 0 0.0
.got 12168 12168 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 158460 158460 0 0.0
.text 3946124 3946124 0 0.0
tv-app debug (read only) 5583761 5583761 0 0.0
(read/write) 350352 350352 0 0.0
.bss 243232 243232 0 0.0
.data 6496 6496 0 0.0
.data.rel.ro 93336 93336 0 0.0
.dynamic 624 624 0 0.0
.got 5512 5512 0 0.0
.init 27 27 0 0.0
.init_array 1128 1128 0 0.0
.rodata 284405 284405 0 0.0
.text 5059427 5059427 0 0.0
tv-casting-app debug (read only) 9978193 9978193 0 0.0
(read/write) 342456 342456 0 0.0
.bss 156000 156000 0 0.0
.data 2912 2912 0 0.0
.data.rel.ro 176648 176648 0 0.0
.dynamic 624 624 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 377224 377224 0 0.0
.text 9128579 9128579 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2531120 2531120 0 0.0
.bss 220392 220392 0 0.0
.data 5208 5208 0 0.0
.text 1493804 1493804 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1095932 1095932 0 0.0
bss 129801 129801 0 0.0
rodata 111372 111372 0 0.0
text 806920 806920 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1216180 1216180 0 0.0
bss 121939 121939 0 0.0
rodata 141176 141176 0 0.0
text 802564 802564 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1045332 1045332 0 0.0
bss 129527 129527 0 0.0
rodata 99204 99204 0 0.0
text 768880 768880 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 835352 835352 0 0.0
(read/write) 1792908 1792908 0 0.0
.bss 195348 195348 0 0.0
.data 2640 2640 0 0.0
.text 1586532 1586532 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 837656 837656 0 0.0
(read/write) 1715428 1715428 0 0.0
.bss 193068 193068 0 0.0
.data 2616 2616 0 0.0
.text 1511356 1511356 0 0.0
light cy8ckit_062s2_43012 (read only) 844352 844352 0 0.0
(read/write) 1636428 1636428 0 0.0
.bss 186556 186556 0 0.0
.data 2432 2432 0 0.0
.text 1439052 1439052 0 0.0
lock cy8ckit_062s2_43012 (read only) 817232 817232 0 0.0
(read/write) 1665748 1665748 0 0.0
.bss 213652 213652 0 0.0
.data 2456 2456 0 0.0
.text 1441252 1441252 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1122676 1122676 0 0.0
.bss 102352 102352 0 0.0
.data 808 808 0 0.0
.text 635056 635056 0 0.0
lock-app qpg6105+debug (read/write) 1086188 1086188 0 0.0
.bss 98536 98536 0 0.0
.data 852 852 0 0.0
.text 598564 598564 0 0.0
stm32 light STM32WB5MM-DK (read/write) 597573 597573 0 0.0
.bss 128288 128288 0 0.0
.data 660 660 0 0.0
.rodata 78748 78748 0 0.0
.text 380152 380152 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 825670 825670 0 0.0
bss 51020 51020 0 0.0
text 617624 617624 0 0.0
all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1114676 1114676 0 0.0
bss 100784 100784 0 0.0
text 789312 789312 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1091924 1091924 0 0.0
bss 109920 109920 0 0.0
text 760328 760328 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 935932 935932 0 0.0
bss 92988 92988 0 0.0
text 649722 649722 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 827562 827562 0 0.0
bss 51072 51072 0 0.0
text 619582 619582 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 4 4 0 0.0
(read/write) 985512 985512 0 0.0
bss 79116 79116 0 0.0
text 700302 700302 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1097924 1097924 0 0.0
bss 100064 100064 0 0.0
text 773952 773952 0 0.0
lock-app-dfu tlsr9528a (read only) 4 4 0 0.0
(read/write) 971448 971448 0 0.0
bss 97416 97416 0 0.0
text 653492 653492 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 953764 953764 0 0.0
bss 92564 92564 0 0.0
text 667668 667668 0 0.0
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 884824 884824 0 0.0
bss 69136 69136 0 0.0
text 626126 626126 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 825476 825476 0 0.0
bss 57380 57380 0 0.0
text 593050 593050 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 705772 705772 0 0.0
bss 73640 73640 0 0.0
text 462164 462164 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 829314 829314 0 0.0
bss 51200 51200 0 0.0
text 622352 622352 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 884105 884105 0 0.0
bss 60856 60856 0 0.0
text 636172 636172 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 851792 851792 0 0.0
bss 57668 57668 0 0.0
text 613346 613346 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 844528 844528 0 0.0
bss 57984 57984 0 0.0
text 605964 605964 0 0.0

@mergify mergify bot merged commit a9edb72 into project-chip:master Jan 26, 2024
57 checks passed
@bzbarsky-apple bzbarsky-apple deleted the compile-no-generated-clusters branch January 26, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants